Skip to content

feat: raise informative error or warning when passing narwhals object to nw.dependencies.is_*_dataframe #1437

Open
@MarcoGorelli

Description

@MarcoGorelli

If someone has a df: nw.DataFrame and they do

nw.dependencies.is_pandas_dataframe(df)

then they almost certainly meant to call

nw.dependencies.is_pandas_dataframe(df.to_native())

Source: I made this mistake 😳

To save others from making this mistake (as well as to save myself from re-making it in the future), we could:

  • raise an error
  • always raise a warning

Maybe just raising an error would be fine, I can't imagine a situation where you have an object which is either a narwhals dataframe or a native object and in both cases you pass it as-is to is_pandas_dataframe

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions