Hey @jrw34 it's great to hear that you are able to run and test the changes!

How should I go about sharing the in-progress work on my branch to this thread?

Feel free to open a draft PR either against narwhals or even against your narwhals fork.

I took a sneak peak at the branch and its changes: the tests are nice, yet I would suggest to try using the constructor and constructor_eager fixtures (you can find examples in the same file).

constructor(data) will create a native dataframe or lazyframe for all the backends we have, therefore you could replace nw.from_dict(data, backend=backend) with nw.from_native(constructor(data)). Then you can use it to test expression behavior.

constructor_eager will create a eager dataframe, which we often use to test series operations (same as what you did with df["a"]).

For a simple use of how we use constructor and constructor_eager, you can take a look at abs_test.py.

test: add test for division by zero #2619

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions