CMR10589: kondo cleanup, mostly removing str functions

Author: jceaser

umm-spec-lib/src/cmr/umm_spec/migration/version/subscription.clj

@@ -20,7 +20,7 @@
   [_context _subscription & _]
   (errors/throw-service-errors
    :bad-request
-   [(str "Cannot migrate UMM-Sub v1.1 to v1.0.")]))
+   ["Cannot migrate UMM-Sub v1.1 to v1.0."]))
 
 (defmethod interface/migrate-umm-version [:subscription "1.1" "1.1.1"]
   [_context subscription & _]

umm-spec-lib/src/cmr/umm_spec/umm_g/spatial.clj

@@ -34,7 +34,6 @@
 (defn- umm-g-gpolygon->GPolygon
   "Returns the spatial polygon from the given UMM-G GPolygon."
   [gpolygon]
-  [gpolygon]
   (let [outer-ring (umm-g-boundary->Ring (:Boundary gpolygon))
         holes (map umm-g-boundary->Ring (get-in gpolygon [:ExclusiveZone :Boundaries]))]
     (poly/polygon (cons outer-ring holes))))

umm-spec-lib/src/cmr/umm_spec/umm_to_xml_mappings/dif9/spatial_extent.clj

@@ -10,14 +10,14 @@
   [elevation-type]
   (if (.contains elevation-type "Altitude")
     (if (.contains elevation-type "Min")
-      (keyword (str "Minimum_Altitude"))
+      (keyword "Minimum_Altitude")
       (when (.contains elevation-type "Max")
-        (keyword (str "Maximum_Altitude"))))
+        (keyword "Maximum_Altitude")))
     (when (.contains elevation-type "Depth")
       (if (.contains elevation-type "Min")
-        (keyword (str "Minimum_Depth"))
+        (keyword "Minimum_Depth")
         (when (.contains elevation-type "Max")
-          (keyword (str "Maximum_Depth")))))))
+          (keyword "Maximum_Depth"))))))
 
 (defn- create-vertical-domain-maps
   "For the given passed in vector of UMM vertical domains key and value:

umm-spec-lib/src/cmr/umm_spec/umm_to_xml_mappings/iso19115_2/tiling_system.clj

@@ -32,7 +32,7 @@
       [:gmd:code
        (char-string (tiling-system-string tiling-system))]
       [:gmd:codeSpace
-       (char-string (str "gov.nasa.esdis.umm.tilingidentificationsystem"))]
+       (char-string "gov.nasa.esdis.umm.tilingidentificationsystem")]
       [:gmd:description
        (char-string (:TilingIdentificationSystemName tiling-system))]]]]])
 

umm-spec-lib/src/cmr/umm_spec/xml_to_umm_mappings/iso19115_2/spatial.clj

@@ -38,7 +38,7 @@
          "/" id-xpath "/gmd:code/gco:CharacterString")))
 
 (def zone-identifier-xpath
-  (str "/gmi:MI_Metadata/gmd:identificationInfo/gmd:MD_DataIdentification/gmd:extent/gmd:EX_Extent/gmd:geographicElement/gmd:EX_GeographicDescription[@id='ZoneIdentifier']/gmd:geographicIdentifier/gmd:MD_Identifier/gmd:code/gco:CharacterString"))
+  "/gmi:MI_Metadata/gmd:identificationInfo/gmd:MD_DataIdentification/gmd:extent/gmd:EX_Extent/gmd:geographicElement/gmd:EX_GeographicDescription[@id='ZoneIdentifier']/gmd:geographicIdentifier/gmd:MD_Identifier/gmd:code/gco:CharacterString")
 
 (def vertical-string-xpath
   (let [id-xpath "gmd:EX_GeographicDescription/gmd:geographicIdentifier/gmd:MD_Identifier"]

umm-spec-lib/src/cmr/umm_spec/xml_to_umm_mappings/iso19115_2/tiling_system.clj

@@ -9,7 +9,7 @@
    [cmr.umm-spec.xml-to-umm-mappings.iso-shared.shared-iso-parsing-util :as iso-xml-parsing-util]))
 
 (def tiling-system-xpath
-  (str "gmd:extent/gmd:EX_Extent[@id='TilingIdentificationSystem']/gmd:geographicElement/gmd:EX_GeographicDescription/gmd:geographicIdentifier/gmd:MD_Identifier"))
+  "gmd:extent/gmd:EX_Extent[@id='TilingIdentificationSystem']/gmd:geographicElement/gmd:EX_GeographicDescription/gmd:geographicIdentifier/gmd:MD_Identifier")
 
 (defn- get-double
   "Parse the input string into a double and return it. Return nil when I can't."

umm-spec-lib/src/cmr/umm_spec/xml_to_umm_mappings/iso_shared/characteristics_and_operationalmodes.clj

@@ -24,7 +24,7 @@
                  :Description (char-string-value chars (str pc-attr-base-path "/eos:description"))
                  :DataType    (value-of chars (str pc-attr-base-path "/eos:dataType/eos:EOS_AdditionalAttributeDataTypeCode"))
                  :Unit        (char-string-value chars (str pc-attr-base-path "/eos:parameterUnitsOfMeasure"))
-                 :Value       (char-string-value chars (str "eos:value"))})))))))
+                 :Value       (char-string-value chars "eos:value")})))))))
 
 (defn parse-operationalmodes
   "Returns the parsed operationalmodes from the element."
@@ -33,4 +33,4 @@
     (remove nil?
       (for [chars (select element characteristics-and-operationalmodes-xpath)]
         (when (= "OperationalMode" (char-string-value chars (str pc-attr-base-path "/eos:name")))
-          (char-string-value chars (str "eos:value")))))))
+          (char-string-value chars "eos:value"))))))