Message ID and OSAL ID type safety notes (Draco compliance)

[skliper]

Although Draco is planned as a "minor" release, we did add Message ID type safety logic. OSAL ID type safety is also enforced if OMIT_DEPRECATED=true in the build. Here's some quick notes I took from updating the GSFC apps to be compliant... feel free to request more details if needed. Note in updating the apps we did identify a couple cases where the values weren't being used appropriately (mostly in unit tests) so this is a valuable change/check to do to make the code more robust!

osal_id_t type safety:
OS_ObjectIdDefined
OS_ObjectIdToInteger (very rare use... avoid)
OS_ObjectIdFromInteger
OS_ObjectIdEqual
OS_OBJECT_ID_UNDEFINED
To initialize something valid see UT_OBJID_1... but probably better to just convert, or create via apis
  - DS_UT_OBJID_1 does the generic version

cfe specific osal_id_t related types
For fake unit test id's - CFE_ES_CDSHANDLE_C(CFE_RESOURCEID_WRAP(1)) or similar, or can often just create the resource and the handler will make a fake ID for you (except CDSHandle case)
  - APIID/TASKID/LIBID/COUNTERID/MEMHANDLE/CDSHANDLE
  - Invalid is also CFE_ES_*_UNDEFINED except CFE_ES_CDS_BAD_HANDLE
  - Tests CFE_RESOURCEID_TEST_DEFINED, CFE_RESOURCEID_TEST_EQUAL
  - Similar patterns for CFE_SB_PIPEID, but CFE_SB_INVALID_PIPE

CFE_SB_MsgId_t type safety:
Stay in CFE_SB_MsgId_t space, only unwrap for integer comparisons/switches/prints (avoid local unwrapped variables)
CFE_SB_ValueToMsgId, CFE_SB_MsgIdToValue for run time, CFE_SB_MSGID_WRAP_VALUE for compile time
CFE_SB_MsgId_Equal (works in UT since it's inline)
CFE_SB_INVALID_MSG_ID for run time CFE_SB_MSGID_RESERVED for compile time
CFE_SB_IsValidMsgId instead of comparing against INVALID/RESERVED constants
For printing 0x%08lX and cast to (unsigned long)

For creating UT ID's see the GSFC examples (*_UT_MID_1, etc) that will be available in their release.

sed -i 's/DS_CMD_MID;/CFE_SB_ValueToMsgId(DS_CMD_MID);/' *

[the-other-james]

Thanks for this note! I was just running into this problem updating an older app that was doing a direct comparison of TaskIds and CFE_RESOURCEID_TEST_EQUAL was just what I was looking for.