added numeric shift expression tests

abh80 · abh80 · commit 564f25468d2b · 2026-04-24T15:06:12.000+05:30
diff --git a/compiler/tools/fpp-check/test/numeric_shift/clean b/compiler/tools/fpp-check/test/numeric_shift/clean
@@ -0,0 +1,6 @@
+#!/bin/sh -e
+
+. ../../../../scripts/utils.sh
+
+clean
+rm -f default-tests.sh default-update-ref.sh
diff --git a/compiler/tools/fpp-check/test/numeric_shift/run b/compiler/tools/fpp-check/test/numeric_shift/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+export LOCAL_PATH_PREFIX=`cd ../../../../..; echo $PWD`
+../run-script
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_amount_too_large_error.fpp b/compiler/tools/fpp-check/test/numeric_shift/shift_amount_too_large_error.fpp
@@ -0,0 +1 @@
+constant a = 2 << 0x100000000
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_amount_too_large_error.ref.txt b/compiler/tools/fpp-check/test/numeric_shift/shift_amount_too_large_error.ref.txt
@@ -0,0 +1,6 @@
+fpp-check
+[ local path prefix ]/compiler/tools/fpp-check/test/numeric_shift/shift_amount_too_large_error.fpp:1.19
+constant a = 2 << 0x100000000
+                  ^
+error: invalid shift amount
+note: shift amount must be a non-negative value that fits in a 32-bit integer
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_boolean_value_error.fpp b/compiler/tools/fpp-check/test/numeric_shift/shift_boolean_value_error.fpp
@@ -0,0 +1 @@
+constant b = true >> 1
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_boolean_value_error.ref.txt b/compiler/tools/fpp-check/test/numeric_shift/shift_boolean_value_error.ref.txt
@@ -0,0 +1,5 @@
+fpp-check
+[ local path prefix ]/compiler/tools/fpp-check/test/numeric_shift/shift_boolean_value_error.fpp:1.19
+constant b = true >> 1
+                  ^
+error: cannot compute common type of bool and Integer
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_float_amount_error.fpp b/compiler/tools/fpp-check/test/numeric_shift/shift_float_amount_error.fpp
@@ -0,0 +1 @@
+constat a = 2 << 1.5
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_float_amount_error.ref.txt b/compiler/tools/fpp-check/test/numeric_shift/shift_float_amount_error.ref.txt
@@ -0,0 +1,5 @@
+fpp-check
+[ local path prefix ]/compiler/tools/fpp-check/test/numeric_shift/shift_float_amount_error.fpp:1.1
+constat a = 2 << 1.5
+^
+error: unexpected token
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_float_value_error.fpp b/compiler/tools/fpp-check/test/numeric_shift/shift_float_value_error.fpp
@@ -0,0 +1 @@
+constant a = 1.5 << 2
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_float_value_error.ref.txt b/compiler/tools/fpp-check/test/numeric_shift/shift_float_value_error.ref.txt
@@ -0,0 +1,67 @@
+Exception in thread "main" internal error: left shift failed
+	at fpp.compiler.util.InternalError$.apply(Error.scala:7)
+	at fpp.compiler.analysis.Analysis.shift(Analysis.scala:235)
+	at fpp.compiler.analysis.Analysis.lshift(Analysis.scala:214)
+	at fpp.compiler.analysis.EvalConstantExprs$.$anonfun$2(EvalConstantExprs.scala:152)
+	at fpp.compiler.analysis.EvalConstantExprs$.$anonfun$adapted$1(EvalConstantExprs.scala:152)
+	at fpp.compiler.analysis.EvalConstantExprs$.exprBinopNode$$anonfun$1(EvalConstantExprs.scala:155)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.analysis.EvalConstantExprs$.exprBinopNode(EvalConstantExprs.scala:157)
+	at fpp.compiler.analysis.EvalConstantExprs$.exprBinopNode(EvalConstantExprs.scala:142)
+	at fpp.compiler.ast.AstVisitor.matchExprNode(AstVisitor.scala:184)
+	at fpp.compiler.ast.AstVisitor.matchExprNode$(AstVisitor.scala:4)
+	at fpp.compiler.analysis.EvalConstantExprs$.matchExprNode(EvalConstantExprs.scala:7)
+	at fpp.compiler.analysis.TypeExpressionAnalyzer.exprNode(TypeExpressionAnalyzer.scala:23)
+	at fpp.compiler.analysis.TypeExpressionAnalyzer.exprNode$(TypeExpressionAnalyzer.scala:7)
+	at fpp.compiler.analysis.EvalConstantExprs$.exprNode(EvalConstantExprs.scala:190)
+	at fpp.compiler.analysis.TypeExpressionAnalyzer.defConstantAnnotatedNode(TypeExpressionAnalyzer.scala:89)
+	at fpp.compiler.analysis.TypeExpressionAnalyzer.defConstantAnnotatedNode$(TypeExpressionAnalyzer.scala:7)
+	at fpp.compiler.analysis.EvalConstantExprs$.defConstantAnnotatedNode(EvalConstantExprs.scala:27)
+	at fpp.compiler.analysis.EvalConstantExprs$.defConstantAnnotatedNode(EvalConstantExprs.scala:23)
+	at fpp.compiler.ast.AstVisitor.matchModuleMember(AstVisitor.scala:205)
+	at fpp.compiler.ast.AstVisitor.matchModuleMember$(AstVisitor.scala:4)
+	at fpp.compiler.analysis.EvalConstantExprs$.matchModuleMember(EvalConstantExprs.scala:7)
+	at fpp.compiler.ast.AstVisitor.matchTuMember(AstVisitor.scala:270)
+	at fpp.compiler.ast.AstVisitor.matchTuMember$(AstVisitor.scala:4)
+	at fpp.compiler.analysis.EvalConstantExprs$.matchTuMember(EvalConstantExprs.scala:7)
+	at fpp.compiler.analysis.Analyzer.transUnit$$anonfun$1(Analyzer.scala:18)
+	at fpp.compiler.util.Result$.foldLeft(Result.scala:31)
+	at fpp.compiler.ast.AstStateVisitor.visitList(AstStateVisitor.scala:25)
+	at fpp.compiler.ast.AstStateVisitor.visitList$(AstStateVisitor.scala:6)
+	at fpp.compiler.analysis.EvalConstantExprs$.visitList(EvalConstantExprs.scala:7)
+	at fpp.compiler.analysis.Analyzer.transUnit(Analyzer.scala:18)
+	at fpp.compiler.analysis.Analyzer.transUnit$(Analyzer.scala:6)
+	at fpp.compiler.analysis.EvalConstantExprs$.transUnit(EvalConstantExprs.scala:7)
+	at fpp.compiler.analysis.CheckSemantics$.tuList$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$1(CheckSemantics.scala:20)
+	at fpp.compiler.util.Result$.foldLeft(Result.scala:31)
+	at fpp.compiler.ast.AstStateVisitor.visitList(AstStateVisitor.scala:25)
+	at fpp.compiler.ast.AstStateVisitor.visitList$(AstStateVisitor.scala:6)
+	at fpp.compiler.analysis.EvalConstantExprs$.visitList(EvalConstantExprs.scala:7)
+	at fpp.compiler.analysis.CheckSemantics$.tuList$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2(CheckSemantics.scala:20)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.analysis.CheckSemantics$.tuList$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2(CheckSemantics.scala:36)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.analysis.CheckSemantics$.tuList$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2(CheckSemantics.scala:36)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.analysis.CheckSemantics$.tuList$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2(CheckSemantics.scala:36)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.analysis.CheckSemantics$.tuList$$anonfun$2$$anonfun$2$$anonfun$2$$anonfun$2(CheckSemantics.scala:36)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.analysis.CheckSemantics$.tuList$$anonfun$2$$anonfun$2$$anonfun$2(CheckSemantics.scala:36)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.analysis.CheckSemantics$.tuList$$anonfun$2$$anonfun$2(CheckSemantics.scala:36)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.analysis.CheckSemantics$.tuList$$anonfun$2(CheckSemantics.scala:36)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.analysis.CheckSemantics$.tuList(CheckSemantics.scala:36)
+	at fpp.compiler.tools.FPPCheck$.command$$anonfun$1(fpp-check.scala:25)
+	at scala.util.Either.flatMap(Either.scala:352)
+	at fpp.compiler.tools.FPPCheck$.command(fpp-check.scala:30)
+	at fpp.compiler.tools.FPPCheck$.toolMain$$anonfun$1(fpp-check.scala:55)
+	at fpp.compiler.util.Tool.mainMethod(Tool.scala:20)
+	at fpp.compiler.tools.FPPCheck$.toolMain(fpp-check.scala:55)
+	at fpp.compiler.tools.FPP$.command(fpp.scala:14)
+	at fpp.compiler.tools.FPP$.main$$anonfun$1(fpp.scala:37)
+	at fpp.compiler.util.Tool.mainMethod(Tool.scala:20)
+	at fpp.compiler.tools.FPP$.main(fpp.scala:37)
+	at fpp.compiler.tools.FPP.main(fpp.scala)
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_invalid_type_error.fpp b/compiler/tools/fpp-check/test/numeric_shift/shift_invalid_type_error.fpp
@@ -0,0 +1 @@
+constant a = "x" << 2
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_invalid_type_error.ref.txt b/compiler/tools/fpp-check/test/numeric_shift/shift_invalid_type_error.ref.txt
@@ -0,0 +1,5 @@
+fpp-check
+[ local path prefix ]/compiler/tools/fpp-check/test/numeric_shift/shift_invalid_type_error.fpp:1.18
+constant a = "x" << 2
+                 ^
+error: cannot compute common type of string and Integer
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_negative_amount_error.fpp b/compiler/tools/fpp-check/test/numeric_shift/shift_negative_amount_error.fpp
@@ -0,0 +1 @@
+constant a = 2 << -1
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_negative_amount_error.ref.txt b/compiler/tools/fpp-check/test/numeric_shift/shift_negative_amount_error.ref.txt
@@ -0,0 +1,6 @@
+fpp-check
+[ local path prefix ]/compiler/tools/fpp-check/test/numeric_shift/shift_negative_amount_error.fpp:1.19
+constant a = 2 << -1
+                  ^
+error: invalid shift amount
+note: shift amount must be a non-negative value that fits in a 32-bit integer
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_negative_rshift_error.fpp b/compiler/tools/fpp-check/test/numeric_shift/shift_negative_rshift_error.fpp
@@ -0,0 +1 @@
+constant a = 2 >> -1
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_negative_rshift_error.ref.txt b/compiler/tools/fpp-check/test/numeric_shift/shift_negative_rshift_error.ref.txt
@@ -0,0 +1,6 @@
+fpp-check
+[ local path prefix ]/compiler/tools/fpp-check/test/numeric_shift/shift_negative_rshift_error.fpp:1.19
+constant a = 2 >> -1
+                  ^
+error: invalid shift amount
+note: shift amount must be a non-negative value that fits in a 32-bit integer
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_ok.fpp b/compiler/tools/fpp-check/test/numeric_shift/shift_ok.fpp
@@ -0,0 +1,15 @@
+constant a = 2 << 2
+constant b = 8 >> 2
+constant c = 5 << 0
+constant d = 0 << 10
+constant f = -4 << 1
+constant g = -8 >> 1
+enum E { X  = 2 } 
+constant h = 4 << E.X
+constant i = 4 << 2 << 3
+constant j = (1 + 2) << 3
+constant k = 1 + 2 >> 3 + 1
+enum L: U32 { X = 1 << 31 }
+
+constant SomeBytePatternOffset = 4
+constant SomeBytePatternMask = 0x7F << SomeBytePatternOffset
diff --git a/compiler/tools/fpp-check/test/numeric_shift/shift_ok.ref.txt b/compiler/tools/fpp-check/test/numeric_shift/shift_ok.ref.txt
diff --git a/compiler/tools/fpp-check/test/numeric_shift/tests.sh b/compiler/tools/fpp-check/test/numeric_shift/tests.sh
@@ -0,0 +1,10 @@
+tests="
+shift_ok
+shift_negative_amount_error
+shift_negative_rshift_error
+shift_amount_too_large_error
+shift_float_amount_error
+shift_float_value_error
+shift_invalid_type_error
+shift_boolean_value_error
+"
diff --git a/compiler/tools/fpp-check/test/numeric_shift/update-ref b/compiler/tools/fpp-check/test/numeric_shift/update-ref
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+export LOCAL_PATH_PREFIX=`cd ../../../../..; echo $PWD`
+../update-ref-script
