Generalize uses of LinearBufferBase to SerialBufferBase where possible (#4995)

* issue-4335 delete Fw/Types/test/ut/SerializeBufferBaseTester.hpp

* issue-4335 rename SerializeBufferBase to LinearBufferBase and run formatter

* issue-4985 Reduce uses of LinearBufferBase to SerialBufferBase where possible excluding ones that require changes to FPP code gen and excluding unit tests

Author: odacindy-fprime

Drv/AsyncByteStreamBufferAdapter/test/ut/AsyncByteStreamBufferAdapterTester.cpp

@@ -43,7 +43,7 @@ void AsyncByteStreamBufferAdapterTester ::from_toByteStreamDriver_handler(FwInde
 // Tests
 // ----------------------------------------------------------------------
 
-void AsyncByteStreamBufferAdapterTester ::random_fill(Fw::LinearBufferBase& buffer, U32 max_size) {
+void AsyncByteStreamBufferAdapterTester ::random_fill(Fw::SerialBufferBase& buffer, U32 max_size) {
     U32 random_size = STest::Pick::lowerUpper(0, max_size);
     // buffer.resetSer();
     for (U32 i = 0; i < random_size; i++) {

Drv/AsyncByteStreamBufferAdapter/test/ut/AsyncByteStreamBufferAdapterTester.hpp

@@ -64,7 +64,7 @@ class AsyncByteStreamBufferAdapterTester final : public AsyncByteStreamBufferAda
     //! Initialize components
     void initComponents();
 
-    void random_fill(Fw::LinearBufferBase& buffer, U32 max_size);
+    void random_fill(Fw::SerialBufferBase& buffer, U32 max_size);
 
   private:
     // ----------------------------------------------------------------------

Drv/ByteStreamBufferAdapter/test/ut/ByteStreamBufferAdapterTester.cpp

@@ -42,7 +42,7 @@ Drv::ByteStreamStatus ByteStreamBufferAdapterTester ::from_toByteStreamDriver_ha
 // Tests
 // ----------------------------------------------------------------------
 
-void ByteStreamBufferAdapterTester ::random_fill(Fw::LinearBufferBase& buffer, U32 max_size) {
+void ByteStreamBufferAdapterTester ::random_fill(Fw::SerialBufferBase& buffer, U32 max_size) {
     U32 random_size = STest::Pick::lowerUpper(0, max_size);
     // buffer.resetSer();
     for (U32 i = 0; i < random_size; i++) {

Drv/ByteStreamBufferAdapter/test/ut/ByteStreamBufferAdapterTester.hpp

@@ -69,7 +69,7 @@ class ByteStreamBufferAdapterTester final : public ByteStreamBufferAdapterGTestB
     void initComponents();
 
     //! Fill buffer with random data
-    void random_fill(Fw::LinearBufferBase& buffer, U32 max_size);
+    void random_fill(Fw::SerialBufferBase& buffer, U32 max_size);
 
   private:
     // ----------------------------------------------------------------------

Fw/Log/AmpcsEvrLogPacket.hpp

@@ -25,7 +25,7 @@ class AmpcsEvrLogPacket : public ComPacket {
 
     SerializeStatus serializeTo(SerialBufferBase& buffer,
                                 Fw::Endianness mode = Fw::Endianness::BIG) const override;  //!< serialize contents
-    SerializeStatus deserializeFrom(LinearBufferBase& buffer, Fw::Endianness mode = Fw::Endianness::BIG);
+    SerializeStatus deserializeFrom(SerialBufferBase& buffer, Fw::Endianness mode = Fw::Endianness::BIG);
 
     void setTaskName(U8* taskName, U8 len);
     void setId(U32 eventID);

Svc/Ccsds/AosFramer/AosFramer.cpp

@@ -340,7 +340,7 @@ void AosFramer ::pack_packet(Fw::Buffer& data, const ComCfg::FrameContext& conte
     }
 }
 
-void AosFramer ::serialize_idle_spp_packet(Fw::LinearBufferBase& serializer, U16 length) {
+void AosFramer ::serialize_idle_spp_packet(Fw::SerialBufferBase& serializer, U16 length) {
     // APID to use for this Idle Packet
     constexpr U16 idleApid = static_cast<U16>(ComCfg::Apid::SPP_IDLE_PACKET);
 

Svc/Ccsds/AosFramer/AosFramer.hpp

@@ -137,7 +137,7 @@ class AosFramer final : public AosFramerComponentBase {
     //! (minus optional CRC)
     void fill_with_idle_packet(AosVc& vc, const ComCfg::FrameContext& context);
 
-    void serialize_idle_spp_packet(Fw::LinearBufferBase& serializer, U16 length);
+    void serialize_idle_spp_packet(Fw::SerialBufferBase& serializer, U16 length);
 
     //! Fill out the Transfer Frame Primary Header (4.1.2)
     void setup_header(const ComCfg::FrameContext& context);

Svc/Ccsds/TmFramer/TmFramer.cpp

@@ -105,7 +105,7 @@ void TmFramer ::dataReturnIn_handler(FwIndexType portNum,
     this->m_bufferState = BufferOwnershipState::OWNED;
 }
 
-void TmFramer ::fill_with_idle_packet(Fw::LinearBufferBase& serializer) {
+void TmFramer ::fill_with_idle_packet(Fw::SerialBufferBase& serializer) {
     constexpr U16 endIndex = ComCfg::TmFrameFixedSize - TMTrailer::SERIALIZED_SIZE;
     constexpr U16 idleApid = static_cast<U16>(ComCfg::Apid::SPP_IDLE_PACKET);
     const U16 startIndex = static_cast<U16>(serializer.getSize());

Svc/Ccsds/TmFramer/TmFramer.hpp

@@ -92,7 +92,7 @@ class TmFramer final : public TmFramerComponentBase {
     //! Fill the frame buffer with an Idle Packet to complete the frame data field
     //! as per CCSDS TM Protocol paragraph 4.2.2.5. Idle packet is inserted at the
     //! start_index index of the frame buffer, and fills it up to the end minus CRC
-    void fill_with_idle_packet(Fw::LinearBufferBase& serializer);
+    void fill_with_idle_packet(Fw::SerialBufferBase& serializer);
 
     // ----------------------------------------------------------------------
     // Members

Svc/CmdSequencer/test/ut/SequenceFiles/FPrime/Headers.cpp

@@ -23,7 +23,7 @@ void serialize(U32 dataSize,
                U32 numRecords,
                FwTimeBaseStoreType timeBase,
                FwTimeContextStoreType timeContext,
-               Fw::LinearBufferBase& destBuffer) {
+               Fw::SerialBufferBase& destBuffer) {
     ASSERT_EQ(Fw::FW_SERIALIZE_OK, destBuffer.serializeFrom(dataSize));
     ASSERT_EQ(Fw::FW_SERIALIZE_OK, destBuffer.serializeFrom(numRecords));
     ASSERT_EQ(Fw::FW_SERIALIZE_OK, destBuffer.serializeFrom(timeBase));