Switch the type of the Task priority to FwTaskPriorityType (#3617)

* Change the type of the Task priority to FwTaskPriorityType

* Fix missed UT arg update

---------

Co-authored-by: Mishaal Aleem <aleem@fprime-fsw-0.jpl.nasa.gov>
Co-authored-by: Rob Bocchino <bocchino@jpl.nasa.gov>

Author: 3 people

Drv/Ip/SocketComponentHelper.cpp

@@ -22,7 +22,7 @@ SocketComponentHelper::SocketComponentHelper() {}
 SocketComponentHelper::~SocketComponentHelper() {}
 
 void SocketComponentHelper::start(const Fw::StringBase &name,
-                                  const Os::Task::ParamType priority,
+                                  const FwTaskPriorityType priority,
                                   const Os::Task::ParamType stack,
                                   const Os::Task::ParamType cpuAffinity) {
     FW_ASSERT(m_task.getState() == Os::Task::State::NOT_STARTED);  // It is a coding error to start this task multiple times

Drv/Ip/SocketComponentHelper.hpp

@@ -46,18 +46,18 @@ class SocketComponentHelper {
     /**
      * \brief start the socket read task to start producing data
      *
-     * Starts up the socket reading task and when reopen was configured, will open up the socket. 
-     * 
+     * Starts up the socket reading task and when reopen was configured, will open up the socket.
+     *
      * \note: users must now use `setAutomaticOpen` to configure the socket to automatically open connections. The
      *        default behavior is to automatically open connections.
      *
      * \param name: name of the task
-     * \param priority: priority of the started task. See: Os::Task::start. Default: TASK_DEFAULT, not prioritized
+     * \param priority: priority of the started task. See: Os::Task::start. Default: TASK_PRIORITY_DEFAULT, not prioritized
      * \param stack: stack size provided to the task. See: Os::Task::start. Default: TASK_DEFAULT, posix threads default
      * \param cpuAffinity: cpu affinity provided to task. See: Os::Task::start. Default: TASK_DEFAULT, don't care
      */
     void start(const Fw::StringBase &name,
-               const Os::Task::ParamType priority = Os::Task::TASK_DEFAULT,
+               const FwTaskPriorityType priority = Os::Task::TASK_PRIORITY_DEFAULT,
                const Os::Task::ParamType stack = Os::Task::TASK_DEFAULT,
                const Os::Task::ParamType cpuAffinity = Os::Task::TASK_DEFAULT);
 
@@ -88,8 +88,8 @@ class SocketComponentHelper {
      * \brief set socket to automatically open connections when true, or not when false
      *
      * When passed `true`, this instructs the socket to automatically open a socket and reopen socket failed connections. When passed `false`
-     * the user must explicitly call the `open` method to open the socket initially and when a socket fails.  
-     * 
+     * the user must explicitly call the `open` method to open the socket initially and when a socket fails.
+     *
      * \param auto_open: true to automatically open and reopen sockets, false otherwise
      */
     void setAutomaticOpen(bool auto_open);

Drv/LinuxGpioDriver/LinuxGpioDriver.hpp

@@ -67,7 +67,7 @@ class LinuxGpioDriver final : public LinuxGpioDriverComponentBase {
 
     //! \brief start interrupt detection thread
     //!
-    Drv::GpioStatus start(const FwSizeType priority = Os::Task::TASK_DEFAULT,
+    Drv::GpioStatus start(const FwTaskPriorityType priority = Os::Task::TASK_PRIORITY_DEFAULT,
                           const FwSizeType stackSize = Os::Task::TASK_DEFAULT,
                           const FwSizeType cpuAffinity = Os::Task::TASK_DEFAULT,
                           const PlatformUIntType identifier = static_cast<PlatformUIntType>(Os::Task::TASK_DEFAULT));

Drv/LinuxGpioDriver/LinuxGpioDriverCommon.cpp

@@ -21,7 +21,7 @@ namespace Drv {
 
 LinuxGpioDriver ::LinuxGpioDriver(const char* const compName) : LinuxGpioDriverComponentBase(compName) {}
 
-Drv::GpioStatus LinuxGpioDriver ::start(const FwSizeType priority,
+Drv::GpioStatus LinuxGpioDriver ::start(const FwTaskPriorityType priority,
                                         const FwSizeType stackSize,
                                         const FwSizeType cpuAffinity,
                                         const PlatformUIntType identifier) {

Drv/LinuxUartDriver/LinuxUartDriver.cpp

@@ -363,7 +363,7 @@ void LinuxUartDriver ::serialReadTaskEntry(void* ptr) {
     }
 }
 
-void LinuxUartDriver ::start(Os::Task::ParamType priority, Os::Task::ParamType stackSize, Os::Task::ParamType cpuAffinity) {
+void LinuxUartDriver ::start(FwTaskPriorityType priority, Os::Task::ParamType stackSize, Os::Task::ParamType cpuAffinity) {
     Os::TaskString task("SerReader");
     Os::Task::Arguments arguments(task, serialReadTaskEntry, this, priority, stackSize, cpuAffinity);
     Os::Task::Status stat = this->m_readTask.start(arguments);

Drv/LinuxUartDriver/LinuxUartDriver.hpp

@@ -72,7 +72,7 @@ class LinuxUartDriver final : public LinuxUartDriverComponentBase {
     //! start the serial poll thread.
     //! buffSize is the max receive buffer size
     //!
-    void start(Os::Task::ParamType priority = Os::Task::TASK_DEFAULT,
+    void start(FwTaskPriorityType priority = Os::Task::TASK_PRIORITY_DEFAULT,
                Os::Task::ParamType stackSize = Os::Task::TASK_DEFAULT,
                Os::Task::ParamType cpuAffinity = Os::Task::TASK_DEFAULT);
 

Drv/TcpClient/test/ut/TcpClientTester.cpp

@@ -40,7 +40,7 @@ void TcpClientTester ::setup_helper(Drv::TcpServerSocket& server, Drv::SocketDes
     if (recv_thread) {
         Os::TaskString name("receiver thread");
         this->component.setAutomaticOpen(reconnect);
-        this->component.start(name, Os::Task::TASK_DEFAULT, Os::Task::TASK_DEFAULT);
+        this->component.start(name, Os::Task::TASK_PRIORITY_DEFAULT, Os::Task::TASK_DEFAULT);
     }
 }
 

Drv/TcpServer/test/ut/TcpServerTester.cpp

@@ -33,7 +33,7 @@ void TcpServerTester ::setup_helper(bool recv_thread, bool reconnect) {
     if (recv_thread) {
         Os::TaskString name("receiver thread");
         this->component.setAutomaticOpen(reconnect);
-        this->component.start(name, Os::Task::TASK_DEFAULT, Os::Task::TASK_DEFAULT);
+        this->component.start(name, Os::Task::TASK_PRIORITY_DEFAULT, Os::Task::TASK_DEFAULT);
     }
     // Component should always launch the listening server on configure
     // The thread will retry if the configure fails
@@ -179,7 +179,7 @@ void TcpServerTester ::test_advanced_reconnect() {
 void TcpServerTester ::test_no_automatic_send_connection() {
     Drv::TcpClientSocket client;
     Drv::SocketDescriptor client_fd;
-    
+
     // Set up the server without automatic connection
     this->setup_helper(false, true);
     this->component.setAutomaticOpen(false);

Drv/Udp/test/ut/UdpTester.cpp

@@ -52,7 +52,7 @@ void UdpTester::test_with_loop(U32 iterations, bool recv_thread) {
     // Start up a receive thread
     if (recv_thread) {
         Os::TaskString name("receiver thread");
-        this->component.start(name, true, Os::Task::TASK_DEFAULT, Os::Task::TASK_DEFAULT);
+        this->component.start(name, true, Os::Task::TASK_PRIORITY_DEFAULT, Os::Task::TASK_DEFAULT);
     }
 
     // Loop through a bunch of client disconnects

Fw/Comp/ActiveComponentBase.cpp

@@ -43,7 +43,7 @@ namespace Fw {
     }
 #endif
 
-    void ActiveComponentBase::start(Os::Task::ParamType priority, Os::Task::ParamType stackSize, Os::Task::ParamType cpuAffinity, Os::Task::ParamType identifier) {
+    void ActiveComponentBase::start(FwTaskPriorityType priority, Os::Task::ParamType stackSize, Os::Task::ParamType cpuAffinity, Os::Task::ParamType identifier) {
         Os::TaskString taskName;
 
 #if FW_OBJECT_NAMES == 1