Skip to content

Commit fca26cb

Browse files
authored
Ref: call deinitComponents during topology teardown (#4998)
1 parent 75bd1af commit fca26cb

3 files changed

Lines changed: 4 additions & 0 deletions

File tree

.github/actions/spelling/allow.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
AUTOGEN
22
atype
3+
deinit
34
github
45
https
56
ssh

Ref/Top/RefTopology.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,5 +108,6 @@ void teardownTopology(const TopologyState& state) {
108108
// Resource deallocation
109109
cmdSeq.deallocateBuffer(mallocator);
110110
tearDownComponents(state);
111+
deinitComponents(state);
111112
}
112113
} // namespace Ref

Ref/Top/RefTopology.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ void setupTopology(const TopologyState& state);
5454
* 3. Stop the tasks not owned by active components
5555
* 4. Join to the tasks not owned by active components
5656
* 5. Deallocate other resources
57+
* 6. Call the autocoded `tearDownComponents()` function to tear down component-owned resources
58+
* 7. Call the autocoded `deinitComponents()` function to finish component shutdown
5759
*
5860
* Step 1, 2, 3, and 4 must occur in-order as the tasks must be stopped before being joined. These tasks must be stopped
5961
* and joined before any active resources may be deallocated.

0 commit comments

Comments
 (0)