Skip to content

Commit 0917302

Browse files
authored
Update reference file for Giovanni averaging service (#266)
1 parent df62749 commit 0917302

5 files changed

Lines changed: 22 additions & 15 deletions

File tree

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ versioning. Rather than a static releases, this repository contains of a number
55
of regression tests that are each semi-independent. This CHANGELOG file should be used
66
to document pull requests to this repository.
77

8+
## 2026-04-01
9+
10+
### Changed ([#266](https://github.com/nasa/harmony-regression-tests/pull/266))
11+
12+
- Updated the reference csv file for the giovanni averaging service to reflect changes to make time format more consistent.
13+
- Added an assertion to fail giovanni averaging service test suite when no files are available to download.
14+
- Updated the readme to include reference to the wiki page for regression failure points of contact.
15+
816
## 2026-03-31 ([#264](https://github.com/nasa/harmony-regression-tests/pull/264))
917

1018
### Changed

README.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ file is updated. To do so, simply add a new target to the
161161
```
162162
list in the [notebook-test-suite.yml](https://github.com/nasa/harmony-regression-tests/blob/main/.github/workflows/notebook-test-suite.yml)
163163
164-
1. If you want to trigger your tests by hand on GitHub, add your test name to the:
164+
1. If you want to trigger your tests by hand on GitHub, add your test name to the list of the [notebook-test-suite.yml](https://github.com/nasa/harmony-regression-tests/blob/main/.github/workflows/notebook-test-suite.yml):
165165
```yaml
166166
on:
167167
workflow_dispatch:
@@ -171,12 +171,7 @@ file is updated. To do so, simply add a new target to the
171171
- batchee
172172
- your-new-service
173173
```
174-
list of the [notebook-test-suite.yml](https://github.com/nasa/harmony-regression-tests/blob/main/.github/workflows/notebook-test-suite.yml)
175-
176-
1. Provide the Harmony team with an email address and Slack user that can be
177-
contacted if your test suite fails during an automated run either in GitHub or
178-
Bamboo. Please also let the Harmony team know if either of these pieces of
179-
information need to be updated.
174+
1. Provide the Harmony team with an email address and Slack user that can be contacted if your test suite fails during an automated run either in GitHub or Bamboo. This can be added to the wiki page here: https://wiki.earthdata.nasa.gov/spaces/HARMONY/pages/474940034/Harmony+Regression+Tests+Points+of+Contact. Please also update this wiki page if either of these pieces of information need to be changed
180175
181176
## Test suite contents:
182177

test/giovanni-averaging-service/GiovanniAveragingService_Regression.ipynb

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,9 @@
181181
")\n",
182182
"\n",
183183
"with tempfile.TemporaryDirectory() as tmpdir:\n",
184-
" results = harmony_client.download_all(job_id, directory=tmpdir)\n",
184+
" results = list(harmony_client.download_all(job_id, directory=tmpdir))\n",
185+
" assert results, \"Job failed: No files are available to download\"\n",
186+
"\n",
185187
" for r in results:\n",
186188
" downloaded_csv = r.result()\n",
187189
" assert os.path.exists(downloaded_csv)\n",
@@ -249,7 +251,9 @@
249251
")\n",
250252
"\n",
251253
"with tempfile.TemporaryDirectory() as tmpdir:\n",
252-
" results = harmony_client.download_all(job_id, directory=tmpdir)\n",
254+
" results = list(harmony_client.download_all(job_id, directory=tmpdir))\n",
255+
" assert results, \"Job failed: No files are available to download\"\n",
256+
"\n",
253257
" for r in results:\n",
254258
" downloaded_tif = r.result()\n",
255259
" assert os.path.exists(downloaded_tif)\n",

test/giovanni-averaging-service/reference_data/8539508_GIOVANNI-areaAvgTimeSeries.GPM_3IMERGHH_07_precipitation.20210829-20210829.110W_25N_78W_35N.csv

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ User Bounding Box:,"-110, 25, -78, 35"
44
Fill Value:,-9999.900390625
55
,
66
time,mean_GPM_3IMERGHH_07_precipitation
7-
2021-08-29T07:30:00.000000000,0.46100518
8-
2021-08-29T08:00:00.000000000,0.43554193
9-
2021-08-29T08:30:00.000000000,0.39419016
10-
2021-08-29T09:00:00.000000000,0.42885283
11-
2021-08-29T09:30:00.000000000,0.4569692
7+
2021-08-29T07:30:00,0.46100518
8+
2021-08-29T08:00:00,0.43554193
9+
2021-08-29T08:30:00,0.39419016
10+
2021-08-29T09:00:00,0.42885283
11+
2021-08-29T09:30:00,0.4569692
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.1.5
1+
1.1.5a

0 commit comments

Comments
 (0)