Merge branch 'develop-clean-copilot-diagrams' into develop. Close #351.

**Description**

The diagrams template includes two functions, `noneOf` and
`checkValidTransitions`, that are not used by the backend or any of the
generated code. While in general they can be useful, since they are
currently not being used, it's best to remove them.

**Type**

- Bug: Template includes unused code.

**Additional context**

None.

**Requester**

- Ivan Perez.

**Method to check presence of bug**

The template file `ogma-core/templates/diagram/Copilot.hs` contains the
functions `noneOf` and `checkValidTransitions`, which are not used
anywhere in the template, and are not mentioned anywhere in the diagrams
backend `ogma-core/src/Command/Diagram.hs`. Because that module uses a
function `noneOf` from `Text.Megaparsec`, it's not possible to use
regexp matching to determine that the functions in the template are also
not used by text inserted in the module by the backend.

**Expected result**

The template file `ogma-core/templates/diagram/Copilot.hs` does not
include the functions `noneOf` or `checkValidTransitions`.

**Solution implemented**

Remove the definitions `noneOf` and `checkValidTransitions` from
`ogma-core/templates/diagram/Copilot.hs`.

Remove any references to the aforementioned functions from any existing
documentation.

**Further notes**

None.

Author: ivanperez-keera

ogma-core/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Revision history for ogma-core
 
+## [1.X.Y] - 2026-01-25
+
+* Remove unused functions from diagram template (#351).
+
 ## [1.12.0] - 2026-01-21
 
 * Version bump 1.12.0 (#336).

ogma-core/src/Command/Diagram.hs

@@ -91,12 +91,11 @@ import           Language.Trans.SMV2Copilot    as SMV (boolSpec2Copilot,
 --
 -- PRE: The file given is readable, contains a valid file with recognizable
 -- format, the formulas in the file do not use any identifiers that exist in
--- Copilot, or any of @stateMachine@, @externalState@, @noneOf@,
--- @checkValidTransitions@, @main@, @spec@, @stateMachine1@, @clock@, @ftp@,
--- @notPreviousNot@. All identifiers used are valid C99 identifiers. The
--- template, if provided, exists and uses the variables needed by the diagram
--- application generator. The target directory is writable and there's enough
--- disk space to copy the files over.
+-- Copilot, or any of @stateMachine@, @externalState@, @main@, @spec@,
+-- @stateMachine1@, @clock@, @ftp@, @notPreviousNot@. All identifiers used are
+-- valid C99 identifiers. The template, if provided, exists and uses the
+-- variables needed by the diagram application generator. The target directory
+-- is writable and there's enough disk space to copy the files over.
 diagram :: FilePath       -- ^ Path to a file containing a diagram
         -> DiagramOptions -- ^ Customization options
         -> IO (Result ErrorCode)
@@ -138,12 +137,11 @@ diagram fp options = do
 --
 -- PRE: The file given is readable, contains a valid file with recognizable
 -- format, the formulas in the file do not use any identifiers that exist in
--- Copilot, or any of @stateMachine@, @externalState@, @noneOf@,
--- @checkValidTransitions@, @main@, @spec@, @stateMachine1@, @clock@, @ftp@,
--- @notPreviousNot@. All identifiers used are valid C99 identifiers. The
--- template, if provided, exists and uses the variables needed by the diagram
--- application generator. The target directory is writable and there's enough
--- disk space to copy the files over.
+-- Copilot, or any of @stateMachine@, @externalState@, @main@, @spec@,
+-- @stateMachine1@, @clock@, @ftp@, @notPreviousNot@. All identifiers used are
+-- valid C99 identifiers. The template, if provided, exists and uses the
+-- variables needed by the diagram application generator. The target directory
+-- is writable and there's enough disk space to copy the files over.
 diagram' :: FilePath
          -> DiagramOptions
          -> ExprPair

ogma-core/templates/diagram/Copilot.hs

@@ -46,33 +46,3 @@ stateMachineGF (initialState, finalState, noInputData, transitions, badState) =
 
     ifThenElses ((s1,i,s2):ss) =
       ifThenElse (previousState == constant s1 && i) (constant s2) (ifThenElses ss)
-
--- | True when the given input stream does hold any of the values in the given
--- list.
-noneOf :: [Stream Bool] -> Stream Bool
-noneOf []     = true
-noneOf (x:xs) = not x && noneOf xs
-
--- | Given a list of transitions, and a current state, and a list of possible
--- destination states, produce a list of booleans indicating if a transition to
--- each of the destination states would be valid.
-checkValidTransitions :: [(Word8, Stream Bool, Word8)]
-                      -> Stream Word8
-                      -> [Word8]
-                      -> [Stream Bool]
-checkValidTransitions transitions curState destinations =
-  map (checkValidTransition transitions curState) destinations
-
--- | Given a list of transitions, and a current state, and destination states,
--- produce a list of booleans indicating if a transition to each of the
--- destination states would be valid.
-checkValidTransition :: [(Word8, Stream Bool, Word8)]
-                     -> Stream Word8
-                     -> Word8
-                     -> Stream Bool
-checkValidTransition []                 _   _   = true
-checkValidTransition ((so1, c, sd1):sx) so2 sd2 =
-  ifThenElse
-    ((constant so1 == so2) && (constant sd1 == constant sd2))
-    c
-    (checkValidTransition sx so2 sd2)