Skip to content

Commit 87ba787

Browse files
committed
Merge branch 'feature/historical-conditions' of https://github.com/nasa/openmct into feature/historical-conditions
mergin master
2 parents 9579841 + 6f222f3 commit 87ba787

3 files changed

Lines changed: 25 additions & 1 deletion

File tree

e2e/tests/functional/plugins/operatorStatus/operatorStatus.e2e.spec.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,20 @@ test.describe('Operator Status', () => {
158158
expect(updatedRowValuesArr[COLUMN_STATUS_INDEX]).toEqual(UNSET_VALUE_LABEL);
159159
});
160160

161+
test('Poll indicator is visible when window is really small', async ({ page }) => {
162+
const pollIndicator = page.locator('div[title="Set my operator status"]');
163+
//Make window narrow
164+
await page.setViewportSize({ width: 640, height: 480 });
165+
await page.getByLabel('Display as single line').click();
166+
const indicatorsCount = await page.locator('.c-indicator').count();
167+
//Assert that multiple indicators are active
168+
expect(indicatorsCount).toBeGreaterThanOrEqual(3);
169+
//Assert that indicators are expanded
170+
await expect(page.locator('.l-shell__head')).toContainClass('l-shell__head--expanded');
171+
//Expect poll indicator to be visible
172+
await expect(pollIndicator).toBeInViewport({ ratio: 1 });
173+
});
174+
161175
test.fixme('iterate through all possible response values', async ({ page }) => {
162176
// test all possible response values for the poll
163177
});

src/plugins/operatorStatus/operatorStatus/OperatorStatusIndicator.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
*****************************************************************************/
2222
import mount from 'utils/mount';
2323

24+
import PRIORITIES from '../../../api/priority/PriorityAPI.js';
2425
import AbstractStatusIndicator from '../AbstractStatusIndicator.js';
2526
import OperatorStatusComponent from './OperatorStatus.vue';
2627

@@ -62,6 +63,7 @@ export default class OperatorStatusIndicator extends AbstractStatusIndicator {
6263
operatorIndicator.element.classList.add('c-indicator--operator-status');
6364
operatorIndicator.element.classList.add('no-minify');
6465
operatorIndicator.on('click', this.showPopup);
66+
operatorIndicator.priority = PRIORITIES.HIGHEST;
6567

6668
return operatorIndicator;
6769
}

src/plugins/timeline/TimelineCompositionPolicy.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ const ALLOWED_TYPES = [
2828
'eventGenerator',
2929
'eventGeneratorWithAcknowledge',
3030
'yamcs.events',
31-
'yamcs.event.specific.severity',
31+
'yamcs.events.severity',
32+
'yamcs.events.source',
33+
'yamcs.events.source.severity',
3234
'yamcs.commands',
3335
'yamcs.commands.queue'
3436
];
@@ -47,6 +49,12 @@ export default function TimelineCompositionPolicy(openmct) {
4749
if (parent.type === 'time-strip') {
4850
const metadata = openmct.telemetry.getMetadata(child);
4951

52+
if (child.type === 'yamcs.event.specific.severity') {
53+
console.warn(
54+
'Type yamcs.event.specific.severity is deprecated. Use yamcs.events.source.severity.'
55+
);
56+
}
57+
5058
if (
5159
!DISALLOWED_TYPES.includes(child.type) &&
5260
(openmct.telemetry.hasNumericTelemetry(child) ||

0 commit comments

Comments
 (0)