Commit c120be9
committed
build: commit PDFium binaries directly instead of fetching in CI
The fetch-pdfium.sh + gitignore approach caused a silent file-loss
between the fetch step and tauri-action's cargo build on CI: the
fetch step logged `installed to .../src-tauri/pdfium:` with the
file present, but tauri-build.rs then reported "resource path
doesn't exist" / "Library not found". Locally reproduced by
removing the dylib — same error — confirming the file really is
missing at build.rs time on CI. Root cause never nailed down;
suspected interaction between .gitignore rules and something in
the CI pipeline cleaning gitignored files.
Pragmatic fix: just ship the three platform binaries in the repo
(~21 MB total). Pros:
- Eliminates the entire fetch/placement failure mode.
- CI builds don't depend on upstream release availability.
- Works the same way locally and in CI.
Cons (acknowledged):
- Repo size grows by ~21 MB.
- PDFium updates now require manual re-download + commit.
PDFium is licensed Apache 2.0 / BSD, redistribution is fine.
Removes:
- scripts/fetch-pdfium.sh
- "Fetch PDFium dynamic library" step in build.yml
- pdfium_platform matrix var
- .gitignore entries for *.dylib/*.dll/*.so under src-tauri/pdfium/
- src-tauri/pdfium/.gitkeep (no longer needed, dir has real content)1 parent a5c12e6 commit c120be9
7 files changed
Lines changed: 0 additions & 114 deletions
File tree
- .github/workflows
- scripts
- src-tauri/pdfium
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
25 | | - | |
26 | 24 | | |
27 | 25 | | |
28 | 26 | | |
29 | | - | |
30 | 27 | | |
31 | 28 | | |
32 | 29 | | |
| |||
61 | 58 | | |
62 | 59 | | |
63 | 60 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | 61 | | |
69 | 62 | | |
70 | 63 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | 14 | | |
21 | 15 | | |
22 | 16 | | |
| |||
This file was deleted.
Whitespace-only changes.
Binary file not shown.
Binary file not shown.
Binary file not shown.
0 commit comments