Skip to content

Commit bbb412f

Browse files
committed
fix: ensure proper delivery of stop signal in scheduler and improve readability of MemoryStore tests
1 parent 7e779d5 commit bbb412f

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

src/scheduler.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,8 @@ where
392392
// Send stop signal — use send().await to ensure delivery for critical control-plane command.
393393
// This is safe because stop signals are rare and waiting for queue space is acceptable.
394394
if let Some(tx) = self.command_tx.read().await.as_ref() {
395-
tx.send(SchedulerCommand::Stop).await
395+
tx.send(SchedulerCommand::Stop)
396+
.await
396397
.map_err(|e| CanoError::Workflow(format!("Failed to send stop: {}", e)))?;
397398
} else {
398399
return Err(CanoError::Workflow(

src/store/memory.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -403,8 +403,13 @@ mod tests {
403403
assert!(result.is_err());
404404

405405
// Verify the original value is still in the store (non-destructive error)
406-
let retrieved: String = store.get(key).expect("Value should still exist after append error");
407-
assert_eq!(retrieved, original_value, "Original value should be preserved after type mismatch");
406+
let retrieved: String = store
407+
.get(key)
408+
.expect("Value should still exist after append error");
409+
assert_eq!(
410+
retrieved, original_value,
411+
"Original value should be preserved after type mismatch"
412+
);
408413
}
409414

410415
#[test]

0 commit comments

Comments
 (0)