Using an AudioStreamRandomizer with play_sound will error on the third attempt.

[dicemaster5]

Describe the bug
When playing a sound with SoundManager.play_sound() using an AudioStreamRandomizer as the audiostream resource the addon will error on the third use of play_sound() at sound_manager/abstract_audio_player_pool.gd on line 62 due to a missing/null player stream.

Commenting out lines 39 and 40 fixes the issue as it plays the AudioStreamRandomizer as a normal AudioStream without going into get_player_with_resource() (I'm a bit confused as to why AudioStreamRandomizer is being handled differently with this method).

The cause of the missing/null player stream is happening on line 79 in mark_player_as_available(), that's where the player gets destroyed with a queue_free().

Affected version

• Addon version: 2.6.1
• Godot version: 4.2.2

To Reproduce
Play a sound with SoundManager.play_sound() using an AudioStreamRandomizer as the AudioStream resource and play the sound 3 or more times, should trigger the error.

Screenshots

[oxeron]

Bug confirmed

[oxeron]

Removing get_player_with_resource() for AudioStreamRandomizer solves the problem, but maybe with another side effect I did not find
Another approach would be not to queue_free a player with AudioStreamRandomizer as resource ?

[Elementus353]

Hi! Did you get it why AudioStreamRandomizer was being handled differently? Because i face the same problem and don't find any other solution but commenting 39 and 40 lines. Did you face any problems after commenting these lines?

[dicemaster5]

Hi! Did you get it why AudioStreamRandomizer was being handled differently? Because i face the same problem and don't find any other solution but commenting 39 and 40 lines. Did you face any problems after commenting these lines?

Hey! No unfortunatley I never figured it out.
But commenting out those lines never caused any issues for me so I kept to that solution.

[Elementus353]

Hi! Did you get it why AudioStreamRandomizer was being handled differently? Because i face the same problem and don't find any other solution but commenting 39 and 40 lines. Did you face any problems after commenting these lines?

Hey! No unfortunatley I never figured it out. But commenting out those lines never caused any issues for me so I kept to that solution.

Haha, that's nice

Thank you for your reply!

[Tralexium]

Hi there, just wanted to chime in for those who're using AudioStreamRandomizer for music. What Elementus353 suggested is a band-aid fix that doesn't address the core problem. After doing some digging myself, I've noticed that get_player_with_resource() doesn't ever mark that player as busy, thus leading to fading issues and other nasty things.

Keep lines 39 & 40 and fix the function like this:

func get_player_with_resource(resource: AudioStream) -> AudioStreamPlayer:
	for player in busy_players + available_players:
		if player.stream == resource:
			if not busy_players.has(player):
				busy_players.append(player)
			return player
	return null