Allow crds to be disabled

[bhc64]

What motivated this proposal?

Currently in a project I'm working on we override the nack CRDs for reasons I can't go into but this results in a warning. It would be nice to be able to disable the inherent nack CRDs to avoid this

What is the proposed change?

Add an if statement to 'nack/deploy/crds.yml' to enable or disable these crds

Who benefits from this change?

Anyone who wants greater control over the back crds

What alternatives have you evaluated?

Having argocd ignore the warning. Not currently possible

[kejne]

This would be an update in https://github.com/nats-io/k8s/ for the nack chart.

Something similar to this commit.

NACK is currently relying on Helm lifecycle, so would be possible to use the --skip-crds flag to disable the CRD:s.
Would however be better to include it in the chart itself and being able to control it via values.

[Jarema]

I feel that disabling CRDs in NACK beats the whole purpose of NACK.

The warning feels also justified in that case.

If user is not using crd's as a single source of truth, and is overriding them, isn't it better to just create the resources in the client apps?

[kejne]

The use case would be for example if you deploy multiple NACK instances (since you want to limit each instance to a specific namespace).

If you want to do this in a declarative way and deploy multiple charts in the same cluster, you will get stuck with warnings and argocd or flux complaining about the resources being duplicated.

Here are some examples from mature projects that also use crds the same way nack would:

• https://github.com/akuity/kargo/tree/main/charts/kargo
• https://github.com/external-secrets/external-secrets/tree/main/deploy/charts/external-secrets