Skip to content

Commit bfbecb8

Browse files
ReubenMathewripienaar
authored andcommitted
Fix whitespace check to look for newlines as well
Signed-off-by: reubenninan <[email protected]>
1 parent ee4d074 commit bfbecb8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

internal/audit/cluster_checks.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ func makeCheckClusterHighHAAssets(haAssetsThreshold int) checkFunc {
221221
func checkClusterNamesForWhitespace(reader *archive.Reader, examples *ExamplesCollection) (Outcome, error) {
222222

223223
for _, clusterName := range reader.GetClusterNames() {
224-
if strings.Contains(clusterName, " ") {
224+
if strings.ContainsAny(clusterName, " \n") {
225225
examples.add("Cluster: %s", clusterName)
226226
}
227227
}
@@ -253,7 +253,7 @@ func checkLeafnodeServerNamesForWhitespace(r *archive.Reader, examples *Examples
253253

254254
for _, leaf := range serverLeafz.Leafs {
255255
// check if leafnode name contains whitespace
256-
if strings.Contains(leaf.Name, " ") {
256+
if strings.ContainsAny(leaf.Name, " \n") {
257257
leafnodesWithWhitespace[leaf.Name] = struct{}{}
258258
}
259259
}

internal/audit/server_checks.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ func checkJetStreamDomainsForWhitespace(r *archive.Reader, examples *ExamplesCol
249249
}
250250

251251
// check if jetstream domain contains whitespace
252-
if strings.Contains(serverJsz.Config.Domain, " ") {
252+
if strings.ContainsAny(serverJsz.Config.Domain, " \n") {
253253
examples.add("Cluster %s Server %s Domain %s", clusterName, serverName, serverJsz.Config.Domain)
254254
}
255255
}

0 commit comments

Comments
 (0)