Merge pull request #9 from nats-io/pre-extract-review

Pre-Extract Additional Tests and Readme fix.

Author: scottf

src/main/java/io/nats/client/NKeyUtils.java

@@ -22,6 +22,8 @@
 import java.util.Random;
 
 public abstract class NKeyUtils {
+    private NKeyUtils() {} /* ensures cannot be constructed */
+
     // PrefixByteSeed is the prefix byte used for encoded NATS Seeds
     public static final int PREFIX_BYTE_SEED = 18 << 3; // Base32-encodes to 'S...'
 

src/test/java/io/nats/client/NKeyTests.java

@@ -69,11 +69,12 @@ public void testBase32() {
         List<String> inputs = ResourceUtils.resourceAsLines("utf8-test-strings.txt");
 
         for (String expected : inputs) {
-            byte[] bytes = expected.getBytes(StandardCharsets.UTF_8);
-            char[] encoded = NKeyUtils.base32Encode(bytes);
+            byte[] expectedBytes = expected.getBytes(StandardCharsets.UTF_8);
+            char[] encoded = NKeyUtils.base32Encode(expectedBytes);
             byte[] decoded = NKeyUtils.base32Decode(encoded);
+            assertArrayEquals(expectedBytes, decoded);
             String test = new String(decoded, StandardCharsets.UTF_8);
-            assertEquals(test, expected);
+            assertEquals(expected, test);
         }
 
         // bad input for coverage