Terraform Consumer Resource config `max_waiting` cannot be set when `delivery_subject` is empty

[ianbbqzy]

What version were you using?

nats-server: v2.10.12

What environment was the server running in?

ubuntu
terraform

Is this defect reproducible?

Cannot set max_waiting for consumer resource with an empty delivery_subject. Based on my understandings and the README, the former is a pull pased consumer config while the latter is a push-based consumer config. Should it be the opposite where max_waiting can be set only when delivery_subject is empty?

terraform-provider-jetstream/jetstream/resource_jetstream_consumer.go

Line 291 in e3cb395

cfg.MaxWaiting = d.Get("max_waiting").(int)

Given the capability you are leveraging, describe your expectation?

max_waiting can be set even when delivery_subject is empty

Given the expectation, what is the defect you are observing?

max_waiting cannot be set when delivery_subject is empty

[ripienaar]

indeed seems like a bug I agree, want to send a small PR to fix?