Editor Theme is saving independently for both Brew and Style editors

[Gazook89]

Renderer

v3

Browser

Chrome

Operating System

MacOS

What happened?

Since the editor update, setting an editor theme is setting the localStorage property independently for each the Brew and Style editors but on the same key. So if I set my Brew editor to "neat", and the Style editor to "twilight", i can have different themes for each. But when i reload the page, is pulling "twilight" for both editors.

I believe that we should not allow different themes per editor (and I don't believe we have intended to allow this). But if for some reason we do want to allow it, we need to save the themes separately in localStorage.

Code

[calculuschild]

I agree I think there should be just one theme shared across the editors.

[5e-Cleric]

Yes, this is a bug because the theme is not being rebuilt on tab change, just on theme change. I believe the editor is being memoized and rerendered with its last theme instance. This is easily fixable:

In codeEditor.jsx Line 311

Swap:

}, [editorTheme]);
for
}, [editorTheme, tab]);

That fixes the issue.