Move DataClient and ExecutionClient traits to common crate

- Add clients module to nautilus-common as single source of truth
- Consolidate log_command_error helper in clients module
- Update all adapters to import traits from nautilus_common::clients
- Add missing request_book_snapshot method to DataClientAdapter
- Remove trait re-exports from data/execution crates

This architecture establishes `nautilus-common` as the canonical
location for core client traits, eliminating the previous pattern of
re-exporting through `nautilus-live`. Placing shared abstractions in
common provides cleaner import paths for adapter authors, prevents
circular dependency issues, and properly separates trait definitions
from their implementations in specialized crates.

Author: cjdsellers

crates/adapters/architect_ax/src/data/mod.rs

@@ -25,6 +25,7 @@ use async_trait::async_trait;
 use dashmap::DashMap;
 use futures_util::StreamExt;
 use nautilus_common::{
+    clients::DataClient,
     live::{runner::get_data_event_sender, runtime::get_runtime},
     messages::{
         DataEvent, DataResponse,
@@ -40,7 +41,6 @@ use nautilus_core::{
     datetime::datetime_to_unix_nanos,
     time::{AtomicTime, get_atomic_clock_realtime},
 };
-use nautilus_live::DataClient;
 use nautilus_model::{
     data::{BarType, Data, OrderBookDeltas_API},
     identifiers::{ClientId, InstrumentId, Venue},

crates/adapters/binance/src/data/mod.rs

@@ -24,6 +24,7 @@ use ahash::AHashMap;
 use anyhow::Context;
 use futures_util::{StreamExt, pin_mut};
 use nautilus_common::{
+    clients::DataClient,
     live::{runner::get_data_event_sender, runtime::get_runtime},
     messages::{
         DataEvent,
@@ -41,7 +42,6 @@ use nautilus_core::{
     datetime::datetime_to_unix_nanos,
     time::{AtomicTime, get_atomic_clock_realtime},
 };
-use nautilus_live::DataClient;
 use nautilus_model::{
     data::{Data, OrderBookDeltas_API},
     enums::BookType,

crates/adapters/binance/src/factories.rs

@@ -17,8 +17,7 @@
 
 use std::{cell::RefCell, rc::Rc};
 
-use nautilus_common::{cache::Cache, clock::Clock};
-use nautilus_live::DataClient;
+use nautilus_common::{cache::Cache, clients::DataClient, clock::Clock};
 use nautilus_model::identifiers::ClientId;
 use nautilus_system::factories::{ClientConfig, DataClientFactory};
 

crates/adapters/bitmex/src/data/mod.rs

@@ -27,6 +27,7 @@ use ahash::AHashMap;
 use anyhow::Context;
 use futures_util::StreamExt;
 use nautilus_common::{
+    clients::DataClient,
     live::{runner::get_data_event_sender, runtime::get_runtime},
     messages::{
         DataEvent,
@@ -44,7 +45,6 @@ use nautilus_core::{
     datetime::datetime_to_unix_nanos,
     time::{AtomicTime, get_atomic_clock_realtime},
 };
-use nautilus_live::DataClient;
 use nautilus_model::{
     data::Data,
     enums::BookType,

crates/adapters/bitmex/src/execution/mod.rs

@@ -24,6 +24,7 @@ use anyhow::Context;
 use async_trait::async_trait;
 use futures_util::{StreamExt, pin_mut};
 use nautilus_common::{
+    clients::ExecutionClient,
     live::{runner::get_exec_event_sender, runtime::get_runtime},
     messages::{
         ExecutionEvent, ExecutionReport,
@@ -36,7 +37,7 @@ use nautilus_common::{
     msgbus,
 };
 use nautilus_core::{UUID4, UnixNanos, time::get_atomic_clock_realtime};
-use nautilus_live::{ExecutionClient, ExecutionClientCore};
+use nautilus_live::ExecutionClientCore;
 use nautilus_model::{
     accounts::AccountAny,
     enums::OmsType,

crates/adapters/blockchain/bin/node_wallet.rs

@@ -21,11 +21,12 @@ use nautilus_blockchain::{
 };
 use nautilus_common::{
     cache::Cache,
+    clients::ExecutionClient,
     live::{clock::LiveClock, runtime::get_runtime},
     logging::{init_logging, logger::LoggerConfig, writer::FileWriterConfig},
 };
 use nautilus_core::UUID4;
-use nautilus_live::{ExecutionClient, ExecutionClientCore};
+use nautilus_live::ExecutionClientCore;
 use nautilus_model::{
     defi::chain::chains,
     enums::{AccountType, OmsType},

crates/adapters/blockchain/src/data/client.rs

@@ -14,6 +14,7 @@
 // -------------------------------------------------------------------------------------------------
 
 use nautilus_common::{
+    clients::DataClient,
     defi::RequestPoolSnapshot,
     live::get_runtime,
     messages::{
@@ -27,7 +28,6 @@ use nautilus_common::{
         },
     },
 };
-use nautilus_live::DataClient;
 use nautilus_model::{
     defi::{DefiData, PoolIdentifier, SharedChain, validation::validate_address},
     identifiers::{ClientId, Venue},

crates/adapters/blockchain/src/execution/client.rs

@@ -17,13 +17,16 @@ use std::{collections::HashSet, sync::Arc};
 
 use alloy::primitives::Address;
 use async_trait::async_trait;
-use nautilus_common::messages::execution::{
-    BatchCancelOrders, CancelAllOrders, CancelOrder, GenerateFillReports,
-    GenerateOrderStatusReport, GenerateOrderStatusReports, GeneratePositionStatusReports,
-    ModifyOrder, QueryAccount, QueryOrder, SubmitOrder, SubmitOrderList,
+use nautilus_common::{
+    clients::ExecutionClient,
+    messages::execution::{
+        BatchCancelOrders, CancelAllOrders, CancelOrder, GenerateFillReports,
+        GenerateOrderStatusReport, GenerateOrderStatusReports, GeneratePositionStatusReports,
+        ModifyOrder, QueryAccount, QueryOrder, SubmitOrder, SubmitOrderList,
+    },
 };
 use nautilus_core::UnixNanos;
-use nautilus_live::{ExecutionClient, ExecutionClientCore};
+use nautilus_live::ExecutionClientCore;
 use nautilus_model::{
     accounts::AccountAny,
     defi::{

crates/adapters/blockchain/src/factories.rs

@@ -17,8 +17,12 @@
 
 use std::{any::Any, cell::RefCell, rc::Rc};
 
-use nautilus_common::{cache::Cache, clock::Clock};
-use nautilus_live::{DataClient, ExecutionClient, ExecutionClientCore};
+use nautilus_common::{
+    cache::Cache,
+    clients::{DataClient, ExecutionClient},
+    clock::Clock,
+};
+use nautilus_live::ExecutionClientCore;
 use nautilus_model::{
     enums::{AccountType, OmsType},
     identifiers::ClientId,

crates/adapters/databento/src/data.rs

@@ -31,6 +31,7 @@ use ahash::AHashMap;
 use databento::live::Subscription;
 use indexmap::IndexMap;
 use nautilus_common::{
+    clients::DataClient,
     live::{runner::get_data_event_sender, runtime::get_runtime},
     messages::{
         DataEvent,
@@ -42,7 +43,6 @@ use nautilus_common::{
     },
 };
 use nautilus_core::{MUTEX_POISONED, time::AtomicTime};
-use nautilus_live::DataClient;
 use nautilus_model::{
     enums::BarAggregation,
     identifiers::{ClientId, Symbol, Venue},