From 58f0c713432f808b364dda32f7d9e54416c76458 Mon Sep 17 00:00:00 2001 From: Brian Hodges Date: Mon, 8 Jun 2026 19:05:28 -0700 Subject: [PATCH] fix(metricsai): rename security_compliance_thumbs_down column to plural Align the compliance thumbs-down metric key with its security counterpart (security_thumbs_downs) and the updated Google Sheet header. Updates the emitted metric, the expected-columns test, and the README column list. Co-Authored-By: Claude Opus 4.8 (1M context) --- metricsai/README.md | 2 +- metricsai/src/metricsai/modules/security.py | 2 +- metricsai/tests/test_security.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/metricsai/README.md b/metricsai/README.md index fed7595..53a1e60 100644 --- a/metricsai/README.md +++ b/metricsai/README.md @@ -28,7 +28,7 @@ they come from one scan of the AI reviewer's [Conventional Comments](https://conventionalcomments.org/), split by label (`security` vs `compliance`), plus one AWS Security Hub findings count. The `security_compliance_*` columns are: `security_compliance_total_comments`, `security_compliance_thumbs_ups`, -`security_compliance_thumbs_down`, `security_compliance_critical`, +`security_compliance_thumbs_downs`, `security_compliance_critical`, `security_compliance_high`, `security_compliance_medium`, `security_compliance_low`. ## Prerequisites diff --git a/metricsai/src/metricsai/modules/security.py b/metricsai/src/metricsai/modules/security.py index 928ec8b..d30c31f 100644 --- a/metricsai/src/metricsai/modules/security.py +++ b/metricsai/src/metricsai/modules/security.py @@ -102,7 +102,7 @@ def _aggregate_comments(comments: list[Comment]) -> dict[str, MetricValue]: "security_low": sec["low"], "security_compliance_total_comments": comp["total"], "security_compliance_thumbs_ups": comp["up"], - "security_compliance_thumbs_down": comp["down"], + "security_compliance_thumbs_downs": comp["down"], "security_compliance_critical": comp["critical"], "security_compliance_high": comp["high"], "security_compliance_medium": comp["medium"], diff --git a/metricsai/tests/test_security.py b/metricsai/tests/test_security.py index 35cad90..3899194 100644 --- a/metricsai/tests/test_security.py +++ b/metricsai/tests/test_security.py @@ -22,7 +22,7 @@ "security_low", "security_compliance_total_comments", "security_compliance_thumbs_ups", - "security_compliance_thumbs_down", + "security_compliance_thumbs_downs", "security_compliance_critical", "security_compliance_high", "security_compliance_medium",