feat(w21-24kl): batch 13 — RED tests for tk-to-ticket infrastructure migration

JoeOakhartNava · claude · JoeOakhartNava · commit 0bd13575cbd7 · 2026-03-23T08:48:12.000-07:00
Write failing tests that assert post-migration state for infrastructure
path references and hook behavioral guards (ticket transition, ticket
create with parent). Tests are RED by design — they will turn GREEN when
implementation tasks dso-1cje and dso-yv90 update the actual code.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/.test-index b/.test-index
@@ -19,7 +19,10 @@ plugins/dso/docs/workflows/TEST-FAILURE-DISPATCH.md:plugins/dso/skills/sprint/pr
 plugins/dso/hooks/dispatchers/pre-bash.sh:tests/hooks/test-pre-bash-dispatcher.sh
 plugins/dso/hooks/dispatchers/pre-edit.sh:tests/hooks/test-pre-edit-write-dispatcher.sh
 plugins/dso/hooks/dispatchers/pre-write.sh:tests/hooks/test-pre-edit-write-dispatcher.sh
-plugins/dso/hooks/lib/review-gate-allowlist.conf:tests/hooks/test-review-gate-allowlist.sh
+plugins/dso/hooks/closed-parent-guard.sh:tests/hooks/test-pre-bash-functions-ticket-guards.sh [test_bug_close_guard_fires_on_ticket_transition_closed]
+plugins/dso/hooks/compute-diff-hash.sh:tests/hooks/test-compute-diff-hash-tickets-tracker.sh [test_allowlist_uses_tickets_tracker_path]
+plugins/dso/hooks/lib/pre-bash-functions.sh:tests/hooks/test-pre-bash-functions-ticket-guards.sh [test_bug_close_guard_fires_on_ticket_transition_closed]
+plugins/dso/hooks/lib/review-gate-allowlist.conf:tests/hooks/test-review-gate-allowlist.sh,tests/hooks/test-compute-diff-hash-tickets-tracker.sh [test_allowlist_uses_tickets_tracker_path]
 plugins/dso/scripts/check-local-env.sh:tests/scripts/test-check-local-env-portability.sh,tests/scripts/test-check-local-env-docker-skip.sh,tests/scripts/test-check-local-env-generic.sh
 plugins/dso/scripts/check-script-writes.py:tests/scripts/test-check-script-writes.sh
 plugins/dso/scripts/ci-generator.sh:tests/scripts/test-ci-generator.sh,tests/scripts/test-ci-generator-integration.sh
diff --git a/.tickets/.sync-state.json b/.tickets/.sync-state.json
@@ -449,8 +449,8 @@
     "last_synced": "2026-03-19T18:38:35Z",
     "local_hash": "14c516947a151a3db8bdec4010e2fd6e"
   },
-  "last_pull_timestamp": "2026-03-23T06:54:56Z",
-  "last_sync_commit": "7ddaa56794facea6c3314b3fa67f74721b7419ac",
+  "last_pull_timestamp": "2026-03-23T15:44:58Z",
+  "last_sync_commit": "ef8bf742e37513ef757843afacc84b13fadb5388",
   "w21-5cqr": {
     "jira_hash": "bce29d76f01c58613ee99cb1dd03920d",
     "jira_key": "DIG-61",
diff --git a/.tickets/dso-1cje.md b/.tickets/dso-1cje.md
@@ -0,0 +1,48 @@
+---
+id: dso-1cje
+status: open
+deps: [dso-5fbs]
+links: []
+created: 2026-03-23T15:19:45Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: w21-wbqz
+---
+# Update infrastructure path references (.tickets/ → .tickets-tracker/)
+
+Update all storage path references from the old .tickets/ layout to the v3 .tickets-tracker/ layout in infrastructure files.
+
+## Depends on
+dso-5fbs (RED test must exist before this task)
+
+## Files to Edit
+
+### plugins/dso/hooks/lib/review-gate-allowlist.conf
+- Change: .tickets/** → .tickets-tracker/**
+  (This is the single source of truth for non-reviewable file patterns consumed by compute-diff-hash.sh and skip-review-check.sh)
+
+### plugins/dso/hooks/compute-diff-hash.sh
+- Line 7 comment: '.tickets/ files' → '.tickets-tracker/ files'
+- Line 24 comment: "pathspecs like ':!app/.tickets/'" → "pathspecs like ':!app/.tickets-tracker/'"
+- Line 114 fallback array: ':!.tickets/**' → ':!.tickets-tracker/**'
+
+### plugins/dso/scripts/merge-ticket-index.py
+- Module docstring line 3: 'merge-ticket-index.py — Custom Git merge driver for .tickets/.index.json' → '.tickets-tracker/.index.json'
+- Line 5: '.tickets/.index.json when two branches' → '.tickets-tracker/.index.json when two branches'
+- Line 23 MERGE_AUTO_RESOLVE: 'path=.tickets/.index.json' → 'path=.tickets-tracker/.index.json'
+- Line 35 .gitattributes example: '.tickets/.index.json merge=tickets-index-merge' → '.tickets-tracker/.index.json merge=tickets-index-merge'
+- Line 134 argparse help: 'Custom Git merge driver for .tickets/.index.json' → '.tickets-tracker/.index.json'
+- Line 170 log output: 'MERGE_AUTO_RESOLVE: path=.tickets/.index.json' → 'path=.tickets-tracker/.index.json'
+
+### .gitattributes (CREATE new file at repo root)
+Content:
+  # Ticket index auto-merge driver
+  # Register per-clone: git config merge.tickets-index-merge.driver 'python3 plugins/dso/scripts/merge-ticket-index.py %O %A %B'
+  .tickets-tracker/.index.json merge=tickets-index-merge
+
+## Syntax Validation
+After editing, verify:
+  bash -n plugins/dso/hooks/compute-diff-hash.sh
+  python3 -m py_compile plugins/dso/scripts/merge-ticket-index.py
+
diff --git a/.tickets/dso-5fbs.md b/.tickets/dso-5fbs.md
@@ -0,0 +1,80 @@
+---
+id: dso-5fbs
+status: in_progress
+deps: []
+links: []
+created: 2026-03-23T15:19:28Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: w21-wbqz
+---
+# RED Test: write failing tests for tk→ticket infrastructure and hook guard updates
+
+TDD RED task for story w21-wbqz. Write failing tests that assert the post-migration state BEFORE the implementation tasks run.
+
+## TDD Requirement
+Tests must FAIL (RED) before T2/T3 changes are applied. They will become GREEN after T2 and T3 complete.
+
+## Files to Create
+1. tests/hooks/test-compute-diff-hash-tickets-tracker.sh
+   - test_allowlist_uses_tickets_tracker_path: assert review-gate-allowlist.conf contains .tickets-tracker/** (not .tickets/**)
+   - test_compute_diff_hash_fallback_uses_tickets_tracker_path: assert compute-diff-hash.sh fallback pathspec contains :!.tickets-tracker/** (not :!.tickets/**)
+
+2. tests/hooks/test-pre-bash-functions-ticket-guards.sh
+   - test_bug_close_guard_fires_on_ticket_transition_closed: source pre-bash-functions.sh, call hook_bug_close_guard with JSON input {"tool_name":"Bash","tool_input":{"command":"ticket transition abc1-def2 open closed --reason=fixed"}} — assert exit code 2 (blocked) or non-zero output indicating the guard fires
+   - test_bug_close_guard_no_false_positive_on_ticket_show: hook_bug_close_guard with command 'ticket show abc1-def2' — assert exit 0 (not blocked)
+   - test_closed_parent_guard_fires_on_ticket_create_parent: invoke closed-parent-guard.sh directly via echo JSON | bash closed-parent-guard.sh — with command 'ticket create "title" --parent abc1-def2' where parent is closed — assert exit 2
+   - test_closed_parent_guard_does_not_fire_on_tk_sync: command 'tk sync' — assert exit 0 (tk sync is still valid)
+
+## Fuzzy-Match Verification
+- compute-diff-hash.sh normalized: computediffhashsh → test-compute-diff-hash-tickets-tracker.sh normalized: testcomputediffhashticketstracksh — 'computediffhash' is substring ✓
+- pre-bash-functions.sh normalized: prebashfunctionssh → test-pre-bash-functions-ticket-guards.sh normalized: testprebashfunctionsticketguardssh — 'prebashfunctions' is substring ✓
+
+## Test Structure Pattern
+Follow the existing pattern in tests/hooks/test-check-validation-failures.sh:
+  run_hook() { echo "$1" | bash "$HOOK" > /dev/null 2>/dev/null || exit_code=$?; echo $exit_code; }
+For hook_bug_close_guard tests, source pre-bash-functions.sh and call the function directly.
+For closed-parent-guard.sh tests, invoke as standalone script with JSON piped to stdin.
+
+## ACCEPTANCE CRITERIA
+
+- [ ] `tests/hooks/test-compute-diff-hash-tickets-tracker.sh` exists
+  Verify: test -f tests/hooks/test-compute-diff-hash-tickets-tracker.sh
+- [ ] `tests/hooks/test-pre-bash-functions-ticket-guards.sh` exists
+  Verify: test -f tests/hooks/test-pre-bash-functions-ticket-guards.sh
+- [ ] Test file 1 contains at least 2 test functions
+  Verify: grep -c "^test_" tests/hooks/test-compute-diff-hash-tickets-tracker.sh | awk '{exit ($1 < 2)}'
+- [ ] Test file 2 contains at least 4 test functions
+  Verify: grep -c "^test_" tests/hooks/test-pre-bash-functions-ticket-guards.sh | awk '{exit ($1 < 4)}'
+- [ ] Tests are RED (fail before T2/T3 implementation)
+  Verify: bash tests/hooks/test-compute-diff-hash-tickets-tracker.sh 2>&1 | grep -q "FAIL\|fail"
+- [ ] .test-index entries added for both test files with RED markers
+  Verify: grep -q "test-compute-diff-hash-tickets-tracker" .test-index && grep -q "test-pre-bash-functions-ticket-guards" .test-index
+
+
+## Notes
+
+**2026-03-23T15:26:29Z**
+
+CHECKPOINT 1/6: Task context loaded ✓
+
+**2026-03-23T15:27:14Z**
+
+CHECKPOINT 2/6: Code patterns understood ✓
+
+**2026-03-23T15:29:17Z**
+
+CHECKPOINT 3/6: Tests written ✓
+
+**2026-03-23T15:31:15Z**
+
+CHECKPOINT 4/6: Implementation complete ✓
+
+**2026-03-23T15:35:48Z**
+
+CHECKPOINT 5/6: Validation passed ✓ — both test files are syntactically valid bash, run cleanly, GREEN tests pass, RED tests fail as expected; all 6 AC criteria verified
+
+**2026-03-23T15:35:52Z**
+
+CHECKPOINT 6/6: Done ✓ — all 6 AC criteria pass: files exist, have correct test count, are RED, .test-index entries added with RED markers
diff --git a/.tickets/dso-hu14.md b/.tickets/dso-hu14.md
@@ -0,0 +1,93 @@
+---
+id: dso-hu14
+status: open
+deps: [dso-1cje, dso-yv90]
+links: []
+created: 2026-03-23T15:20:45Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: w21-wbqz
+---
+# Update documentation and CLAUDE.md prose with ticket CLI references
+
+Update all skill files, documentation files, and CLAUDE.md to use ticket CLI commands instead of tk commands where ticket equivalents exist. The tk wrapper remains for Jira sync and tk-only commands.
+
+## test-exempt justification
+test-exempt: (1) no conditional logic — pure prose/text replacement; (2) any test written would be a change-detector test asserting strings exist in files, not behavioral tests; (3) documentation-boundary-only with no business logic.
+
+## Depends on
+dso-1cje (infrastructure updates must be complete)
+dso-yv90 (hook behavioral guards must be finalized)
+
+## Enumerated Replacement Patterns
+Apply these specific patterns (NOT blanket s/tk/ticket/g):
+
+REPLACE:
+  tk show <id>          → ticket show <id>
+  tk create             → ticket create
+  tk list               → ticket list
+  tk dep tree <id>      → ticket deps <id>
+  tk status <id> <s>    → ticket transition <id> <current> <s>
+  tk close <id>         → ticket transition <id> open closed
+  tk open <id>          → ticket transition <id> closed open
+  tk add-note <id>      → ticket comment <id>
+  tk comment <id>       → ticket comment <id>
+  tk transition <id>    → ticket transition <id>
+
+KEEP AS-IS (tk wrapper only):
+  tk sync               → tk sync (Jira bridge; no ticket equivalent)
+  tk ready              → tk ready (tk-wrapper query; no ticket equivalent)
+  tk blocked            → tk blocked (tk-wrapper query; no ticket equivalent)
+  tk dep <child> <p>    → (handled in T3 as closed-parent-guard context; in docs: ticket link)
+
+## Files to Update
+
+### CLAUDE.md (8 tk references)
+- Line 52 quick reference table: 'tk sync' — KEEP (Jira bridge)
+- Line 60 prose: 'the higher-level tk wrapper adds Jira sync' — KEEP (accurate description)
+- Line 61 prose: 'Epic closure enforcement: tk close <epic-id>' → 'ticket transition <epic-id> open closed'
+- Lines 127/128 Always Do These: 'tk sync', 'tk write commands' — KEEP (timeout guidance for tk sync)
+- Line 142 Plan Mode: 'Create tk epic' → 'Create ticket epic' (or just 'Create epic' — the command is 'tk create ... -t epic' currently; update to 'ticket create ...')
+- Line 160 Session close: 'not the tk Session Close Protocol' — KEEP if this refers to a known legacy doc
+
+### plugins/dso/skills/ (45 files)
+Apply enumerated replacement patterns above. Key files:
+- plugins/dso/skills/sprint/SKILL.md: many tk show/create/status/close/ready/dep-tree refs
+- plugins/dso/skills/fix-bug/SKILL.md
+- plugins/dso/skills/implementation-plan/SKILL.md (already reviewed — apply patterns)
+- plugins/dso/skills/preplanning/SKILL.md
+- All other SKILL.md and prompt files with tk refs
+
+### plugins/dso/docs/ (23 files)
+Apply enumerated replacement patterns. Key files:
+- plugins/dso/docs/workflows/COMMIT-WORKFLOW.md: 'tk add-note' → 'ticket comment'
+- plugins/dso/docs/workflows/REVIEW-WORKFLOW.md: same
+- plugins/dso/docs/ticket-cli-reference.md: update any tk show/create examples that should use ticket CLI
+- plugins/dso/docs/WORKTREE-GUIDE.md
+- plugins/dso/docs/INSTALL.md
+- plugins/dso/docs/SUB-AGENT-BOUNDARIES.md
+
+## Post-Update Verification (required ACs — verification gate)
+After all documentation updates complete:
+
+1. Enumerate-patterns grep (must return NO matches):
+   grep -rn '\btk show\b\|\btk create\b\|\btk close\b\|\btk add-note\b\|\btk status\b\|\btk transition\b\|\btk dep tree\b' plugins/dso/skills/ plugins/dso/docs/ CLAUDE.md
+
+2. Remaining tk refs grep (all surviving hits must be tk-wrapper-only commands):
+   grep -rn '\btk\b' plugins/dso/skills/ plugins/dso/docs/ CLAUDE.md plugins/dso/hooks/
+   Verify all hits are: tk sync, tk ready, tk blocked, tk dep (as legacy reference), or prose descriptions of the tk wrapper
+
+3. Syntax validation on all modified .sh files:
+   bash -n plugins/dso/hooks/lib/pre-bash-functions.sh
+   bash -n plugins/dso/hooks/closed-parent-guard.sh
+   bash -n plugins/dso/hooks/bug-close-guard.sh
+   bash -n plugins/dso/hooks/compute-diff-hash.sh
+   bash -n plugins/dso/scripts/merge-to-main.sh
+
+4. Python syntax validation:
+   python3 -m py_compile plugins/dso/scripts/merge-ticket-index.py
+
+5. Test suite:
+   bash tests/run-all.sh
+
diff --git a/.tickets/dso-yv90.md b/.tickets/dso-yv90.md
@@ -0,0 +1,66 @@
+---
+id: dso-yv90
+status: open
+deps: [dso-5fbs]
+links: []
+created: 2026-03-23T15:20:14Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: w21-wbqz
+---
+# Update hook behavioral guards (tk → ticket command detection)
+
+Update all hook files that contain behavioral guards detecting tk commands to detect ticket commands instead. The tk wrapper remains valid for Jira sync (tk sync).
+
+## Depends on
+dso-5fbs (RED test must exist before this task)
+
+## Files to Edit
+
+### plugins/dso/hooks/lib/pre-bash-functions.sh
+- Line 152: ${CREATE_CMD:-tk create} → ${CREATE_CMD:-ticket create}
+- Line 277 error message: 'tk create "Fix <check> failure"' → 'ticket create "Fix <check> failure"'
+- Line 385 error message: 'tk commands work from any directory' → 'ticket commands work from any directory'
+- Lines 507-508 early-exit guard: if [[ "$INPUT" != *"tk"* ]] → if [[ "$INPUT" != *"ticket "* ]]
+  (More specific than old guard; avoids false positives on unrelated commands containing 'ticket' as English word since we check for 'ticket ' with trailing space)
+- Lines 518-519 bug close only path: update comment 'Only act on `tk close` commands' → 'Only act on `ticket transition ... closed` commands'
+- Lines 518-519 regex: tk[[:space:]]+close[[:space:]]+ → ticket[[:space:]]+transition[[:space:]]+
+- Line 865 allowlist: keep "$FIRST_TOKEN" == "tk" (tk sync still valid); comment: 'ticket CLI patterns (ticket *, tk *)' — keep both
+- Line 821 comment: 'go through ticket CLI commands (ticket *, tk *)' — keep (tk still valid for Jira sync)
+- Line 830 comment: 'Allowlist: ticket CLI scripts (ticket, tk)' — keep
+
+### plugins/dso/hooks/closed-parent-guard.sh
+- Line 6-7 comments: update 'tk create ... --parent <id>' → 'ticket create ... --parent <id>'
+- Line 33-34 usage examples: 'tk create' → 'ticket create', 'tk dep <child-id> <parent-id>' → 'ticket link <child-id> <parent-id> depends_on'
+- Line 37 regex: tk[[:space:]]+create[[:space:]].*--parent → ticket[[:space:]]+create[[:space:]].*--parent
+- Line 39 regex: tk[[:space:]]+dep[[:space:]]+ → ticket[[:space:]]+link[[:space:]]+
+  Note: ticket CLI uses 'ticket link <id1> <id2> <relation>' not 'ticket dep'
+- Line 40 comment: 'For `tk dep <child-id> <parent-id>`' → 'For `ticket link <child-id> <parent-id>`'
+- Line 71 error message: 'tk status ${PARENT_ID} open' → 'ticket transition ${PARENT_ID} closed open'
+
+### plugins/dso/hooks/bug-close-guard.sh
+- Comment line 9: 'Only fires on `tk close` commands' → 'Only fires on `ticket transition ... closed` commands'
+- Update any tk close detection in the script body
+
+### plugins/dso/hooks/lib/deps.sh
+- Line 618 comment: '.tickets/ — ticket files managed by the tk CLI' → '.tickets-tracker/ — ticket files managed by the ticket CLI'
+
+### plugins/dso/hooks/check-validation-failures.sh
+- Line 75 comment: 'TICKETS_DIR env var overrides ticket storage location (consistent with tk CLI)' → '(consistent with ticket CLI)'
+- Line 179 comment: 'Format: "Tracked: mypy (tk-789)"' — update tk-789 example ID if it refers to old tk system
+
+### plugins/dso/scripts/merge-to-main.sh
+- Line 8 comment: 'tk (the issue tracker) uses file-per-issue storage under .tickets/' → update to reflect v3 system
+- Line 898 comment: 'Exclude the configured tickets directory — ticket files are created by tk' → 'created by ticket CLI'
+- Line 912 comment: 'tk commands (close, create, add-note) write .tickets/ files' → 'ticket commands write .tickets-tracker/ files'
+
+## Syntax Validation
+After editing all files:
+  bash -n plugins/dso/hooks/lib/pre-bash-functions.sh
+  bash -n plugins/dso/hooks/closed-parent-guard.sh
+  bash -n plugins/dso/hooks/bug-close-guard.sh
+  bash -n plugins/dso/hooks/lib/deps.sh
+  bash -n plugins/dso/hooks/check-validation-failures.sh
+  bash -n plugins/dso/scripts/merge-to-main.sh
+
diff --git a/.tickets/w21-wbqz.md b/.tickets/w21-wbqz.md
@@ -46,3 +46,7 @@ parent: w21-24kl
 [Adversarial review] Additional done definitions:
 - Enumerated patterns must include .tickets/ path references in review-gate-allowlist.conf and compute-diff-hash.sh (not just tk command references) — update to v3 storage paths or the review gate will block/miss v3 ticket writes
 - .gitattributes merge driver entry and merge-ticket-index.py must be updated or removed — stale merge infrastructure causes worktree workflow failures
+
+**2026-03-23T15:07:51Z**
+
+COMPLEXITY_CLASSIFICATION: COMPLEX
diff --git a/tests/hooks/test-compute-diff-hash-tickets-tracker.sh b/tests/hooks/test-compute-diff-hash-tickets-tracker.sh
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+# tests/hooks/test-compute-diff-hash-tickets-tracker.sh
+# TDD RED tests for .tickets-tracker/ path migration.
+#
+# These tests assert the POST-MIGRATION state:
+#   - review-gate-allowlist.conf should contain .tickets-tracker/** (not .tickets/**)
+#   - compute-diff-hash.sh fallback pathspecs should use :!.tickets-tracker/** (not :!.tickets/**)
+#
+# These tests are expected to FAIL (RED) against the current pre-migration code.
+# They will become GREEN after dso-1cje updates the infrastructure path references.
+#
+# Tests:
+#   test_allowlist_uses_tickets_tracker_path
+#   test_compute_diff_hash_fallback_uses_tickets_tracker_path
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+PLUGIN_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
+DSO_PLUGIN_DIR="$PLUGIN_ROOT/plugins/dso"
+
+source "$PLUGIN_ROOT/tests/lib/assert.sh"
+
+ALLOWLIST="$DSO_PLUGIN_DIR/hooks/lib/review-gate-allowlist.conf"
+COMPUTE_DIFF_HASH="$DSO_PLUGIN_DIR/hooks/compute-diff-hash.sh"
+
+# ============================================================
+# test_allowlist_uses_tickets_tracker_path
+# review-gate-allowlist.conf must contain .tickets-tracker/**
+# (post-migration: old .tickets/** entry replaced with .tickets-tracker/**)
+# ============================================================
+test_allowlist_uses_tickets_tracker_path() {
+    local match
+    match=$(grep -c '\.tickets-tracker/\*\*' "$ALLOWLIST" 2>/dev/null || true)
+    match="${match:-0}"
+    assert_eq "test_allowlist_uses_tickets_tracker_path" "true" \
+        "$( [[ "${match}" -ge 1 ]] && echo true || echo false )"
+}
+
+# ============================================================
+# test_compute_diff_hash_fallback_uses_tickets_tracker_path
+# The fallback pathspecs in compute-diff-hash.sh must contain
+# ':!.tickets-tracker/**' (not the old ':!.tickets/**')
+# ============================================================
+test_compute_diff_hash_fallback_uses_tickets_tracker_path() {
+    local match
+    match=$(grep -c "':!\.tickets-tracker/\*\*'" "$COMPUTE_DIFF_HASH" 2>/dev/null || true)
+    match="${match:-0}"
+    assert_eq "test_compute_diff_hash_fallback_uses_tickets_tracker_path" "true" \
+        "$( [[ "${match}" -ge 1 ]] && echo true || echo false )"
+}
+
+# Run all tests
+test_allowlist_uses_tickets_tracker_path
+test_compute_diff_hash_fallback_uses_tickets_tracker_path
+
+print_summary
diff --git a/tests/hooks/test-pre-bash-functions-ticket-guards.sh b/tests/hooks/test-pre-bash-functions-ticket-guards.sh
