chore: auto-commit ticket changes before merge (merge worktree-20260321-144840)

Author: JoeOakhartNava

.tickets/.index.json

@@ -492,6 +492,13 @@
     "title": "Add dev-onboarding and design-onboarding to setup",
     "type": "epic"
   },
+  "dso-ptct": {
+    "deps": [],
+    "priority": 1,
+    "status": "closed",
+    "title": "Bug: stat -f || stat -c fallback pattern broken on Linux \u2014 stat -f succeeds with wrong semantics",
+    "type": "bug"
+  },
   "dso-pxos": {
     "deps": [],
     "priority": 1,

.tickets/dso-ptct.md

@@ -0,0 +1,28 @@
+---
+id: dso-ptct
+status: closed
+deps: []
+links: []
+created: 2026-03-21T23:55:41Z
+type: bug
+priority: 1
+assignee: Joe Oakhart
+---
+# Bug: stat -f || stat -c fallback pattern broken on Linux — stat -f succeeds with wrong semantics
+
+
+## Notes
+
+<!-- note-id: w3rqlnay -->
+<!-- timestamp: 2026-03-21T23:55:53Z -->
+<!-- origin: agent -->
+<!-- sync: unsynced -->
+
+Classification: mechanical. Root cause: stat -f '%m' on Linux does not fail — it returns filesystem metadata (block counts, inode info). The || fallback to stat -c '%Y' never triggers. Fix: use uname-based OS detection (same pattern as health-check.sh _file_mtime). Fixed in 5 locations across 4 files: test-compact-sync-precondition.sh, test-sync-roundtrip.sh, worktree-cleanup.sh, REVIEW-WORKFLOW.md. Test gate gap: the test gate correctly requires test-compact-sync-precondition.sh for changes to ticket-compact.sh, but the stat bug was in the TEST file itself (not the source file it covers). The test gate can't catch bugs in tests that only manifest on a different OS — this is a fundamental limitation addressed by CI, not the gate.
+
+<!-- note-id: a7f6sjyk -->
+<!-- timestamp: 2026-03-21T23:59:45Z -->
+<!-- origin: agent -->
+<!-- sync: unsynced -->
+
+CLOSE REASON: Fixed: replaced broken stat -f || stat -c fallback with uname-based OS detection in 4 files

plugins/dso/docs/workflows/REVIEW-WORKFLOW.md

@@ -51,7 +51,11 @@ mkdir -p "$ARTIFACTS_DIR"
 VALIDATION_STATUS="$ARTIFACTS_DIR/validation-status"
 if [ -f "$VALIDATION_STATUS" ]; then
     status_content=$(head -n 1 "$VALIDATION_STATUS")
-    status_age=$(( $(date +%s) - $(stat -f %m "$VALIDATION_STATUS" 2>/dev/null || stat -c %Y "$VALIDATION_STATUS" 2>/dev/null || echo 0) ))
+    if [ "$(uname)" = "Darwin" ]; then
+        status_age=$(( $(date +%s) - $(stat -f %m "$VALIDATION_STATUS" 2>/dev/null || echo 0) ))
+    else
+        status_age=$(( $(date +%s) - $(stat -c %Y "$VALIDATION_STATUS" 2>/dev/null || echo 0) ))
+    fi
     if [ "$status_content" = "passed" ] && [ "$status_age" -lt 60 ]; then
         # Validation is fresh — skip to Step 2
     fi

plugins/dso/scripts/worktree-cleanup.sh

@@ -223,7 +223,11 @@ is_old_enough() {
 
     if [[ "$created_epoch" -eq 0 ]]; then
         # Fall back to mtime of the directory
-        created_epoch=$(stat -f %m "$wt_path" 2>/dev/null || stat -c %Y "$wt_path" 2>/dev/null || echo "0")
+        if [[ "$(uname)" == "Darwin" ]]; then
+            created_epoch=$(stat -f %m "$wt_path" 2>/dev/null || echo "0")
+        else
+            created_epoch=$(stat -c %Y "$wt_path" 2>/dev/null || echo "0")
+        fi
     fi
 
     local now_epoch

tests/plugin/test-sync-roundtrip.sh

@@ -454,12 +454,24 @@ _issue8='{"key":"TEST-8","fields":{"summary":"Idempotent pull","description":"bo
 pull_ticket_direct "$_T8" "$_ledger8" "$_issue8" "${ACLI_PATH_PREFIX:-}" >/dev/null 2>&1 || true
 _ticket8=$(ls "$_T8"/*.md 2>/dev/null | head -1)
 _mtime8_before=""
-[[ -n "$_ticket8" ]] && _mtime8_before=$(stat -f "%m" "$_ticket8" 2>/dev/null || stat -c "%Y" "$_ticket8" 2>/dev/null || echo "")
+if [[ -n "$_ticket8" ]]; then
+    if [[ "$(uname)" == "Darwin" ]]; then
+        _mtime8_before=$(stat -f "%m" "$_ticket8" 2>/dev/null || echo "")
+    else
+        _mtime8_before=$(stat -c "%Y" "$_ticket8" 2>/dev/null || echo "")
+    fi
+fi
 sleep 1
 # Second pull: same JSON → skip
 _out8=$(pull_ticket_direct "$_T8" "$_ledger8" "$_issue8" "${ACLI_PATH_PREFIX:-}" 2>&1) || true
 _mtime8_after=""
-[[ -n "$_ticket8" ]] && _mtime8_after=$(stat -f "%m" "$_ticket8" 2>/dev/null || stat -c "%Y" "$_ticket8" 2>/dev/null || echo "")
+if [[ -n "$_ticket8" ]]; then
+    if [[ "$(uname)" == "Darwin" ]]; then
+        _mtime8_after=$(stat -f "%m" "$_ticket8" 2>/dev/null || echo "")
+    else
+        _mtime8_after=$(stat -c "%Y" "$_ticket8" 2>/dev/null || echo "")
+    fi
+fi
 if echo "$_out8" | grep -qiE "skip(ped)?|unchanged"; then
     echo "  PASS: pull_second_call_skips_unchanged"
     ((PASS++))

tests/scripts/test-compact-sync-precondition.sh

@@ -177,9 +177,17 @@ test_compact_calls_sync_before_compacting() {
     snapshot_file=$(find "$ticket_dir" -maxdepth 1 -name '*-SNAPSHOT.json' 2>/dev/null | head -1)
     if [ -n "$snapshot_file" ]; then
         local snapshot_mtime
-        snapshot_mtime=$(stat -f '%m' "$snapshot_file" 2>/dev/null || stat -c '%Y' "$snapshot_file" 2>/dev/null || echo "0")
+        if [[ "$(uname)" == "Darwin" ]]; then
+            snapshot_mtime=$(stat -f '%m' "$snapshot_file" 2>/dev/null || echo "0")
+        else
+            snapshot_mtime=$(stat -c '%Y' "$snapshot_file" 2>/dev/null || echo "0")
+        fi
         local sync_log_mtime
-        sync_log_mtime=$(stat -f '%m' "$call_log" 2>/dev/null || stat -c '%Y' "$call_log" 2>/dev/null || echo "0")
+        if [[ "$(uname)" == "Darwin" ]]; then
+            sync_log_mtime=$(stat -f '%m' "$call_log" 2>/dev/null || echo "0")
+        else
+            sync_log_mtime=$(stat -c '%Y' "$call_log" 2>/dev/null || echo "0")
+        fi
         # call_log was written DURING sync (before SNAPSHOT creation).
         # If sync ran first, call_log mtime <= snapshot mtime.
         assert_eq "sync logged before SNAPSHOT creation" "ordered" \