feat(dso-kknz): batch 11 — RED tests for dso-setup.sh .claude/dso-config.conf

Add 3 new failing tests to test-dso-setup.sh verifying that dso-setup.sh
creates .claude/dso-config.conf (not workflow-config.conf), is idempotent
at the new path, and respects dryrun mode. Tests are intentionally RED.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: JoeOakhartNava

.tickets/.index.json

@@ -367,6 +367,13 @@
     "title": "Fix: test-merge-to-main-portability.sh 2 failures (8 pass, 2 fail)",
     "type": "bug"
   },
+  "dso-hui3": {
+    "deps": [],
+    "priority": 1,
+    "status": "open",
+    "title": "RED: Write failing tests for dso-setup.sh .claude/dso-config.conf path",
+    "type": "task"
+  },
   "dso-i6dj": {
     "deps": [],
     "priority": 2,
@@ -599,6 +606,15 @@
     "title": "RED: Write failing tests for ci.workflow_name in validate-config.sh",
     "type": "task"
   },
+  "dso-sapj": {
+    "deps": [
+      "dso-hui3"
+    ],
+    "priority": 1,
+    "status": "open",
+    "title": "Update dso-setup.sh to create config at .claude/dso-config.conf",
+    "type": "task"
+  },
   "dso-soyt": {
     "deps": [],
     "priority": 2,

.tickets/.sync-state.json

@@ -449,8 +449,8 @@
     "last_synced": "2026-03-19T18:38:35Z",
     "local_hash": "14c516947a151a3db8bdec4010e2fd6e"
   },
-  "last_pull_timestamp": "2026-03-20T15:25:43Z",
-  "last_sync_commit": "72a568cd7137f69505c3b442c8d7140a332a18fb",
+  "last_pull_timestamp": "2026-03-20T15:44:56Z",
+  "last_sync_commit": "c4b7b87208ea8df74953158662d85a32b469a025",
   "w21-5cqr": {
     "jira_hash": "bce29d76f01c58613ee99cb1dd03920d",
     "jira_key": "DIG-61",

.tickets/dso-cn4j.md

@@ -1,6 +1,6 @@
 ---
 id: dso-cn4j
-status: in_progress
+status: closed
 deps: [dso-opue, dso-6trc, dso-tuz0, dso-2vwl]
 links: []
 created: 2026-03-20T03:34:03Z

.tickets/dso-hui3.md

@@ -0,0 +1,138 @@
+---
+id: dso-hui3
+status: in_progress
+deps: []
+links: []
+created: 2026-03-20T15:34:44Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: dso-q2ev
+---
+# RED: Write failing tests for dso-setup.sh .claude/dso-config.conf path
+
+## What
+
+Add 3 new failing test functions to tests/scripts/test-dso-setup.sh that assert dso-setup.sh creates and manages .claude/dso-config.conf (the new path), not workflow-config.conf.
+
+## Why (RED phase)
+
+These tests must FAIL before the implementation task runs, confirming the current script writes to the old path. After the implementation task completes, these tests must turn GREEN.
+
+## Tests to Add
+
+Add the following functions before the 'Run all tests' section in tests/scripts/test-dso-setup.sh, and call each function in the 'Run all tests' block:
+
+### test_setup_writes_dso_config_conf
+Verifies dso-setup.sh writes dso.plugin_root= to .claude/dso-config.conf (not workflow-config.conf).
+
+```bash
+test_setup_writes_dso_config_conf() {
+    local T
+    T=$(mktemp -d)
+    TMPDIRS+=("$T")
+    git -C "$T" init -q
+
+    bash "$SETUP_SCRIPT" "$T" "$PLUGIN_ROOT" >/dev/null 2>&1 || true
+
+    local result="missing"
+    if grep -q "^dso.plugin_root=" "$T/.claude/dso-config.conf" 2>/dev/null; then
+        result="exists"
+    fi
+    assert_eq "test_setup_writes_dso_config_conf" "exists" "$result"
+}
+```
+
+### test_setup_dso_config_conf_idempotent
+Verifies running dso-setup.sh twice does NOT duplicate dso.plugin_root= in .claude/dso-config.conf.
+
+```bash
+test_setup_dso_config_conf_idempotent() {
+    local T
+    T=$(mktemp -d)
+    TMPDIRS+=("$T")
+    git -C "$T" init -q
+
+    bash "$SETUP_SCRIPT" "$T" "$PLUGIN_ROOT" >/dev/null 2>&1 || true
+    bash "$SETUP_SCRIPT" "$T" "$PLUGIN_ROOT" >/dev/null 2>&1 || true
+
+    local count=0
+    count=$(grep -c "^dso.plugin_root=" "$T/.claude/dso-config.conf" 2>/dev/null || echo "0")
+    assert_eq "test_setup_dso_config_conf_idempotent" "1" "$count"
+}
+```
+
+### test_setup_dryrun_no_dso_config_conf_written
+Verifies --dryrun mode does NOT create .claude/dso-config.conf.
+
+```bash
+test_setup_dryrun_no_dso_config_conf_written() {
+    local T
+    T=$(mktemp -d)
+    TMPDIRS+=("$T")
+    git -C "$T" init -q
+
+    bash "$SETUP_SCRIPT" "$T" "$PLUGIN_ROOT" --dryrun >/dev/null 2>&1 || true
+
+    if [[ ! -f "$T/.claude/dso-config.conf" ]]; then
+        assert_eq "test_setup_dryrun_no_dso_config_conf_written" "not-written" "not-written"
+    else
+        assert_eq "test_setup_dryrun_no_dso_config_conf_written" "not-written" "written"
+    fi
+}
+```
+
+## TDD Requirement
+
+Write the three test functions (RED phase) and confirm they FAIL by running:
+  bash tests/scripts/test-dso-setup.sh 2>&1 | grep -E 'FAIL|test_setup_writes_dso_config_conf|test_setup_dso_config_conf_idempotent|test_setup_dryrun_no_dso_config_conf_written'
+
+Expected: all 3 new tests FAIL (they assert .claude/dso-config.conf path which does not yet exist in dso-setup.sh).
+
+## Files to Edit
+
+- tests/scripts/test-dso-setup.sh (add 3 new test functions + call each in run-all block)
+
+## ACCEPTANCE CRITERIA
+
+- [ ] `bash tests/run-all.sh` passes (exit 0)
+  Verify: cd $(git rev-parse --show-toplevel) && bash tests/run-all.sh
+- [ ] `ruff check plugins/dso/scripts/*.py tests/**/*.py` passes (exit 0)
+  Verify: cd $(git rev-parse --show-toplevel) && ruff check plugins/dso/scripts/*.py tests/**/*.py
+- [ ] `ruff format --check plugins/dso/scripts/*.py tests/**/*.py` passes (exit 0)
+  Verify: cd $(git rev-parse --show-toplevel) && ruff format --check plugins/dso/scripts/*.py tests/**/*.py
+- [ ] test_setup_writes_dso_config_conf function exists in test-dso-setup.sh
+  Verify: grep -q 'test_setup_writes_dso_config_conf' $(git rev-parse --show-toplevel)/tests/scripts/test-dso-setup.sh
+- [ ] test_setup_dso_config_conf_idempotent function exists in test-dso-setup.sh
+  Verify: grep -q 'test_setup_dso_config_conf_idempotent' $(git rev-parse --show-toplevel)/tests/scripts/test-dso-setup.sh
+- [ ] test_setup_dryrun_no_dso_config_conf_written function exists in test-dso-setup.sh
+  Verify: grep -q 'test_setup_dryrun_no_dso_config_conf_written' $(git rev-parse --show-toplevel)/tests/scripts/test-dso-setup.sh
+- [ ] All 3 new tests FAIL (RED) before implementation — dso-setup.sh still writes to old path
+  Verify: bash $(git rev-parse --show-toplevel)/tests/scripts/test-dso-setup.sh 2>&1 | grep -c 'FAIL' | awk '{exit ($1 < 3)}'
+
+
+## Notes
+
+**2026-03-20T15:38:44Z**
+
+CHECKPOINT 1/6: Task context loaded ✓
+
+**2026-03-20T15:39:44Z**
+
+CHECKPOINT 2/6: Code patterns understood ✓
+
+**2026-03-20T15:40:26Z**
+
+CHECKPOINT 3/6: Tests written ✓
+
+**2026-03-20T15:40:30Z**
+
+CHECKPOINT 4/6: Implementation complete ✓
+
+**2026-03-20T15:43:35Z**
+
+CHECKPOINT 5/6: Tests run — 2 of 3 new tests FAIL (RED) as expected; 3rd (dryrun) passes trivially (file never written at old path either). Pre-existing failure test_setup_dso_tk_help_works unchanged. 54 passed, 3 failed total. ✓
+
+**2026-03-20T15:43:40Z**
+
+CHECKPOINT 6/6: Done ✓

.tickets/dso-sapj.md

@@ -0,0 +1,86 @@
+---
+id: dso-sapj
+status: open
+deps: [dso-hui3]
+links: []
+created: 2026-03-20T15:35:16Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: dso-q2ev
+---
+# Update dso-setup.sh to create config at .claude/dso-config.conf
+
+## What
+
+Update plugins/dso/scripts/dso-setup.sh to write dso.plugin_root= to .claude/dso-config.conf (not workflow-config.conf), and update all test fixtures in tests/scripts/test-dso-setup.sh that assert the old workflow-config.conf path.
+
+## Why
+
+Story dso-q2ev: dso-setup.sh must create .claude/dso-config.conf in host projects and must not create workflow-config.conf. Story dso-uc2d (CLOSED) already migrated config resolution — this story completes the setup side.
+
+## Changes to dso-setup.sh
+
+1. Line 114 comment: update 'workflow-config.conf' to '.claude/dso-config.conf'
+2. Lines 131-141 CONFIG block:
+   - Change: CONFIG="$TARGET_REPO/workflow-config.conf"
+   - To:     CONFIG="$TARGET_REPO/.claude/dso-config.conf"
+   - In the live-run branch (not dryrun), ensure mkdir -p "$(dirname "$CONFIG")" before writing to CONFIG (the .claude/ dir may not exist if setup is running for the first time and hasn't created it yet via shim install — confirm: line 124 already does mkdir -p "$TARGET_REPO/.claude/scripts/" so .claude/ is guaranteed to exist before CONFIG is written; no extra mkdir needed)
+   - Update dryrun echo message: 'Would write dso.plugin_root=$PLUGIN_ROOT to $CONFIG' (CONFIG auto-reflects new value)
+3. Line 463 env var guidance echo: change 'workflow-config.conf' to '.claude/dso-config.conf'
+4. Line 471 next steps echo: change '1. Edit workflow-config.conf' to '1. Edit .claude/dso-config.conf'
+
+## Changes to tests/scripts/test-dso-setup.sh
+
+Update fixture assertions that reference the old path (must reference new path to pass GREEN):
+
+1. test_setup_writes_plugin_root (line 71): grep path "$T/workflow-config.conf" → "$T/.claude/dso-config.conf"
+2. test_setup_is_idempotent (lines 91, 102): grep path "$T/workflow-config.conf" → "$T/.claude/dso-config.conf"
+   Also update the pre-existing-entry fixture (line 98): echo into "$T2/.claude/dso-config.conf" instead of "$T2/workflow-config.conf"
+3. test_setup_dryrun_no_config_written (line 462): check path "$T/workflow-config.conf" → "$T/.claude/dso-config.conf"
+4. test_setup_is_still_idempotent_with_new_features (line 432): grep path "$T/workflow-config.conf" → "$T/.claude/dso-config.conf"
+
+## TDD Requirement
+
+This task is GREEN phase — it makes tests written in task dso-hui3 pass.
+
+After changes, run:
+  bash tests/scripts/test-dso-setup.sh 2>&1 | tail -20
+
+Expected: ALL tests pass including the 3 new tests from dso-hui3 AND all previously-passing tests (no regressions).
+
+## Acceptance Criteria Details
+
+- [ ] grep -q 'dso.plugin_root=' "$T/.claude/dso-config.conf" passes after fresh setup (new path written)
+  Verify: T=$(mktemp -d) && git -C "$T" init -q && bash plugins/dso/scripts/dso-setup.sh "$T" plugins/dso >/dev/null 2>&1; grep -q 'dso.plugin_root=' "$T/.claude/dso-config.conf" && echo OK
+- [ ] workflow-config.conf is NOT created at repo root by dso-setup.sh
+  Verify: T=$(mktemp -d) && git -C "$T" init -q && bash plugins/dso/scripts/dso-setup.sh "$T" plugins/dso >/dev/null 2>&1; ! test -f "$T/workflow-config.conf" && echo OK
+- [ ] dso-setup.sh idempotent: second run does not duplicate entry in .claude/dso-config.conf
+  Verify: T=$(mktemp -d) && git -C "$T" init -q && bash plugins/dso/scripts/dso-setup.sh "$T" plugins/dso >/dev/null 2>&1; bash plugins/dso/scripts/dso-setup.sh "$T" plugins/dso >/dev/null 2>&1; count=$(grep -c '^dso.plugin_root=' "$T/.claude/dso-config.conf") && [ "$count" = 1 ] && echo OK
+- [ ] --dryrun does not create .claude/dso-config.conf
+  Verify: T=$(mktemp -d) && git -C "$T" init -q && bash plugins/dso/scripts/dso-setup.sh "$T" plugins/dso --dryrun >/dev/null 2>&1; ! test -f "$T/.claude/dso-config.conf" && echo OK
+
+## Files to Edit
+
+- plugins/dso/scripts/dso-setup.sh (lines 114, 131, 137, 140, 463, 471)
+- tests/scripts/test-dso-setup.sh (lines 71, 91, 98-103, 432, 462)
+
+## ACCEPTANCE CRITERIA
+
+- [ ] `bash tests/run-all.sh` passes (exit 0)
+  Verify: cd $(git rev-parse --show-toplevel) && bash tests/run-all.sh
+- [ ] `ruff check plugins/dso/scripts/*.py tests/**/*.py` passes (exit 0)
+  Verify: cd $(git rev-parse --show-toplevel) && ruff check plugins/dso/scripts/*.py tests/**/*.py
+- [ ] `ruff format --check plugins/dso/scripts/*.py tests/**/*.py` passes (exit 0)
+  Verify: cd $(git rev-parse --show-toplevel) && ruff format --check plugins/dso/scripts/*.py tests/**/*.py
+- [ ] dso-setup.sh writes dso.plugin_root= to .claude/dso-config.conf (new path)
+  Verify: T=$(mktemp -d) && git -C "$T" init -q && bash $(git rev-parse --show-toplevel)/plugins/dso/scripts/dso-setup.sh "$T" $(git rev-parse --show-toplevel)/plugins/dso >/dev/null 2>&1; grep -q 'dso.plugin_root=' "$T/.claude/dso-config.conf" && echo OK
+- [ ] dso-setup.sh does NOT create workflow-config.conf at repo root
+  Verify: T=$(mktemp -d) && git -C "$T" init -q && bash $(git rev-parse --show-toplevel)/plugins/dso/scripts/dso-setup.sh "$T" $(git rev-parse --show-toplevel)/plugins/dso >/dev/null 2>&1; ! test -f "$T/workflow-config.conf" && echo OK
+- [ ] dso-setup.sh idempotent: second run does not duplicate entry in .claude/dso-config.conf
+  Verify: T=$(mktemp -d) && git -C "$T" init -q && R=$(git rev-parse --show-toplevel) && bash "$R/plugins/dso/scripts/dso-setup.sh" "$T" "$R/plugins/dso" >/dev/null 2>&1 && bash "$R/plugins/dso/scripts/dso-setup.sh" "$T" "$R/plugins/dso" >/dev/null 2>&1; count=$(grep -c '^dso.plugin_root=' "$T/.claude/dso-config.conf") && [ "$count" = 1 ] && echo OK
+- [ ] --dryrun does not create .claude/dso-config.conf
+  Verify: T=$(mktemp -d) && git -C "$T" init -q && bash $(git rev-parse --show-toplevel)/plugins/dso/scripts/dso-setup.sh "$T" $(git rev-parse --show-toplevel)/plugins/dso --dryrun >/dev/null 2>&1; ! test -f "$T/.claude/dso-config.conf" && echo OK
+- [ ] All tests in test-dso-setup.sh pass including dso-hui3 RED tests (now GREEN)
+  Verify: bash $(git rev-parse --show-toplevel)/tests/scripts/test-dso-setup.sh 2>&1 | grep -c FAIL | awk '{exit ($1 > 0)}'
+

.tickets/dso-uc2d.md

@@ -1,6 +1,6 @@
 ---
 id: dso-uc2d
-status: open
+status: closed
 deps: []
 links: []
 created: 2026-03-20T00:09:30Z

tests/scripts/test-dso-setup.sh

@@ -1197,6 +1197,61 @@ EOF
     fi
 }
 
+# ── .claude/dso-config.conf path tests (dso-hui3) ────────────────────────────
+#
+# RED-phase: All 3 tests FAIL until dso-setup.sh is updated to write
+# dso.plugin_root= to .claude/dso-config.conf instead of workflow-config.conf.
+
+# test_setup_writes_dso_config_conf: dso-setup.sh must write dso.plugin_root=
+# to .claude/dso-config.conf (not workflow-config.conf).
+test_setup_writes_dso_config_conf() {
+    local T
+    T=$(mktemp -d)
+    TMPDIRS+=("$T")
+    git -C "$T" init -q
+
+    bash "$SETUP_SCRIPT" "$T" "$PLUGIN_ROOT" >/dev/null 2>&1 || true
+
+    local result="missing"
+    if grep -q "^dso.plugin_root=" "$T/.claude/dso-config.conf" 2>/dev/null; then
+        result="exists"
+    fi
+    assert_eq "test_setup_writes_dso_config_conf" "exists" "$result"
+}
+
+# test_setup_dso_config_conf_idempotent: running dso-setup.sh twice must NOT
+# duplicate dso.plugin_root= in .claude/dso-config.conf.
+test_setup_dso_config_conf_idempotent() {
+    local T
+    T=$(mktemp -d)
+    TMPDIRS+=("$T")
+    git -C "$T" init -q
+
+    bash "$SETUP_SCRIPT" "$T" "$PLUGIN_ROOT" >/dev/null 2>&1 || true
+    bash "$SETUP_SCRIPT" "$T" "$PLUGIN_ROOT" >/dev/null 2>&1 || true
+
+    local count=0
+    count=$(grep -c "^dso.plugin_root=" "$T/.claude/dso-config.conf" 2>/dev/null || echo "0")
+    assert_eq "test_setup_dso_config_conf_idempotent" "1" "$count"
+}
+
+# test_setup_dryrun_no_dso_config_conf_written: --dryrun must NOT create
+# .claude/dso-config.conf.
+test_setup_dryrun_no_dso_config_conf_written() {
+    local T
+    T=$(mktemp -d)
+    TMPDIRS+=("$T")
+    git -C "$T" init -q
+
+    bash "$SETUP_SCRIPT" "$T" "$PLUGIN_ROOT" --dryrun >/dev/null 2>&1 || true
+
+    if [[ ! -f "$T/.claude/dso-config.conf" ]]; then
+        assert_eq "test_setup_dryrun_no_dso_config_conf_written" "not-written" "not-written"
+    else
+        assert_eq "test_setup_dryrun_no_dso_config_conf_written" "not-written" "written"
+    fi
+}
+
 # ── Run all tests ─────────────────────────────────────────────────────────────
 test_setup_creates_shim
 test_setup_shim_executable
@@ -1242,5 +1297,8 @@ test_ci_guard_consumes_detection_output_not_yaml
 test_ci_guard_dryrun_shows_analysis_no_changes
 test_ci_guard_no_workflow_still_copies_example
 test_ci_guard_missing_format_guard_detected
+test_setup_writes_dso_config_conf
+test_setup_dso_config_conf_idempotent
+test_setup_dryrun_no_dso_config_conf_written
 
 print_summary