Skip to content

Commit 254543a

Browse files
chore: auto-commit ticket changes before merge (merge worktree-20260320-205800)
2 parents 38b7e98 + 8acebd2 commit 254543a

File tree

5 files changed

+77
-4
lines changed

5 files changed

+77
-4
lines changed

.tickets/.sync-state.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,8 +449,8 @@
449449
"last_synced": "2026-03-19T18:38:35Z",
450450
"local_hash": "14c516947a151a3db8bdec4010e2fd6e"
451451
},
452-
"last_pull_timestamp": "2026-03-21T16:05:39Z",
453-
"last_sync_commit": "53936696d9e191cdf86887f79110edb97244af66",
452+
"last_pull_timestamp": "2026-03-21T16:34:13Z",
453+
"last_sync_commit": "118f654de57827bfbd49d7f10088dc8f4bf23540",
454454
"w21-5cqr": {
455455
"jira_hash": "bce29d76f01c58613ee99cb1dd03920d",
456456
"jira_key": "DIG-61",

.tickets/w22-528r.md

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
---
2+
id: w22-528r
3+
status: open
4+
deps: []
5+
links: []
6+
created: 2026-03-21T16:28:18Z
7+
type: epic
8+
priority: 2
9+
assignee: Joe Oakhart
10+
---
11+
# Setup skill: auto-discover host project test suites for CI workflow generation
12+
13+
14+
## Notes
15+
16+
**2026-03-21T16:28:31Z**
17+
18+
## Problem
19+
20+
When /dso:project-setup helps a new project create a CI process from our example (examples/ci.example.yml), it copies a hardcoded template with specific job names (test-unit-agents, test-unit-services, etc.) that only match one project's structure. The host project's actual test suites are not incorporated — they have to be added manually.
21+
22+
## Current Behavior
23+
24+
- For projects with no CI: copies ci.example.yml as-is (static template)
25+
- For projects with existing CI: runs guard analysis (test/lint/format present?) but doesn't modify the workflow
26+
- project-detect.sh detects Makefile targets and test/lint/format presence, but does NOT discover individual test suites
27+
- Config keys (commands.test_unit, commands.test) are generic — they don't map to per-suite CI jobs
28+
29+
## Investigation Findings
30+
31+
Key files:
32+
- plugins/dso/scripts/dso-setup.sh (lines 353-440): CI workflow creation logic
33+
- plugins/dso/scripts/project-detect.sh (lines 216-260): CI workflow detection
34+
- plugins/dso/skills/project-setup/SKILL.md: orchestrates setup including CI
35+
- examples/ci.example.yml: static template copied for new projects
36+
37+
project-detect.sh already extracts Makefile targets (grep for top-level targets) and checks for test/lint/format commands in existing workflows. But it stops at boolean presence detection — no discovery of individual test directories or suite structure.
38+
39+
## Desired Behavior
40+
41+
1. Extend project-detect.sh to discover test suite directories and their associated Makefile targets (e.g., tests/unit/agents/ -> make test-unit-agents, tests/hooks/ -> bash tests/run-hooks.sh)
42+
2. When generating the CI workflow for a new project, dynamically template job definitions from detected suites instead of copying a static file
43+
3. For existing CI workflows missing test guards, offer to add jobs for discovered-but-uncovered test suites
44+
45+
## Status
46+
47+
Placeholder epic — needs /dso:brainstorm refinement before implementation.

.tickets/w22-7jyn.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
---
2+
id: w22-7jyn
3+
status: closed
4+
deps: []
5+
links: []
6+
created: 2026-03-21T16:29:32Z
7+
type: bug
8+
priority: 1
9+
assignee: Joe Oakhart
10+
---
11+
# Bug: CI Script Tests — 2 failures (test-doc-migration legacy ref, test-ticket-comment ordering)
12+
13+
14+
## Notes
15+
16+
**2026-03-21T16:29:41Z**
17+
18+
CI run 23383713866 on commit 38b7e98 (main). Script Tests job failed with 2 failures:
19+
20+
1. test-doc-migration.sh: test_no_legacy_plugin_root_refs — expected 0 legacy refs, found 1. Likely a new file introduced a reference to a deprecated plugin root path pattern.
21+
22+
2. test-ticket-comment.sh: 'reducer shows both comments in order' — expected OK, got WRONG_FIRST:'second comment'. Comment ordering issue in the ticket comment reducer — second comment appears where first should be.
23+
24+
**2026-03-21T16:36:40Z**
25+
26+
Fixed: (1) legacy CLAUDE_PLUGIN_ROOT ref in resolve-conflicts/SKILL.md, (2) ticket-comment.sh timestamp collision via time.time_ns(). Commit 0385456.

plugins/dso/scripts/ticket-comment.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ python3 -c "
6666
import json, sys, time, uuid
6767
6868
event = {
69-
'timestamp': int(time.time()),
69+
'timestamp': time.time_ns(),
7070
'uuid': str(uuid.uuid4()),
7171
'event_type': 'COMMENT',
7272
'env_id': sys.argv[1],

plugins/dso/skills/resolve-conflicts/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ Handle `.tickets/` conflicts as follows:
5959
git show :2:.tickets/.index.json > /tmp/ours.json
6060
git show :3:.tickets/.index.json > /tmp/theirs.json
6161
git show :1:.tickets/.index.json > /tmp/base.json
62-
python3 "${CLAUDE_PLUGIN_ROOT}/scripts/merge-ticket-index.py" /tmp/base.json /tmp/ours.json /tmp/theirs.json
62+
".claude/scripts/dso" merge-ticket-index.py /tmp/base.json /tmp/ours.json /tmp/theirs.json
6363
cp /tmp/ours.json .tickets/.index.json
6464
git add .tickets/.index.json
6565
```

0 commit comments

Comments
 (0)