chore: add TDD RED test files for implementation-plan skill improvements

Add xfail RED-phase test files for dso-gp00 (AC library new categories)
and dso-awsv (TDD enforcement language in SKILL.md). Also include
ticket metadata updates from previous session.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: JoeOakhartNava

.tickets/dso-4f1i.md

@@ -1,6 +1,6 @@
 ---
 id: dso-4f1i
-status: open
+status: in_progress
 deps: []
 links: []
 created: 2026-03-18T21:11:22Z

.tickets/dso-gsqg.md

@@ -1,6 +1,6 @@
 ---
 id: dso-gsqg
-status: open
+status: in_progress
 deps: []
 links: []
 created: 2026-03-18T21:11:38Z

.tickets/dso-tk5c.md

@@ -1,6 +1,6 @@
 ---
 id: dso-tk5c
-status: open
+status: in_progress
 deps: []
 links: []
 created: 2026-03-18T21:11:00Z

tests/skills/test_implementation_plan_ac_library.py

@@ -0,0 +1,52 @@
+"""Tests for new categories in ACCEPTANCE-CRITERIA-LIBRARY.md.
+
+These are RED-phase xfail tests. They assert the presence of two new
+categories that have not yet been added to the file. Once the GREEN task
+(dso-gp00) adds the content, these tests will pass and should be converted
+to normal assertions.
+"""
+
+import os
+
+import pytest
+
+REPO_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", ".."))
+AC_LIBRARY_PATH = os.path.join(
+    REPO_ROOT,
+    "plugins",
+    "dso",
+    "docs",
+    "ACCEPTANCE-CRITERIA-LIBRARY.md",
+)
+
+
+def _read_ac_library() -> str:
+    with open(AC_LIBRARY_PATH) as f:
+        return f.read()
+
+
+@pytest.mark.xfail(strict=True, reason="Category not yet added (dso-gp00)")
+def test_red_test_task_category_present() -> None:
+    """'Category: RED Test Task' must be present in ACCEPTANCE-CRITERIA-LIBRARY.md."""
+    content = _read_ac_library()
+    assert "Category: RED Test Task" in content
+
+
+@pytest.mark.xfail(strict=True, reason="Category not yet added (dso-gp00)")
+def test_test_exempt_task_category_present() -> None:
+    """'Category: Test-Exempt Task' must be present in ACCEPTANCE-CRITERIA-LIBRARY.md."""
+    content = _read_ac_library()
+    assert "Category: Test-Exempt Task" in content
+
+
+@pytest.mark.xfail(
+    strict=True, reason="Justification criterion not yet added (dso-gp00)"
+)
+def test_test_exempt_justification_criterion_present() -> None:
+    """The test-exempt category must include a justification criterion."""
+    content = _read_ac_library()
+    # Confirm the category exists and has justification text after it
+    assert "Category: Test-Exempt Task" in content
+    idx = content.index("Category: Test-Exempt Task")
+    section = content[idx : idx + 500]
+    assert "justification" in section.lower()

tests/skills/test_implementation_plan_skill_tdd_enforcement.py

@@ -0,0 +1,118 @@
+"""Tests for TDD enforcement language in implementation-plan/SKILL.md.
+
+TDD spec for task dso-awsv (GREEN task):
+- SKILL.md Step 3 must contain explicit TDD enforcement rules covering:
+  1. 'no conditional logic' — ban on conditional/parametric logic in tests
+  2. 'change-detector test' — escape hatch terminology
+  3. 'infrastructure-boundary-only' — scope qualifier for escape hatch
+  4. 'RED test task' — required naming for the failing-test task
+  5. 'behavioral content' — definition distinguishing real tests from test stubs
+  6. Integration test task rule language
+  7. 'existing coverage' — prohibition on relying on pre-existing tests
+  8. 'no test environment' — prohibition on writing tests needing special env
+  9. Justification requirement for escape hatch use
+
+All tests are marked xfail(strict=True) because SKILL.md has not yet been
+updated by dso-awsv. They will turn GREEN once dso-awsv lands its changes.
+"""
+
+import pathlib
+
+import pytest
+
+REPO_ROOT = pathlib.Path(__file__).resolve().parents[2]
+SKILL_MD = REPO_ROOT / "plugins" / "dso" / "skills" / "implementation-plan" / "SKILL.md"
+
+
+def _read_skill() -> str:
+    return SKILL_MD.read_text()
+
+
+@pytest.mark.xfail(strict=True, reason="RED: SKILL.md not yet updated by dso-awsv")
+def test_skill_md_contains_no_conditional_logic() -> None:
+    """SKILL.md must prohibit conditional/parametric logic in TDD test tasks."""
+    content = _read_skill()
+    assert "no conditional logic" in content, (
+        "SKILL.md Step 3 must contain 'no conditional logic' to prohibit "
+        "parametric test stubs that always pass."
+    )
+
+
+@pytest.mark.xfail(strict=True, reason="RED: SKILL.md not yet updated by dso-awsv")
+def test_skill_md_contains_change_detector_test() -> None:
+    """SKILL.md must name the escape hatch anti-pattern as 'change-detector test'."""
+    content = _read_skill()
+    assert "change-detector test" in content, (
+        "SKILL.md Step 3 must reference 'change-detector test' as the "
+        "canonical name for the escape hatch anti-pattern."
+    )
+
+
+@pytest.mark.xfail(strict=True, reason="RED: SKILL.md not yet updated by dso-awsv")
+def test_skill_md_contains_infrastructure_boundary_only() -> None:
+    """SKILL.md must restrict escape hatch to infrastructure-boundary-only cases."""
+    content = _read_skill()
+    assert "infrastructure-boundary-only" in content, (
+        "SKILL.md Step 3 must contain 'infrastructure-boundary-only' to scope "
+        "when the change-detector test escape hatch is permitted."
+    )
+
+
+@pytest.mark.xfail(strict=True, reason="RED: SKILL.md not yet updated by dso-awsv")
+def test_skill_md_contains_red_test_task() -> None:
+    """SKILL.md must require a named 'RED test task' as a distinct task in the plan."""
+    content = _read_skill()
+    assert "RED test task" in content, (
+        "SKILL.md Step 3 must require a 'RED test task' as a standalone task "
+        "that writes the failing test before implementation."
+    )
+
+
+@pytest.mark.xfail(strict=True, reason="RED: SKILL.md not yet updated by dso-awsv")
+def test_skill_md_contains_behavioral_content() -> None:
+    """SKILL.md must define 'behavioral content' to distinguish real tests."""
+    content = _read_skill()
+    assert "behavioral content" in content, (
+        "SKILL.md Step 3 must use 'behavioral content' to distinguish tests "
+        "with real assertions from empty stubs or pass-through fixtures."
+    )
+
+
+@pytest.mark.xfail(strict=True, reason="RED: SKILL.md not yet updated by dso-awsv")
+def test_skill_md_contains_integration_test_task_rule() -> None:
+    """SKILL.md must include rule language governing integration test tasks."""
+    content = _read_skill()
+    assert "integration test task" in content, (
+        "SKILL.md Step 3 must contain 'integration test task' rule language "
+        "specifying how integration tests fit into the TDD task structure."
+    )
+
+
+@pytest.mark.xfail(strict=True, reason="RED: SKILL.md not yet updated by dso-awsv")
+def test_skill_md_contains_existing_coverage() -> None:
+    """SKILL.md must prohibit relying on existing coverage to satisfy RED."""
+    content = _read_skill()
+    assert "existing coverage" in content, (
+        "SKILL.md Step 3 must reference 'existing coverage' to clarify that "
+        "pre-existing passing tests do not satisfy the RED requirement."
+    )
+
+
+@pytest.mark.xfail(strict=True, reason="RED: SKILL.md not yet updated by dso-awsv")
+def test_skill_md_contains_no_test_environment() -> None:
+    """SKILL.md must prohibit tests that require a special test environment."""
+    content = _read_skill()
+    assert "no test environment" in content, (
+        "SKILL.md Step 3 must contain 'no test environment' to prohibit "
+        "writing tests that require special setup unavailable in CI."
+    )
+
+
+@pytest.mark.xfail(strict=True, reason="RED: SKILL.md not yet updated by dso-awsv")
+def test_skill_md_contains_justification_requirement() -> None:
+    """SKILL.md must require a written justification when invoking the escape hatch."""
+    content = _read_skill()
+    assert "justification requirement" in content, (
+        "SKILL.md Step 3 must contain 'justification requirement' to require "
+        "agents to document why the change-detector test escape hatch was invoked."
+    )

tests/skills/test_implementation_plan_tdd_reviewer.py

@@ -0,0 +1,109 @@
+"""Tests for new dimensions in the implementation-plan TDD reviewer (tdd.md).
+
+All tests are xfail(strict=True) — they must fail until task dso-j700 adds the
+'red_test_dependency' and 'exemption_justification' dimensions to tdd.md and
+updates the review-criteria.md schema hash.
+"""
+
+import pathlib
+
+import pytest
+
+REPO_ROOT = pathlib.Path(__file__).resolve().parents[2]
+TDD_REVIEWER = (
+    REPO_ROOT
+    / "plugins"
+    / "dso"
+    / "skills"
+    / "implementation-plan"
+    / "docs"
+    / "reviewers"
+    / "plan"
+    / "tdd.md"
+)
+REVIEW_CRITERIA = (
+    REPO_ROOT
+    / "plugins"
+    / "dso"
+    / "skills"
+    / "implementation-plan"
+    / "docs"
+    / "review-criteria.md"
+)
+
+
+@pytest.mark.xfail(
+    strict=True, reason="dso-j700: red_test_dependency not yet added to tdd.md"
+)
+def test_tdd_reviewer_contains_red_test_dependency() -> None:
+    """tdd.md must define a 'red_test_dependency' dimension.
+
+    This dimension will flag plans where a task's specified failing test
+    depends on another task's code being written first (i.e., the test
+    cannot be run RED in isolation).
+    """
+    content = TDD_REVIEWER.read_text()
+    assert "red_test_dependency" in content, (
+        "tdd.md is missing the 'red_test_dependency' dimension. "
+        "Task dso-j700 must add it."
+    )
+
+
+@pytest.mark.xfail(
+    strict=True, reason="dso-j700: exemption_justification not yet added to tdd.md"
+)
+def test_tdd_reviewer_contains_exemption_justification() -> None:
+    """tdd.md must define an 'exemption_justification' dimension.
+
+    This dimension will require reviewers to flag tasks that claim a TDD
+    exemption without providing a written justification.
+    """
+    content = TDD_REVIEWER.read_text()
+    assert "exemption_justification" in content, (
+        "tdd.md is missing the 'exemption_justification' dimension. "
+        "Task dso-j700 must add it."
+    )
+
+
+@pytest.mark.xfail(
+    strict=True,
+    reason="dso-j700: exemption criteria description not yet added to tdd.md",
+)
+def test_tdd_reviewer_describes_exemption_criteria() -> None:
+    """tdd.md must describe when TDD exemptions are acceptable.
+
+    Acceptable exemption criteria include: the change contains 'no conditional
+    logic' or is a 'change-detector' test (a test that would pass vacuously).
+    At least one of these sentinel phrases must appear in tdd.md.
+    """
+    content = TDD_REVIEWER.read_text()
+    assert "no conditional logic" in content or "change-detector" in content, (
+        "tdd.md does not describe valid TDD exemption criteria. "
+        "Expected 'no conditional logic' or 'change-detector' to appear. "
+        "Task dso-j700 must add exemption criteria language."
+    )
+
+
+@pytest.mark.xfail(
+    strict=True,
+    reason="dso-j700: review-criteria.md still contains old hash ae8bfc7bd9a0d7e3",
+)
+def test_review_criteria_old_hash_absent() -> None:
+    """review-criteria.md must not contain the stale schema hash 'ae8bfc7bd9a0d7e3'.
+
+    Precondition: the file exists and is non-empty (guards against vacuous pass
+    if the file is deleted).
+
+    # NOTE: This test passes vacuously if review-criteria.md is deleted.
+    # Acceptable risk — file deletion would fail other tests.
+    """
+    assert REVIEW_CRITERIA.exists(), (
+        "review-criteria.md does not exist — cannot assert hash absence."
+    )
+    content = REVIEW_CRITERIA.read_text()
+    assert len(content) > 0, "review-criteria.md is empty — cannot assert hash absence."
+
+    assert "ae8bfc7bd9a0d7e3" not in content, (
+        "review-criteria.md still contains the old schema hash 'ae8bfc7bd9a0d7e3'. "
+        "Task dso-j700 must update the hash after adding new TDD dimensions."
+    )