Skip to content

Commit 53cad73

Browse files
Merge branch 'worktree-20260318-154530'
2 parents f666af2 + fcabefd commit 53cad73

File tree

4 files changed

+55
-5
lines changed

4 files changed

+55
-5
lines changed

.tickets/.index.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@
177177
"dso-bkqa"
178178
],
179179
"priority": 0,
180-
"status": "open",
180+
"status": "in_progress",
181181
"title": "Remove commands.test_plugin from validate-config.sh KNOWN_KEYS",
182182
"type": "task"
183183
},
@@ -356,7 +356,7 @@
356356
"dso-bkqa": {
357357
"deps": [],
358358
"priority": 0,
359-
"status": "in_progress",
359+
"status": "closed",
360360
"title": "Remove commands.test_plugin from workflow-config.conf and update test-validate-config-driven.sh",
361361
"type": "task"
362362
},

.tickets/dso-4clm.md

Lines changed: 45 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
id: dso-4clm
3-
status: open
3+
status: in_progress
44
deps: [dso-bkqa]
55
links: []
66
created: 2026-03-18T23:14:04Z
@@ -34,3 +34,47 @@ Files: plugins/dso/scripts/validate-config.sh, tests/scripts/test-validate-confi
3434
Verify: ! grep -q 'commands.test_plugin' $(git rev-parse --show-toplevel)/plugins/dso/scripts/validate-config.sh
3535
- [ ] New test_validate_config_does_not_know_test_plugin test exists in test-validate-config.sh
3636
Verify: grep -q 'test_validate_config_does_not_know_test_plugin' $(git rev-parse --show-toplevel)/tests/scripts/test-validate-config.sh
37+
38+
## Notes
39+
40+
<!-- note-id: q56vje2f -->
41+
<!-- timestamp: 2026-03-19T00:01:28Z -->
42+
<!-- origin: agent -->
43+
<!-- sync: unsynced -->
44+
45+
CHECKPOINT 1/6: Task context loaded ✓
46+
47+
<!-- note-id: j6oxu3rx -->
48+
<!-- timestamp: 2026-03-19T00:01:32Z -->
49+
<!-- origin: agent -->
50+
<!-- sync: unsynced -->
51+
52+
CHECKPOINT 2/6: Code patterns understood ✓
53+
54+
<!-- note-id: y0k9y5pg -->
55+
<!-- timestamp: 2026-03-19T00:01:49Z -->
56+
<!-- origin: agent -->
57+
<!-- sync: unsynced -->
58+
59+
CHECKPOINT 3/6: Tests written ✓
60+
61+
<!-- note-id: z1iafeo4 -->
62+
<!-- timestamp: 2026-03-19T00:01:58Z -->
63+
<!-- origin: agent -->
64+
<!-- sync: unsynced -->
65+
66+
CHECKPOINT 4/6: Implementation complete ✓
67+
68+
<!-- note-id: 99ke4okh -->
69+
<!-- timestamp: 2026-03-19T00:04:05Z -->
70+
<!-- origin: agent -->
71+
<!-- sync: unsynced -->
72+
73+
CHECKPOINT 5/6: Validation passed ✓
74+
75+
<!-- note-id: 1beiseov -->
76+
<!-- timestamp: 2026-03-19T00:04:05Z -->
77+
<!-- origin: agent -->
78+
<!-- sync: unsynced -->
79+
80+
CHECKPOINT 6/6: Done ✓

plugins/dso/scripts/validate-config.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ KNOWN_KEYS=(
6262
commands.syntax_check
6363
commands.lint_ruff
6464
commands.lint_mypy
65-
commands.test_plugin # REVIEW-DEFENSE: removed from workflow-config.conf in dso-bkqa; KNOWN_KEYS cleanup tracked in dso-4clm
66-
6765
# Database
6866
database.base_port
6967
database.ensure_cmd

tests/scripts/test-validate-config.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,5 +142,13 @@ rc=$?
142142
assert_eq "test_blank_key_exits_1 exit" "1" "$rc"
143143
assert_pass_if_clean "test_blank_key_exits_1"
144144

145+
# -- test_validate_config_does_not_know_test_plugin ---------------------------
146+
# commands.test_plugin must not appear in KNOWN_KEYS in validate-config.sh.
147+
_snapshot_fail
148+
{ grep -q 'commands\.test_plugin' "$SCRIPT"; test $? -ne 0; }
149+
rc=$?
150+
assert_eq "test_validate_config_does_not_know_test_plugin" "0" "$rc"
151+
assert_pass_if_clean "test_validate_config_does_not_know_test_plugin"
152+
145153
# -- Summary -------------------------------------------------------------------
146154
print_summary

0 commit comments

Comments
 (0)