Skip to content

Commit 5b41a89

Browse files
fix: Quick Reference escalation line now covers critical+major case (2431-2f4a) (merge worktree-20260324-164324)
2 parents 4c9fd5c + 1a24456 commit 5b41a89

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

plugins/dso/.claude-plugin/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "dso",
3-
"version": "0.26.2",
3+
"version": "0.26.3",
44
"description": "Workflow infrastructure plugin for Claude Code projects",
55
"commands": "./commands/",
66
"skills": "./skills/",

plugins/dso/docs/workflows/REVIEW-PROTOCOL-WORKFLOW.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ Stage 1 (Mental) → Caller self-reviews, fixes obvious issues
184184
Stage 2 (Single) → One sub-agent, multi-perspective rubric
185185
Returns REVIEW-SCHEMA.md JSON
186186
Stage 3 (Conflict) → Triggered by non-empty conflicts[]
187-
Escalate critical+critical to user
187+
Escalate critical+major or higher to user
188188
Minor yields to other finding
189189
Revision → Triage by severity, resolve conflicts first
190190
Max 3 cycles, then escalate to user

tests/hooks/test-review-protocol-workflow.sh

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,23 @@ else
8585
assert "Stage 3 contains severity terms (file missing)" 1
8686
fi
8787

88-
# Test 10: Contains Parameters section
88+
# Test 10: Quick Reference escalation line mentions both critical and major
89+
if [ -f "$WORKFLOW_FILE" ]; then
90+
qr_section=$(sed -n '/^## Quick Reference/,/^## /p' "$WORKFLOW_FILE")
91+
escalate_line=$(echo "$qr_section" | grep -i "escalat")
92+
if echo "$escalate_line" | grep -q "critical" && echo "$escalate_line" | grep -q "major"; then
93+
assert "Quick Reference escalation mentions both critical and major" 0
94+
else
95+
assert "Quick Reference escalation mentions both critical and major" 1
96+
fi
97+
else
98+
assert "Quick Reference escalation mentions both critical and major (file missing)" 1
99+
fi
100+
101+
# Test 11: Contains Parameters section
89102
run_check "Contains Parameters section" grep -q "## Parameters" "$WORKFLOW_FILE"
90103

91-
# Test 11: Contains Revision Protocol section
104+
# Test 12: Contains Revision Protocol section
92105
run_check "Contains Revision Protocol section" grep -q "## Revision Protocol" "$WORKFLOW_FILE"
93106

94107
echo ""

0 commit comments

Comments
 (0)