refactor(8a5b-e07b): remove ticket_find_open_children from ticket-lib.sh

Story ca17-acad: cleanup — function replaced by batch_close_operations
in ticket-unblock.py. No callers remain. Tests removed; equivalent
coverage exists in test_ticket_unblock.py::test_batch_close_finds_open_children.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: JoeOakhartNava

plugins/dso/scripts/ticket-lib.sh

@@ -250,47 +250,3 @@ state = json.loads(sys.argv[1])
 print(state.get('status', ''))
 " "$state_json"
 }
-
-# ticket_find_open_children <tracker_dir> <parent_id>
-# Lists all open (non-closed) child ticket IDs of a given parent ticket.
-# Outputs one ticket ID per line. Exits 0 even if no children are found.
-# Computes REDUCER path internally from BASH_SOURCE — does NOT rely on caller-set globals.
-#
-# Args:
-#   tracker_dir: path to .tickets-tracker worktree (passed by caller)
-#   parent_id:   ticket ID of the parent to search for children of
-ticket_find_open_children() {
-    local tracker_dir="$1"
-    local parent_id="$2"
-
-    # Resolve REDUCER path relative to this script's location
-    local lib_dir
-    lib_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-    local reducer="$lib_dir/ticket-reducer.py"
-
-    if [ ! -d "$tracker_dir" ]; then
-        echo "Error: tracker directory not found: $tracker_dir" >&2
-        return 1
-    fi
-
-    # Scan all subdirectories in tracker_dir, run reducer on each, filter by parent_id
-    local ticket_dir ticket_id state_json
-    for ticket_dir in "$tracker_dir"/*/; do
-        [ -d "$ticket_dir" ] || continue
-        ticket_id="$(basename "$ticket_dir")"
-
-        state_json=$(python3 "$reducer" "$ticket_dir" 2>/dev/null) || continue
-        [ -z "$state_json" ] && continue
-
-        python3 -c "
-import json, sys
-state = json.loads(sys.argv[1])
-parent_id = sys.argv[2]
-ticket_id = sys.argv[3]
-if state.get('parent_id') == parent_id and state.get('status') != 'closed':
-    print(ticket_id)
-" "$state_json" "$parent_id" "$ticket_id"
-    done
-
-    return 0
-}

tests/scripts/test-ticket-health-guards.sh

@@ -4,12 +4,8 @@
 #
 # Specifically tests:
 #   - ticket_read_status()         — reads compiled ticket status from reducer
-#   - ticket_find_open_children()  — lists open child tickets of a given parent
-#
-# All test functions MUST FAIL until ticket-lib.sh is updated to add these functions.
 #
 # Usage: bash tests/scripts/test-ticket-health-guards.sh
-# Returns: exit non-zero (RED) until ticket-lib.sh implements the helper functions.
 
 # NOTE: -e is intentionally omitted — test functions return non-zero by design
 # (they assert against unimplemented features). -e would abort the runner.
@@ -125,99 +121,4 @@ test_ticket_read_status_returns_current_status() {
 }
 test_ticket_read_status_returns_current_status
 
-# ── Test 2: ticket_find_open_children lists open children of a parent ──────────
-echo "Test 2: ticket_find_open_children() function exists and lists open child tickets"
-test_ticket_find_open_children_lists_children() {
-    _snapshot_fail
-
-    # Source ticket-lib.sh to check if ticket_find_open_children is defined
-    # RED: ticket_find_open_children does not exist in ticket-lib.sh yet
-    local fn_exists=0
-    (source "$TICKET_LIB" 2>/dev/null && declare -f ticket_find_open_children >/dev/null 2>&1) || fn_exists=$?
-
-    if [ "$fn_exists" -ne 0 ]; then
-        # Function does not exist — assert failure to mark RED
-        assert_eq "ticket_find_open_children function exists in ticket-lib.sh" "exists" "missing"
-        assert_pass_if_clean "test_ticket_find_open_children_lists_children"
-        return
-    fi
-
-    local repo
-    repo=$(_make_test_repo)
-    local tracker_dir="$repo/.tickets-tracker"
-
-    # Create a parent ticket (epic)
-    local parent_id
-    parent_id=$(_create_ticket "$repo" epic "Parent epic ticket")
-
-    if [ -z "$parent_id" ]; then
-        assert_eq "parent ticket created" "non-empty" "empty"
-        assert_pass_if_clean "test_ticket_find_open_children_lists_children"
-        return
-    fi
-
-    # Create two child tickets under the parent
-    local child1_id child2_id
-    child1_id=$(_create_child_ticket "$repo" "$parent_id" "Child ticket 1")
-    child2_id=$(_create_child_ticket "$repo" "$parent_id" "Child ticket 2")
-
-    if [ -z "$child1_id" ] || [ -z "$child2_id" ]; then
-        # If child creation with --parent is not yet implemented, the test must
-        # still fail RED (children can't be detected if they can't be created).
-        assert_eq "child tickets created with parent" "non-empty" "empty: child1=$child1_id child2=$child2_id"
-        assert_pass_if_clean "test_ticket_find_open_children_lists_children"
-        return
-    fi
-
-    # Call ticket_find_open_children: should list both children (both are open)
-    local children_out
-    local children_exit=0
-    children_out=$(
-        (cd "$repo" && source "$TICKET_LIB" && ticket_find_open_children "$tracker_dir" "$parent_id")
-    ) || children_exit=$?
-
-    # Assert: exits 0
-    assert_eq "ticket_find_open_children: exits 0" "0" "$children_exit"
-
-    # Assert: output contains child1_id
-    if echo "$children_out" | grep -qF "$child1_id"; then
-        assert_eq "ticket_find_open_children: lists child1" "has-child1" "has-child1"
-    else
-        assert_eq "ticket_find_open_children: lists child1" "has-child1" "missing: $children_out"
-    fi
-
-    # Assert: output contains child2_id
-    if echo "$children_out" | grep -qF "$child2_id"; then
-        assert_eq "ticket_find_open_children: lists child2" "has-child2" "has-child2"
-    else
-        assert_eq "ticket_find_open_children: lists child2" "has-child2" "missing: $children_out"
-    fi
-
-    # Now close child1 and verify it no longer appears in open children
-    _transition_ticket "$repo" "$child1_id" "open" "closed"
-
-    local children_after
-    local children_after_exit=0
-    children_after=$(
-        (cd "$repo" && source "$TICKET_LIB" && ticket_find_open_children "$tracker_dir" "$parent_id")
-    ) || children_after_exit=$?
-
-    # Assert: closed child1 is NOT in open children list
-    if echo "$children_after" | grep -qF "$child1_id"; then
-        assert_eq "ticket_find_open_children: excludes closed child1" "excludes-child1" "still-includes-child1"
-    else
-        assert_eq "ticket_find_open_children: excludes closed child1" "excludes-child1" "excludes-child1"
-    fi
-
-    # Assert: open child2 still appears
-    if echo "$children_after" | grep -qF "$child2_id"; then
-        assert_eq "ticket_find_open_children: still lists open child2" "has-child2" "has-child2"
-    else
-        assert_eq "ticket_find_open_children: still lists open child2" "has-child2" "missing: $children_after"
-    fi
-
-    assert_pass_if_clean "test_ticket_find_open_children_lists_children"
-}
-test_ticket_find_open_children_lists_children
-
 print_summary