feat: add behavioral test requirement to TDD workflow and acceptance criteria (merge worktree-20260324-091358)

Author: JoeOakhartNava

plugins/dso/scripts/ticket-graph.py

@@ -304,6 +304,27 @@ def _compute_dep_graph(ticket_id: str, tracker_dir: str) -> dict[str, Any]:
     # Find direct blockers
     direct_blockers = _find_direct_blockers(ticket_id, tracker_dir)
 
+    # Find children: tickets whose parent_id matches this ticket (8cbf-e13b)
+    children: list[str] = []
+    try:
+        entries = os.listdir(tracker_dir)
+    except OSError:
+        entries = []
+
+    for entry in entries:
+        if entry == ticket_id:
+            continue
+        entry_path = os.path.join(tracker_dir, entry)
+        if not os.path.isdir(entry_path):
+            continue
+        try:
+            child_state = _reduce_ticket(entry_path)
+        except Exception:
+            continue
+        if child_state is not None and isinstance(child_state, dict):
+            if child_state.get("parent_id") == ticket_id:
+                children.append(entry)
+
     # Determine ready_to_work: all direct blockers must be closed/tombstoned
     ready_to_work = True
     for blocker_id in direct_blockers:
@@ -316,6 +337,7 @@ def _compute_dep_graph(ticket_id: str, tracker_dir: str) -> dict[str, Any]:
         "ticket_id": ticket_id,
         "deps": deps,
         "blockers": direct_blockers,
+        "children": children,
         "ready_to_work": ready_to_work,
     }
 

tests/scripts/test_ticket_graph.py

@@ -72,6 +72,8 @@ def _write_ticket(
     tracker_dir: Path,
     ticket_id: str,
     status: str = "open",
+    parent_id: str | None = None,
+    ticket_type: str = "task",
 ) -> Path:
     """Write a minimal ticket directory with a CREATE event and optional STATUS event.
 
@@ -87,9 +89,9 @@ def _write_ticket(
         "author": "Test User",
         "env_id": "00000000-0000-4000-8000-000000000001",
         "data": {
-            "ticket_type": "task",
+            "ticket_type": ticket_type,
             "title": f"Ticket {ticket_id}",
-            "parent_id": None,
+            "parent_id": parent_id,
         },
     }
     with open(ticket_dir / f"1000-create-{ticket_id}-CREATE.json", "w") as f:
@@ -659,3 +661,58 @@ def test_is_active_link_same_second_unlink_sorts_after_link(
         "This indicates same-second UNLINK is sorting before LINK — the timestamp "
         "tie-breaker (event_type_order: LINK=0, UNLINK=1) is missing or incorrect."
     )
+
+
+# ---------------------------------------------------------------------------
+# Parent-child (children) tests — bug 8cbf-e13b
+# ---------------------------------------------------------------------------
+
+
+def test_build_dep_graph_includes_children(graph: ModuleType, tmp_path: Path) -> None:
+    """build_dep_graph must return a 'children' field listing tickets whose
+    parent_id matches the queried ticket.
+
+    Bug 8cbf-e13b: ticket deps returns empty deps for epics with parent-linked
+    children because it only traverses dependency links, not parent_id.
+    """
+    tracker_dir = tmp_path / "tracker"
+    tracker_dir.mkdir()
+
+    # Create an epic
+    _write_ticket(tracker_dir, "epic-001", ticket_type="epic")
+    # Create 3 child stories with parent_id pointing to the epic
+    _write_ticket(tracker_dir, "story-a", parent_id="epic-001", ticket_type="story")
+    _write_ticket(tracker_dir, "story-b", parent_id="epic-001", ticket_type="story")
+    _write_ticket(tracker_dir, "story-c", parent_id="epic-001", ticket_type="story")
+    # Create an unrelated ticket (no parent)
+    _write_ticket(tracker_dir, "unrelated")
+
+    result = graph.build_dep_graph("epic-001", str(tracker_dir))
+
+    assert "children" in result, (
+        "build_dep_graph result is missing 'children' field — "
+        "parent-child relationships are not included in the graph output"
+    )
+    children = sorted(result["children"])
+    assert children == ["story-a", "story-b", "story-c"], (
+        f"Expected 3 children [story-a, story-b, story-c], got {children}"
+    )
+
+
+def test_build_dep_graph_children_empty_when_no_children(
+    graph: ModuleType, tmp_path: Path
+) -> None:
+    """build_dep_graph must return an empty 'children' list when no tickets
+    have parent_id matching the queried ticket."""
+    tracker_dir = tmp_path / "tracker"
+    tracker_dir.mkdir()
+
+    _write_ticket(tracker_dir, "lonely-ticket")
+    _write_ticket(tracker_dir, "other-ticket")
+
+    result = graph.build_dep_graph("lonely-ticket", str(tracker_dir))
+
+    assert "children" in result, "build_dep_graph result missing 'children' field"
+    assert result["children"] == [], (
+        f"Expected empty children, got {result['children']}"
+    )