feat(w21-24kl): batch 15 — RED health guard tests + tk→ticket doc migration

Add RED tests for CLI-native ticket health guards (dso-bdk5): shared
helpers, transition guards (bug-close-reason, open-children), create
guard (closed parent), and link guard (depends_on closed target).

Update 73 documentation and skill files replacing tk command references
with ticket CLI equivalents (dso-hu14). Fix test assertions that checked
for old tk command strings. Remove erroneous .test-index entry for .md
file treated as bash test. Revert accidental tk→ticket change in
error-sweep.sh (executable script, not documentation).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: JoeOakhartNava

.test-index

@@ -15,7 +15,6 @@ plugins/dso/docs/decisions/adr-config-system.md:tests/scripts/test-adr-config-sy
 plugins/dso/docs/workflow-config-schema.json:tests/scripts/test-workflow-config-schema.sh
 plugins/dso/docs/workflows/COMMIT-WORKFLOW.md:tests/scripts/test-commit-workflow-step-1-5.sh
 plugins/dso/docs/workflows/REVIEW-WORKFLOW.md:tests/workflows/test-review-workflow-no-snapshot.sh,tests/workflows/test-review-workflow-size-thresholds.sh
-plugins/dso/docs/workflows/TEST-FAILURE-DISPATCH.md:plugins/dso/skills/sprint/prompts/test-failure-dispatch-protocol.md
 plugins/dso/hooks/dispatchers/pre-bash.sh:tests/hooks/test-pre-bash-dispatcher.sh
 plugins/dso/hooks/dispatchers/pre-edit.sh:tests/hooks/test-pre-edit-write-dispatcher.sh
 plugins/dso/hooks/dispatchers/pre-write.sh:tests/hooks/test-pre-edit-write-dispatcher.sh
@@ -35,7 +34,7 @@ plugins/dso/scripts/merge-ticket-index.py:tests/scripts/test-merge-ticket-index.
 plugins/dso/scripts/pre-commit-format-fix.sh:tests/scripts/test-precommit-format-fix-config-paths.sh
 plugins/dso/scripts/project-detect.sh:tests/scripts/test-ci-generator-integration.sh
 plugins/dso/scripts/ticket-bridge-status.sh:tests/scripts/test_bridge_status.py
-plugins/dso/scripts/ticket-lib.sh:tests/scripts/test_revert_event.py,tests/scripts/test-ticket-lib.sh
+plugins/dso/scripts/ticket-lib.sh:tests/scripts/test_revert_event.py,tests/scripts/test-ticket-lib.sh,tests/scripts/test-ticket-health-guards.sh [test_ticket_read_status_returns_current_status]
 plugins/dso/scripts/ticket-list.sh:tests/scripts/test-ticket-list.sh,tests/scripts/test_bridge_alert_display.py
 plugins/dso/scripts/ticket-revert.sh:tests/scripts/test_revert_event.py
 plugins/dso/scripts/ticket-show.sh:tests/scripts/test-ticket-show.sh,tests/scripts/test_bridge_alert_display.py

.tickets/.sync-state.json

@@ -449,8 +449,8 @@
     "last_synced": "2026-03-19T18:38:35Z",
     "local_hash": "14c516947a151a3db8bdec4010e2fd6e"
   },
-  "last_pull_timestamp": "2026-03-23T17:18:21Z",
-  "last_sync_commit": "0bd13575cbd72c95cc937af7ce2a2082576e9cab",
+  "last_pull_timestamp": "2026-03-23T18:21:21Z",
+  "last_sync_commit": "60ca86de64edef8ef759878b2471445152fe6145",
   "w21-5cqr": {
     "jira_hash": "bce29d76f01c58613ee99cb1dd03920d",
     "jira_key": "DIG-61",

.tickets/dso-1459.md

@@ -0,0 +1,21 @@
+---
+id: dso-1459
+status: open
+deps: [dso-bdk5, dso-sroj]
+links: []
+created: 2026-03-23T17:34:49Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: dso-k4sw
+---
+# Add closed-parent guard to ticket-create.sh
+
+
+## Notes
+
+**2026-03-23T17:35:42Z**
+
+## Description
+Add closed-parent guard to ticket-create.sh. After validating parent_id exists (lines 60-70), add: read parent status via ticket_read_status(). If status='closed', exit 1 with error: 'Cannot create child of closed ticket <parent_id>. Reopen the parent first.'
+

.tickets/dso-1cje.md

@@ -1,6 +1,6 @@
 ---
 id: dso-1cje
-status: in_progress
+status: closed
 deps: [dso-5fbs]
 links: []
 created: 2026-03-23T15:19:45Z

.tickets/dso-9p30.md

@@ -0,0 +1,23 @@
+---
+id: dso-9p30
+status: open
+deps: [dso-bdk5, dso-sroj]
+links: []
+created: 2026-03-23T17:34:49Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: dso-k4sw
+---
+# Add closed-parent guard to ticket-link.sh for depends_on
+
+
+## Notes
+
+**2026-03-23T17:35:42Z**
+
+## Description
+Add closed-parent guard to ticket-link.sh. In _write_link_event(), after validating both tickets exist, add: if relation='depends_on' AND target ticket status is 'closed' (via ticket_read_status on target_id, NOT source_id), exit 1 with error. Other relation types (relates_to, blocks) pass through unchanged.
+
+Note: _write_link_event is called for reciprocal relates_to links — guard must only fire when relation=depends_on.
+

.tickets/dso-b25k.md

@@ -0,0 +1,31 @@
+---
+id: dso-b25k
+status: open
+deps: [dso-jyob, dso-1459, dso-9p30]
+links: []
+created: 2026-03-23T17:34:49Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: dso-k4sw
+---
+# Remove hook_bug_close_guard and delete closed-parent-guard.sh
+
+
+## Notes
+
+**2026-03-23T17:35:42Z**
+
+## Description
+Remove old hook-based guards:
+1. Remove hook_bug_close_guard function from pre-bash-functions.sh (lines 498-583)
+2. Remove its call from dispatchers/pre-bash.sh (line 102)
+3. Remove its entry from the function table comment (line 17)
+4. Delete closed-parent-guard.sh (dead code — not registered in plugin.json)
+5. Delete bug-close-guard.sh (thin wrapper calling hook_bug_close_guard)
+6. Update tests/hooks/test-pre-bash-functions-ticket-guards.sh — remove hook-specific tests
+7. Clean .test-index RED markers for removed test entries
+8. Check plugins/dso/hooks/rollback/settings-pre-task2.json for bug-close-guard references
+
+Pre-T6 verification: confirm that tk close routes through tk cmd_status (writes .tickets/ flat files, NOT ticket-transition.sh). The enforcement gap for tk close is acceptable — tk is being removed in story w21-gy45 (cleanup). Document this in the commit message.
+

.tickets/dso-bdk5.md

@@ -0,0 +1,83 @@
+---
+id: dso-bdk5
+status: in_progress
+deps: []
+links: []
+created: 2026-03-23T17:34:42Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: dso-k4sw
+---
+# RED tests for CLI-native ticket health guards
+
+
+## Notes
+
+**2026-03-23T17:35:13Z**
+
+## Description
+TDD RED task. Write failing tests that assert the post-implementation state BEFORE guard logic is added.
+
+## Files to Create/Edit
+1. tests/scripts/test-ticket-health-guards.sh (CREATE) — tests for shared helpers only:
+   - test_ticket_read_status_returns_current_status
+   - test_ticket_find_open_children_lists_children
+
+2. tests/scripts/test-ticket-transition.sh (EDIT — append RED tests):
+   - test_transition_bug_close_requires_reason
+   - test_transition_bug_close_with_reason_succeeds
+   - test_transition_close_blocked_with_open_children
+
+3. tests/scripts/test-ticket-create.sh (EDIT — append RED test):
+   - test_create_with_closed_parent_blocked
+
+4. tests/scripts/test-ticket-link.sh (EDIT — append RED tests):
+   - test_link_depends_on_closed_target_blocked
+   - test_link_relates_to_closed_target_allowed
+
+## .test-index
+APPEND to existing ticket-lib.sh entry (do NOT replace):
+  plugins/dso/scripts/ticket-lib.sh: <existing entries>, tests/scripts/test-ticket-health-guards.sh [test_ticket_read_status_returns_current_status]
+
+All tests must FAIL (RED) before T2-T5 run.
+
+## ACCEPTANCE CRITERIA
+
+- [ ] tests/scripts/test-ticket-health-guards.sh exists
+  Verify: test -f tests/scripts/test-ticket-health-guards.sh
+- [ ] test-ticket-health-guards.sh contains at least 2 test functions
+  Verify: grep -c "^test_" tests/scripts/test-ticket-health-guards.sh | awk '{exit ($1 < 2)}'
+- [ ] test-ticket-transition.sh contains RED guard tests
+  Verify: grep -q "test_transition_bug_close_requires_reason" tests/scripts/test-ticket-transition.sh
+- [ ] test-ticket-create.sh contains RED guard test
+  Verify: grep -q "test_create_with_closed_parent_blocked" tests/scripts/test-ticket-create.sh
+- [ ] test-ticket-link.sh contains RED guard tests
+  Verify: grep -q "test_link_depends_on_closed_target_blocked" tests/scripts/test-ticket-link.sh
+- [ ] .test-index entry appended for ticket-lib.sh with RED marker
+  Verify: grep -q "test-ticket-health-guards" .test-index
+
+
+**2026-03-23T17:38:45Z**
+
+CHECKPOINT 1/6: Task context loaded ✓
+
+**2026-03-23T17:39:13Z**
+
+CHECKPOINT 2/6: Code patterns understood ✓
+
+**2026-03-23T17:41:10Z**
+
+CHECKPOINT 3/6: Tests written ✓
+
+**2026-03-23T17:41:11Z**
+
+CHECKPOINT 4/6: Implementation complete ✓ (TDD RED task — tests ARE the implementation)
+
+**2026-03-23T17:41:35Z**
+
+CHECKPOINT 5/6: Validation passed ✓ — all 4 files syntactically valid; health-guards runs RED (0 passed, 2 failed)
+
+**2026-03-23T17:41:40Z**
+
+CHECKPOINT 6/6: Done ✓ — All 6 acceptance criteria met. Files created/modified: tests/scripts/test-ticket-health-guards.sh (new), tests/scripts/test-ticket-transition.sh (appended tests 12-14), tests/scripts/test-ticket-create.sh (appended test 7), tests/scripts/test-ticket-link.sh (appended tests 10-11), .test-index (appended RED marker for ticket-lib.sh entry)

.tickets/dso-hu14.md

@@ -1,6 +1,6 @@
 ---
 id: dso-hu14
-status: open
+status: in_progress
 deps: [dso-1cje, dso-yv90]
 links: []
 created: 2026-03-23T15:20:45Z
@@ -91,3 +91,38 @@ After all documentation updates complete:
 5. Test suite:
    bash tests/run-all.sh
 
+## ACCEPTANCE CRITERIA
+
+- [ ] No enumerable tk refs remain in skills/docs/CLAUDE.md
+  Verify: { grep -rn '\btk show\b\|\btk create\b\|\btk close\b\|\btk add-note\b\|\btk status\b\|\btk transition\b\|\btk dep tree\b' plugins/dso/skills/ plugins/dso/docs/ CLAUDE.md; test $? -ne 0; }
+- [ ] All surviving tk refs are tk-wrapper-only commands
+  Verify: grep -rn '\btk\b' plugins/dso/skills/ plugins/dso/docs/ CLAUDE.md | grep -vE 'tk sync|tk ready|tk blocked|tk dep |tk wrapper|tk CLI|tk commands|the tk|using tk' | head -1 | { read line; test -z "$line"; }
+- [ ] Bash syntax validation passes
+  Verify: bash -n plugins/dso/hooks/lib/pre-bash-functions.sh
+
+
+## Notes
+
+**2026-03-23T17:38:49Z**
+
+CHECKPOINT 1/6: Task context loaded ✓
+
+**2026-03-23T17:45:02Z**
+
+CHECKPOINT 2/6: Code patterns understood ✓
+
+**2026-03-23T17:45:06Z**
+
+CHECKPOINT 3/6: Tests written (none required) ✓
+
+**2026-03-23T17:58:40Z**
+
+CHECKPOINT 4/6: Implementation complete ✓
+
+**2026-03-23T18:03:36Z**
+
+CHECKPOINT 5/6: Validation passed ✓ — AC1: no banned tk refs, AC2: surviving refs are wrapper-only, AC3: bash syntax OK, AC4: python syntax OK, AC5: test suite passes (pre-existing failures unchanged)
+
+**2026-03-23T18:03:59Z**
+
+CHECKPOINT 6/6: Done ✓

.tickets/dso-hx5n.md

@@ -0,0 +1,18 @@
+---
+id: dso-hx5n
+status: open
+deps: []
+links: []
+created: 2026-03-23T18:04:16Z
+type: task
+priority: 3
+assignee: Joe Oakhart
+---
+# Update hooks and scripts to use ticket CLI commands instead of tk commands
+
+
+## Notes
+
+**2026-03-23T18:04:29Z**
+
+Discovered while implementing dso-hu14 (docs/CLAUDE.md tk reference update). Files in plugins/dso/hooks/ and plugins/dso/scripts/ still use banned tk commands: closed-parent-guard.sh uses 'tk status', classify-task.sh uses 'tk show', dedup-tickets.sh uses 'tk close', issue-quality-check.sh uses 'tk add-note', issue-batch.sh and sprint-next-batch.sh use 'tk show', release-debug-lock.sh uses 'tk show'. These are outside the scope of dso-hu14. Requires coordinated update with hook behavioral changes per dso-yv90.

.tickets/dso-jyob.md

@@ -0,0 +1,29 @@
+---
+id: dso-jyob
+status: open
+deps: [dso-bdk5, dso-sroj]
+links: []
+created: 2026-03-23T17:34:49Z
+type: task
+priority: 1
+assignee: Joe Oakhart
+parent: dso-k4sw
+---
+# Add bug-close-reason and open-children guards to ticket-transition.sh
+
+
+## Notes
+
+**2026-03-23T17:35:42Z**
+
+## Description
+Add guard logic to ticket-transition.sh. CRITICAL: guard logic must run INSIDE the Python flock block (lines 118-197), after reading state via the reducer but before building the STATUS event JSON. This matches the existing optimistic concurrency pattern.
+
+When target_status='closed':
+1. Read ticket type from reducer state. If type='bug', require --reason flag with 'Fixed:' or 'Escalated to user:' prefix. Exit 1 with instructive error if missing.
+2. Call ticket_find_open_children. If any open children, exit 1 listing them with instruction to close children first.
+
+Shell must parse --reason from remaining args before passing to Python block as additional sys.argv.
+
+Also update plugins/dso/docs/ticket-cli-reference.md with --reason flag documentation.
+