fix: test isolation anti-pattern + tk create double-dash parsing (w21-ni6d, w21-wlhw, dso-3e30) (merge worktree-20260320-130729)

Author: JoeOakhartNava

.tickets/.index.json

@@ -27,7 +27,7 @@
   "dso-094a": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "fix: agent-batch-lifecycle.sh cleanup-discoveries crashes \u2014 get_artifacts_dir not found when CLAUDE_PLUGIN_ROOT points to main repo instead of plugin dir",
     "type": "bug"
   },
@@ -107,7 +107,7 @@
   "dso-2xqd": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "fix: sprint skill Phase 4 references scripts/worktree-sync-from-main.sh instead of plugins/dso/scripts/worktree-sync-from-main.sh",
     "type": "bug"
   },
@@ -121,7 +121,7 @@
   "dso-3e30": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "in_progress",
     "title": "Bug: tk create -d interprets double-dash in description text as option flags",
     "type": "bug"
   },
@@ -221,14 +221,14 @@
   "dso-5syi": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "Fix: dso shim resolves scripts from stale /scripts/ path \u2014 skip-review-check.sh and capture-review-diff.sh not found during commit workflow",
     "type": "bug"
   },
   "dso-62u0": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "fix: merge-to-main.sh sync phase fails when .tickets/.index.json has uncommitted local changes",
     "type": "bug"
   },
@@ -284,6 +284,13 @@
     "title": "Incorporate the brainstorm tell me more loop into using lockpicks",
     "type": "epic"
   },
+  "dso-9xnr": {
+    "deps": [],
+    "priority": 1,
+    "status": "open",
+    "title": "Project Health Restoration (2026-03-20)",
+    "type": "epic"
+  },
   "dso-9zsh": {
     "deps": [],
     "priority": 2,
@@ -447,7 +454,7 @@
   "dso-fqxu": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "fix: compute-diff-hash.sh hash mismatch when untracked temp test fixtures exist during review",
     "type": "bug"
   },
@@ -482,7 +489,7 @@
   "dso-g8cz": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "fix: compute-diff-hash.sh is not staging-invariant for new (untracked\u2192staged) files",
     "type": "bug"
   },
@@ -510,17 +517,31 @@
     "title": "Fix: qualify-skill-refs.sh multi-segment URL lookbehind gap \u2014 checker strips full URLs but fixer only checks :// prefix",
     "type": "bug"
   },
+  "dso-gjww": {
+    "deps": [],
+    "priority": 4,
+    "status": "open",
+    "title": "validate.sh: _test_state_already_passed accepts state files with missing command_hash",
+    "type": "bug"
+  },
   "dso-gkct": {
     "deps": [],
     "priority": 2,
     "status": "open",
     "title": "Implementation planning tradeoffs",
     "type": "epic"
   },
+  "dso-go0x": {
+    "deps": [],
+    "priority": 4,
+    "status": "open",
+    "title": "validate.sh: sha256sum fallback chain uses inconsistent output post-processing",
+    "type": "bug"
+  },
   "dso-h04l": {
     "deps": [],
     "priority": 0,
-    "status": "closed",
+    "status": "in_progress",
     "title": "[LOCK] debug-everything",
     "type": "task"
   },
@@ -571,7 +592,7 @@
   "dso-jauq": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "fix: agent-batch-lifecycle.sh cleanup-discoveries crashes \u2014 get_artifacts_dir not found when CLAUDE_PLUGIN_ROOT points to main repo instead of plugin dir",
     "type": "bug"
   },
@@ -613,7 +634,7 @@
   "dso-kv4p": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "fix: merge-to-main.sh push phase fails with retry_with_backoff: command not found",
     "type": "bug"
   },
@@ -651,6 +672,13 @@
     "title": "Bug: tk sync windowed pull uses UTC but Jira reads JQL datetimes as user-local timezone",
     "type": "bug"
   },
+  "dso-lm92": {
+    "deps": [],
+    "priority": 3,
+    "status": "open",
+    "title": "record-review.sh CHANGED_FILES overlap check includes untracked files that may not be reviewed",
+    "type": "bug"
+  },
   "dso-lqyw": {
     "deps": [],
     "priority": 2,
@@ -695,6 +723,13 @@
     "title": "RED: Write failing tests for ci.workflow_name fallback in merge-to-main.sh",
     "type": "task"
   },
+  "dso-ogh7": {
+    "deps": [],
+    "priority": 4,
+    "status": "open",
+    "title": "Fix: deduplicate FN_BODY_9 extraction in test-merge-to-main-qt4u.sh test 9",
+    "type": "bug"
+  },
   "dso-opue": {
     "deps": [
       "dso-s6kt"
@@ -704,6 +739,13 @@
     "title": "Update read-config.sh to resolve from .claude/dso-config.conf + move config file",
     "type": "task"
   },
+  "dso-or3g": {
+    "deps": [],
+    "priority": 2,
+    "status": "open",
+    "title": "Bug: collect-discoveries.sh crashes with get_artifacts_dir not found when CLAUDE_PLUGIN_ROOT is wrong",
+    "type": "bug"
+  },
   "dso-ozsx": {
     "deps": [
       "dso-o24g",
@@ -773,6 +815,13 @@
     "title": "As a developer setting up DSO, the setup creates .claude/dso-config.conf",
     "type": "story"
   },
+  "dso-qlgq": {
+    "deps": [],
+    "priority": 2,
+    "status": "open",
+    "title": "validate-phase.sh runs tests directly without test-batched.sh \u2014 same timeout anti-pattern as w21-ae0s",
+    "type": "bug"
+  },
   "dso-qo0x": {
     "deps": [],
     "priority": 2,
@@ -783,7 +832,7 @@
   "dso-qt4u": {
     "deps": [],
     "priority": 1,
-    "status": "open",
+    "status": "closed",
     "title": "Bug: merge-to-main.sh fails on archive rename/delete conflicts and doesn't support agent-driven conflict resolution",
     "type": "bug"
   },
@@ -861,6 +910,13 @@
     "title": "Research and investigation in pre-planning or brainstorm",
     "type": "epic"
   },
+  "dso-t2wb": {
+    "deps": [],
+    "priority": 4,
+    "status": "open",
+    "title": "test-merge-to-main: sed sentinel range fragile to future refactoring",
+    "type": "bug"
+  },
   "dso-t4k8": {
     "deps": [],
     "priority": 1,
@@ -975,6 +1031,20 @@
     "title": "Untitled",
     "type": "task"
   },
+  "dso-w20r": {
+    "deps": [],
+    "priority": 4,
+    "status": "open",
+    "title": "validate.sh: comment says do NOT use run_with_timeout but code does use it",
+    "type": "bug"
+  },
+  "dso-w7bs": {
+    "deps": [],
+    "priority": 4,
+    "status": "open",
+    "title": "Fix: assert pending state file content in test_validate_exits_2_on_partial_tests integration test",
+    "type": "bug"
+  },
   "dso-wmjr": {
     "deps": [],
     "priority": 2,
@@ -1234,7 +1304,7 @@
   "w21-9k4z": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "Recurring tool error: command_exit_nonzero (56 occurrences)",
     "type": "bug"
   },
@@ -1248,7 +1318,7 @@
   "w21-ae0s": {
     "deps": [],
     "priority": 1,
-    "status": "open",
+    "status": "closed",
     "title": "Validation gate times out on projects with >50s test suites \u2014 incorporate test-batched or split validate.sh",
     "type": "bug"
   },
@@ -1457,9 +1527,9 @@
   "w21-ni6d": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "test-jq-to-parse-json-field.sh uses real REPO_ROOT for cascade STATE_DIR \u2014 same isolation anti-pattern as dso-b934",
-    "type": "task"
+    "type": "bug"
   },
   "w21-njch": {
     "deps": [
@@ -1628,9 +1698,9 @@
   "w21-wlhw": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "test-pre-edit-write-dispatcher.sh uses real REPO_ROOT for cascade STATE_DIR \u2014 same isolation anti-pattern as dso-b934",
-    "type": "task"
+    "type": "bug"
   },
   "w21-xlaw": {
     "deps": [
@@ -1644,7 +1714,7 @@
   "w21-yzln": {
     "deps": [],
     "priority": 2,
-    "status": "open",
+    "status": "closed",
     "title": "Recurring tool error: command_exit_nonzero (64 occurrences)",
     "type": "bug"
   },

.tickets/archive/dso-h04l.md

@@ -1,6 +1,6 @@
 ---
 id: dso-h04l
-status: closed
+status: in_progress
 deps: []
 links: []
 created: 2026-03-19T23:32:11Z
@@ -47,3 +47,10 @@ Closed: All diagnostics passing, all bugs resolved
 <!-- sync: unsynced -->
 
 CLOSE REASON: Fixed: session complete, all diagnostics passing
+
+<!-- note-id: yi9jzx4d -->
+<!-- timestamp: 2026-03-20T22:07:35Z -->
+<!-- origin: agent -->
+<!-- sync: unsynced -->
+
+Session: 2026-03-20T22:07:35+0000 | Worktree: /Users/joeoakhart/digital-service-orchestra-worktrees/worktree-20260320-130729

.tickets/dso-094a.md

@@ -1,13 +1,37 @@
 ---
 id: dso-094a
-status: open
+status: closed
 deps: []
 links: []
 created: 2026-03-19T18:21:58Z
 type: bug
 priority: 2
 assignee: Joe Oakhart
 jira_key: DIG-65
+parent: dso-9xnr
 ---
 # fix: agent-batch-lifecycle.sh cleanup-discoveries crashes — get_artifacts_dir not found when CLAUDE_PLUGIN_ROOT points to main repo instead of plugin dir
 
+
+## Notes
+
+<!-- note-id: nq3xsv04 -->
+<!-- timestamp: 2026-03-20T23:50:08Z -->
+<!-- origin: agent -->
+<!-- sync: unsynced -->
+
+CLOSE REASON: Fixed: applied defensive plugin.json validation guard to cmd_cleanup_discoveries in plugins/dso/scripts/agent-batch-lifecycle.sh; added regression test in tests/scripts/test-lifecycle-portability.sh
+
+<!-- note-id: r6yaatwq -->
+<!-- timestamp: 2026-03-21T00:11:08Z -->
+<!-- origin: agent -->
+<!-- sync: unsynced -->
+
+Fixed: defensive plugin.json sentinel guard for CLAUDE_PLUGIN_ROOT. Test: test-lifecycle-portability.sh.
+
+<!-- note-id: mzwah33m -->
+<!-- timestamp: 2026-03-21T00:11:09Z -->
+<!-- origin: agent -->
+<!-- sync: unsynced -->
+
+CLOSE REASON: Fixed: agent-batch-lifecycle.sh plugin root resolution (commit 0ab58e5)

.tickets/dso-1aaa.md

@@ -8,6 +8,7 @@ type: bug
 priority: 3
 assignee: Joe Oakhart
 jira_key: DIG-52
+parent: dso-9xnr
 ---
 # Bug: tk create rejects --parent=id flag (only --parent id works)
 

.tickets/dso-2da0.md

@@ -8,6 +8,7 @@ type: bug
 priority: 2
 assignee: Joe Oakhart
 jira_key: DIG-62
+parent: dso-9xnr
 ---
 # Recurring tool error: command_exit_nonzero (56 occurrences)
 

.tickets/dso-2xqd.md

@@ -1,13 +1,23 @@
 ---
 id: dso-2xqd
-status: open
+status: closed
 deps: []
 links: []
 created: 2026-03-19T16:58:24Z
 type: bug
 priority: 2
 assignee: Joe Oakhart
 jira_key: DIG-64
+parent: dso-9xnr
 ---
 # fix: sprint skill Phase 4 references scripts/worktree-sync-from-main.sh instead of plugins/dso/scripts/worktree-sync-from-main.sh
 
+
+## Notes
+
+<!-- note-id: wanmk1ql -->
+<!-- timestamp: 2026-03-21T00:16:51Z -->
+<!-- origin: agent -->
+<!-- sync: unsynced -->
+
+CLOSE REASON: Fixed: commit 3c13efc fixed 32 stale $REPO_ROOT/scripts/ refs across sprint skill and others; test-stale-script-path-refs.sh passes