refactor(tests): remove old-dimension-name absence checks from reviewer test (merge worktree-20260324-164324)

Author: JoeOakhartNava

plugins/dso/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "dso",
-  "version": "0.26.0",
+  "version": "0.26.1",
   "description": "Workflow infrastructure plugin for Claude Code projects",
   "commands": "./commands/",
   "skills": "./skills/",

tests/agents/test-reviewer-dimension-names.sh

@@ -3,11 +3,6 @@
 # Asserts that all code-reviewer agent definitions use the canonical dimension names
 # expected by record-review.sh: hygiene, design, maintainability, correctness, verification.
 #
-# Bug a5cb-5a76: Code reviewer agents use wrong dimension names in reviewer-findings.json.
-# All agents were outputting code_hygiene, object_oriented_design, readability,
-# functionality, testing_coverage — causing record-review.sh to reject findings with
-# "missing score dimension" errors.
-#
 # Usage: bash tests/agents/test-reviewer-dimension-names.sh
 # Returns: exit 0 if all tests pass, exit 1 if any fail
 
@@ -32,25 +27,9 @@ REVIEWER_AGENTS=(
 )
 
 CORRECT_DIMS=("hygiene" "design" "maintainability" "correctness" "verification")
-WRONG_DIMS=("code_hygiene" "object_oriented_design" "readability" "functionality" "testing_coverage")
 
 for agent_file in "${REVIEWER_AGENTS[@]}"; do
     agent_name=$(basename "$agent_file" .md)
-    echo "--- ${agent_name}: no wrong dimension names ---"
-    _snapshot_fail
-
-    _has_wrong=0
-    for wrong_dim in "${WRONG_DIMS[@]}"; do
-        if grep -qF "\"${wrong_dim}\"" "$agent_file"; then
-            _has_wrong=1
-            break
-        fi
-    done
-    assert_eq "${agent_name}: must not use old dimension names (code_hygiene/object_oriented_design/readability/functionality/testing_coverage)" \
-        "0" "$_has_wrong"
-    assert_pass_if_clean "${agent_name}_no_wrong_dims"
-
-    echo ""
     echo "--- ${agent_name}: uses all correct dimension names ---"
     _snapshot_fail