Skip to content

Commit 985a0da

Browse files
feat(be38-5524): GREEN — add artifact review before writing to both skills
Add artifact review sections to both onboarding and architect-foundation SKILL.md files. Present artifacts for approval, show diffs for existing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c2a441f commit 985a0da

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

plugins/dso/skills/architect-foundation/SKILL.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,15 @@ The accepted recommendations from this phase will be materialized into `ARCH_ENF
160160

161161
---
162162

163+
## Phase 2.75: Artifact Review Before Writing
164+
165+
Before generating or writing any enforcement artifact to disk, present the full content for user review and approval.
166+
167+
- **Present each artifact** in a fenced code block so the user can review the complete content before it is written.
168+
- **For files that already exist** (such as `CLAUDE.md` or `ARCH_ENFORCEMENT.md`), show a diff against the existing content rather than presenting full replacement. The existing diff makes it clear which lines are being added, modified, or removed without silently overwriting prior decisions.
169+
- Ask: "Does this look right? Should I write this file?"
170+
- Wait for explicit approval before using the Write tool.
171+
163172
## Phase 3: The Enforcer (Deterministic Guardrails)
164173

165174
Treat "Architecture" as something that can be tested. Generate **Fitness Functions** and **enforcement infrastructure** using tools appropriate for the chosen stack. Architecture enforcement operates at multiple layers — each layer catches violations at a different point in the development cycle.

plugins/dso/skills/onboarding/SKILL.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,15 @@ Any corrections before I finalize this?
299299

300300
Wait for the user to confirm or correct. Update the scratchpad with any corrections.
301301

302+
### Step 1.5: Artifact Review Before Writing
303+
304+
Before writing any artifact to disk, present the full content for user review and approval. Do NOT write files without explicit approval.
305+
306+
- **Present each artifact** in a fenced code block so the user can review the complete content before it is written.
307+
- **For files that already exist** (such as `.claude/dso-config.conf` or `CLAUDE.md`), show a diff against the existing content rather than presenting full replacement. Highlight only the lines being added, changed, or removed so the user can see exactly what will change. Showing the existing diff lets the user verify that no existing configuration is being silently overwritten.
308+
- Ask: "Does this look right? Should I write this file?"
309+
- Wait for explicit approval before using the Write tool.
310+
302311
### Step 2: Write .claude/project-understanding.md
303312

304313
After the user confirms the summary (or provides corrections), write the findings to a structured, human-readable artifact using the Write tool. This file is the lasting record of everything the onboarding conversation learned.

0 commit comments

Comments
 (0)