Skip to content

Commit a503bf1

Browse files
feat(bbba-8154): batch 6 — integrate feasibility reviewer into brainstorm fidelity review
Add conditional 4th reviewer (dso:feasibility-reviewer) to brainstorm Phase 2 Step 3. Triggered by keyword scan for integration signals (third-party CLI, APIs, CI/CD, infrastructure, migrations, auth). Uses case-insensitive semantic matching. Core 3 reviewers unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 83b4d17 commit a503bf1

File tree

1 file changed

+18
-2
lines changed

1 file changed

+18
-2
lines changed

plugins/dso/skills/brainstorm/SKILL.md

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,24 @@ Run the spec through three reviewers **in parallel** using the Task tool. For ea
159159
| Senior Technical Program Manager | [docs/reviewers/agent-clarity.md](docs/reviewers/agent-clarity.md) | `"Agent Clarity"` | `self_contained`, `success_measurable` |
160160
| Senior Product Strategist | [docs/reviewers/scope.md](docs/reviewers/scope.md) | `"Scope"` | `right_sized`, `no_overlap`, `dependency_aware` |
161161
| Senior Product Manager | [docs/reviewers/value.md](docs/reviewers/value.md) | `"Value"` | `user_impact`, `validation_signal` |
162+
| Senior Integration Engineer | `dso:feasibility-reviewer` (dedicated agent) | `"Technical Feasibility"` | `technical_feasibility`, `integration_risk` |
162163

163-
**Pass threshold**: All dimensions must score 4 or above.
164+
### Feasibility Review Trigger
165+
166+
The feasibility reviewer is dispatched only when the epic involves external integrations. Scan the epic spec for integration signal keywords:
167+
168+
- Third-party CLI tools, external APIs/services, CI/CD workflow changes, infrastructure provisioning, data format migrations, authentication/credential flows
169+
170+
1. **Keyword scan**: Scan the epic spec (Context + Success Criteria + Approach) for integration signal keywords using case-insensitive matching. Match on semantic intent, not exact substrings — "calls an external REST API" matches "external APIs/services" even without the exact phrase. If any integration signal is present, dispatch the feasibility reviewer.
171+
2. **Skip**: If no integration signals found, skip the feasibility reviewer. Log: "No external integration signals — skipping feasibility review."
172+
173+
**Note**: The complexity evaluator's `feasibility_review_recommended` field provides the same signal during preplanning (Phase 2.25 Integration Research) where it is available from the sprint classification. In brainstorm, the keyword scan is the primary trigger since the complexity evaluator has not yet run.
174+
175+
The three core reviewers (Agent Clarity, Scope, Value) **always run in parallel**. If feasibility review is triggered, dispatch `subagent_type: "dso:feasibility-reviewer"` (model: sonnet) as a **4th parallel reviewer** alongside the existing 3 — all four run concurrently in a single Task tool batch.
176+
177+
**Pass threshold**: All dimensions must score 4 or above. When the feasibility reviewer runs, `technical_feasibility` and `integration_risk` are also included in the pass threshold check.
178+
179+
**Feasibility critical findings**: If the feasibility reviewer reports any score below 3, add a note to the epic spec recommending a spike task to de-risk the integration before implementation begins.
164180

165181
**Validate the review output:**
166182
```bash
@@ -338,5 +354,5 @@ Skill tool:
338354
| Phase | Goal | Key Activities |
339355
|-------|------|---------------|
340356
| 1: Context + Dialogue | Understand the feature | Load PRD/DESIGN_NOTES, one question at a time, "Tell me more" loop |
341-
| 2: Approach + Spec | Define how and what | Propose 2-3 options, draft spec, run 3-reviewer fidelity check |
357+
| 2: Approach + Spec | Define how and what | Propose 2-3 options, draft spec, run 3-reviewer fidelity check (+ conditional feasibility reviewer for integration epics) |
342358
| 3: Ticket Integration | Create the epic, classify complexity, route to next skill | `.claude/scripts/dso ticket create -t epic`, set deps, validate health, dispatch `dso:complexity-evaluator` agent (haiku, tier_schema=SIMPLE), output classification line + invoke Skill tool in same response: TRIVIAL/MODERATE+High → `/dso:implementation-plan`, MODERATE+Medium → `/dso:preplanning --lightweight`, COMPLEX → `/dso:preplanning` |

0 commit comments

Comments
 (0)