Skip to content

Commit cf27253

Browse files
fix(dso-igoj batch2): fix INSTALL.md redundancy and CLAUDE_PLUGIN_ROOT label accuracy
Post-review fixes: - docs/INSTALL.md: remove Step 3 manual config copy (dso-setup.sh now handles it automatically) - scripts/dso-setup.sh: correct CLAUDE_PLUGIN_ROOT label to 'optional' (dso.plugin_root in workflow-config.conf is the primary mechanism) - .tickets/dso-7h4i.md: track PyYAML check guard for missing python3 (deferred) - .tickets/dso-j48b.md: track INSTALL.md /dso:init clarification (deferred) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent df19a42 commit cf27253

File tree

6 files changed

+53
-11
lines changed

6 files changed

+53
-11
lines changed

.tickets/.index.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,13 @@
121121
"title": "Separate DSO plugin from DSO project",
122122
"type": "epic"
123123
},
124+
"dso-7h4i": {
125+
"deps": [],
126+
"priority": 3,
127+
"status": "open",
128+
"title": "Fix: guard PyYAML check in dso-setup.sh against missing python3",
129+
"type": "bug"
130+
},
124131
"dso-8g5p": {
125132
"deps": [],
126133
"priority": 2,
@@ -233,6 +240,13 @@
233240
"title": "Don't merge to main between batches",
234241
"type": "epic"
235242
},
243+
"dso-j48b": {
244+
"deps": [],
245+
"priority": 3,
246+
"status": "open",
247+
"title": "Fix: add clarifying parenthetical for /dso:init in INSTALL.md Step 5",
248+
"type": "bug"
249+
},
236250
"dso-jl2z": {
237251
"deps": [
238252
"dso-5l1c"

.tickets/.sync-state.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,6 @@
227227
"jira_hash": "b2fcb1e44695c32874c75055e4b8c9e8",
228228
"last_synced": "2026-03-17T18:34:36Z"
229229
},
230-
"last_sync_commit": "acc23406c818a7993280c48070b98f829764cf30",
231-
"last_pull_timestamp": "2026-03-18T07:40:01Z"
230+
"last_sync_commit": "df19a42e3f5307216b254eba09bed22ba058996d",
231+
"last_pull_timestamp": "2026-03-18T07:57:32Z"
232232
}

.tickets/dso-7h4i.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
id: dso-7h4i
3+
status: open
4+
deps: []
5+
links: []
6+
created: 2026-03-18T07:58:53Z
7+
type: bug
8+
priority: 3
9+
assignee: Joe Oakhart
10+
parent: dso-igoj
11+
---
12+
# Fix: guard PyYAML check in dso-setup.sh against missing python3
13+

.tickets/dso-j48b.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
id: dso-j48b
3+
status: open
4+
deps: []
5+
links: []
6+
created: 2026-03-18T07:58:52Z
7+
type: bug
8+
priority: 3
9+
assignee: Joe Oakhart
10+
parent: dso-igoj
11+
---
12+
# Fix: add clarifying parenthetical for /dso:init in INSTALL.md Step 5
13+

docs/INSTALL.md

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,20 +44,22 @@ This script:
4444
The `dso.plugin_root` key tells the shim where the plugin lives when `CLAUDE_PLUGIN_ROOT` is not set as an
4545
environment variable. See [dso.plugin_root in the Configuration Reference](CONFIGURATION-REFERENCE.md#dsoplugin_root).
4646

47-
### Step 3 — Copy example configuration files
47+
### Step 3 — Customize configuration files
4848

49-
Copy the pre-commit config and workflow-config.conf template (skip any that already exist):
49+
`dso-setup.sh` (Step 2) already copies default `.pre-commit-config.yaml` and `.github/workflows/ci.yml`
50+
into your project if they don't exist. This step is about reviewing and customizing them.
51+
52+
If you ran a manual install (without `dso-setup.sh`), copy the defaults first:
5053

5154
```bash
52-
# Pre-commit hook configuration (skip if .pre-commit-config.yaml already exists)
53-
cp $CLAUDE_PLUGIN_ROOT/examples/pre-commit-config.example.yaml .pre-commit-config.yaml
55+
# Pre-commit hook configuration (if not already present)
56+
cp "$CLAUDE_PLUGIN_ROOT/examples/pre-commit-config.example.yaml" .pre-commit-config.yaml
5457

55-
# Workflow config (skip if workflow-config.conf already exists)
56-
cp $CLAUDE_PLUGIN_ROOT/docs/workflow-config.example.conf workflow-config.conf
58+
# CI workflow (if not already present)
59+
mkdir -p .github/workflows
60+
cp "$CLAUDE_PLUGIN_ROOT/examples/ci.example.yml" .github/workflows/ci.yml
5761
```
5862

59-
If `CLAUDE_PLUGIN_ROOT` is not set, replace it with the absolute path to the plugin directory.
60-
6163
Edit `workflow-config.conf` to match your project. All keys are optional except `version` — omitted
6264
keys fall back to stack-detected defaults. See [Configuration Reference](CONFIGURATION-REFERENCE.md).
6365

scripts/dso-setup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ fi
134134

135135
# ── Environment variable guidance ─────────────────────────────────────────────
136136
echo '=== Environment Variables (add to your shell profile) ==='
137-
echo 'CLAUDE_PLUGIN_ROOT= # Required: DSO plugin path'
137+
echo 'CLAUDE_PLUGIN_ROOT= # Optional: overrides dso.plugin_root from workflow-config.conf'
138138
echo 'JIRA_URL=https://your-org.atlassian.net # Required for Jira sync'
139139
echo 'JIRA_USER=you@example.com # Required for Jira sync'
140140
echo 'JIRA_API_TOKEN=... # Required for Jira sync'

0 commit comments

Comments
 (0)