chore(w21-mzof): create epic + implementation tasks for cross-component contract detection (merge worktree-20260319-180957)

Author: JoeOakhartNava

.tickets/w21-kp0l.md

@@ -0,0 +1,47 @@
+---
+id: w21-kp0l
+status: open
+deps: [w21-mzof, w21-tcti]
+links: []
+created: 2026-03-20T02:38:59Z
+type: task
+priority: 2
+assignee: Joe Oakhart
+parent: w21-mzof
+---
+# GREEN: Add contract detection pass to implementation-plan SKILL.md
+
+## Description
+Edit plugins/dso/skills/implementation-plan/SKILL.md. Insert a '### Contract Detection Pass' subsection in Step 3, after the 'Documentation Updates' subsection and before the '---' separator for Step 4. Contents:
+
+1. When to run: After file impact analysis in Step 3, before finalizing the task list
+2. V1 detection heuristic — two patterns:
+   (a) Signal emit/parse pairs: file impact includes a component producing structured output (STATUS:, RESULT:, REPORT: markers) AND another parsing it
+   (b) Orchestrator/sub-agent report schemas: file impact includes a skill dispatching sub-agents AND defining expected return format
+3. Contract artifact: Create under plugins/dso/docs/contracts/<interface-name>.md with sections: Signal Name, Emitter, Parser, Fields, Example
+4. Cross-story deduplication: Before creating contract task, run tk dep tree <parent-epic-id>, check if existing task title contains 'Contract:' and same interface name. If found, wire as dependent. If not, create.
+5. Contract task as first dependency: blocks all implementation tasks touching either side of the interface
+
+TDD: Task w21-tcti RED tests turn GREEN after this implementation.
+
+## File Impact
+- plugins/dso/skills/implementation-plan/SKILL.md (modify — add Contract Detection Pass section)
+
+## ACCEPTANCE CRITERIA
+- [ ] bash tests/run-all.sh passes (exit 0)
+  Verify: bash tests/run-all.sh
+- [ ] SKILL.md contains contract detection heading
+  Verify: grep -q '### Contract Detection Pass' plugins/dso/skills/implementation-plan/SKILL.md
+- [ ] Contains emit/parse pattern description
+  Verify: grep -q 'emit' plugins/dso/skills/implementation-plan/SKILL.md && grep -q 'parse' plugins/dso/skills/implementation-plan/SKILL.md
+- [ ] Contains orchestrator/sub-agent pattern
+  Verify: grep -qE '(orchestrator.*sub-agent|sub-agent.*orchestrator)' plugins/dso/skills/implementation-plan/SKILL.md
+- [ ] Contains deduplication via tk dep tree
+  Verify: grep -q 'tk dep tree' plugins/dso/skills/implementation-plan/SKILL.md && grep -qE '(existing contract|Contract:)' plugins/dso/skills/implementation-plan/SKILL.md
+- [ ] Contains artifact path
+  Verify: grep -q 'plugins/dso/docs/contracts/' plugins/dso/skills/implementation-plan/SKILL.md
+- [ ] All 5 RED tests pass (GREEN)
+  Verify: bash tests/scripts/test-implementation-plan-contracts.sh 2>&1 | grep -q 'RESULT: PASS'
+- [ ] All 5 individually pass
+  Verify: test $(bash tests/scripts/test-implementation-plan-contracts.sh 2>&1 | grep -c 'PASS:') -ge 5
+

.tickets/w21-mzof.md

@@ -0,0 +1,33 @@
+---
+id: w21-mzof
+status: open
+deps: []
+links: []
+created: 2026-03-20T02:31:49Z
+type: epic
+priority: 2
+assignee: Joe Oakhart
+---
+# Cross-component contract detection in /dso:implementation-plan
+
+
+## Notes
+
+**2026-03-20T02:31:58Z**
+
+
+## Context
+When a DSO developer runs /dso:sprint on an epic that touches multiple components needing a shared interface (signal formats, prompt schemas, report structures), the current planning flow doesn't surface these contracts explicitly. They get discovered during code review when the two sides don't match — as happened with the fix-bug/debug-everything ESCALATION_REPORT contract in epic w21-25vk, where fix-bug emitted a signal format that debug-everything couldn't parse, requiring 3 review resolution cycles to align. By detecting cross-component contracts during /dso:implementation-plan and creating a contract definition task that other tasks depend on, developers avoid wasting review cycles on interface alignment that should have been resolved at planning time.
+
+## Success Criteria
+1. When /dso:implementation-plan detects that a story's file impact spans two or more components that exchange structured data (one emits, the other parses), it creates a contract definition task as the first task in the dependency chain — the contract task produces a concrete artifact (schema definition in a markdown or JSON file under plugins/dso/docs/contracts/ or plugins/dso/skills/shared/) that downstream implementation tasks reference in their acceptance criteria
+2. The detection heuristic covers two v1 contract patterns: (a) signal emit/parse pairs — where one skill/script produces a structured output format (e.g., STATUS:, ESCALATION_REPORT:) that another skill/script parses, and (b) orchestrator/sub-agent report schemas — where a sub-agent returns structured data the orchestrator must interpret. Additional patterns (shared prompt placeholders, cross-skill dispatch formats) are deferred to follow-on work
+3. Cross-story contract deduplication: when /dso:implementation-plan runs on a story, it checks existing tasks under the parent epic (tk dep tree <epic-id>) for a contract task covering the same interface before creating a new one — if found, it wires the new story's tasks as dependents of the existing contract task via tk dep
+4. After delivery, run /dso:sprint on the next 3 epics that involve cross-component changes and track whether review resolution cycles for contract-related findings decrease — target: 0 contract-mismatch findings requiring review fix/defend cycles (baseline: 3 cycles on w21-25vk)
+
+## Dependencies
+None (file-impact analysis already exists in /dso:implementation-plan)
+
+## Approach
+Enhance /dso:implementation-plan's task generation step to include a contract detection pass after file impact analysis. When the file impact list contains components on both sides of an interface boundary, generate a contract definition task whose deliverable is the shared artifact. Use tk dep tree to check for existing contract tasks before creating duplicates.
+

.tickets/w21-tcti.md

@@ -0,0 +1,41 @@
+---
+id: w21-tcti
+status: open
+deps: [w21-mzof]
+links: []
+created: 2026-03-20T02:38:54Z
+type: task
+priority: 2
+assignee: Joe Oakhart
+parent: w21-mzof
+---
+# RED: Tests for contract detection in implementation-plan SKILL.md
+
+## Description
+Create tests/scripts/test-implementation-plan-contracts.sh with 5 test functions following project conventions (set -uo pipefail, PASS/FAIL counters, summary block):
+
+1. test_contract_detection_section_exists — grep SKILL.md for '### Contract Detection Pass' heading
+2. test_contract_emit_parse_pattern — grep for emit/parse signal pair detection (both 'emit' and 'parse' in contract detection section)
+3. test_contract_orchestrator_subagent_pattern — grep for orchestrator/sub-agent report schema pattern
+4. test_contract_deduplication — grep for 'tk dep tree' AND 'existing contract' or 'Contract:' in contract detection section
+5. test_contract_task_template — grep for contract task template with 'plugins/dso/docs/contracts/' artifact path
+
+All 5 FAIL (RED). Test harness uses project-standard FAIL: prefix, PASS: prefix, RESULT: PASS/FAIL summary.
+
+TDD: These ARE the RED tests.
+
+## File Impact
+- tests/scripts/test-implementation-plan-contracts.sh (create)
+
+## ACCEPTANCE CRITERIA
+- [ ] bash tests/run-all.sh passes (exit 0)
+  Verify: bash tests/run-all.sh
+- [ ] Test file exists
+  Verify: test -f tests/scripts/test-implementation-plan-contracts.sh
+- [ ] Valid bash syntax
+  Verify: bash -n tests/scripts/test-implementation-plan-contracts.sh
+- [ ] Contains 5 test functions
+  Verify: test $(grep -c 'test_contract_' tests/scripts/test-implementation-plan-contracts.sh) -ge 5
+- [ ] All 5 FAIL (RED)
+  Verify: bash tests/scripts/test-implementation-plan-contracts.sh 2>&1 | grep -c 'FAIL:' | { read c; test "$c" -ge 5; }
+