Merge origin/main into session branch (update from main: PR #693 review-gate fixes)

Author: Test

plugins/dso/agents/ci/code-reviewer-deep-arch.md

@@ -4,7 +4,7 @@ model: opus
 color: red
 description: "Deep-tier architectural reviewer (Opus): synthesizes specialist findings, assesses systemic risk, produces unified verdict across all dimensions."
 ---
-<!-- content-hash: adcef9f59454d41eeee31b7ba28410570e4fb07805dd60f00e8f9186dddc46ce -->
+<!-- content-hash: c9f9da0cec21e8b95eb5a010b2f12ad4f973659cecd5829dfd97e5ab9f58053a -->
 <!-- generated by build-review-agents.sh — do not edit manually -->
 
 # Code Reviewer — Universal Base Guidance
@@ -185,12 +185,13 @@ Produce a JSON object with this EXACT schema (for writing to disk in Step 3).
 
 VIOLATIONS CAUSE RE-DISPATCH.
 
-REQUIRED: EXACTLY two top-level keys:
+REQUIRED top-level keys: `"findings"`, `"summary"`, and `"review_completed"` (plus optional `escalate_review`):
 - `"findings"` — array of finding objects; each `"file"` field MUST reference a file present in the diff being reviewed
 - `"summary"` — 2–3 sentence assessment
+- `"review_completed"` — boolean; ALWAYS set to `true`. This affirms a full review pass completed; it is REQUIRED so an empty `findings` list is distinguishable from a truncated/garbled payload. A clean (no-issues) review with `"findings": []` is REJECTED unless `"review_completed": true` is present (bug 1b76).
 
 Do NOT include a scores key.
-Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) —
+Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) and review_completed —
 the validator will reject unrecognized keys and force a re-dispatch.
 
 **`category` MUST be EXACTLY one of: `correctness`, `design`, `hygiene`, `maintainability`, `verification` — do NOT invent new categories like "code_smell" or "missing_test_coverage". The validator (validate-review-output.sh) hard-rejects any other value and the correction loop only has a single retry budget; off-enum categories burn that budget.**
@@ -211,10 +212,13 @@ the validator will reject unrecognized keys and force a re-dispatch.
     }
   ],
   "summary": "2-3 sentence assessment",
+  "review_completed": true,
   "escalate_review": [{"finding_index": 0, "reason": "uncertain whether this is important or critical"}]
 }
 ```
 
+**review_completed** — required boolean; always `true`. Affirms a full review pass completed; required so an empty findings list is distinguishable from a truncated payload (bug 1b76). The validator rejects a `"findings": []` payload that omits `review_completed: true`.
+
 **cited_lines** — required; minimum 1 entry per finding.
 - Accepted: `<path>:<line>` (exact citation) or `~<path>:<line>` (approximate, when exact line is unknown in CI context)
 - Rejected: `~` alone, empty strings, entries without a colon-delimited positive integer line number (e.g., `src/foo.sh` without `:42`)

plugins/dso/agents/ci/code-reviewer-deep-correctness.md

@@ -4,7 +4,7 @@ model: sonnet
 color: red
 description: "Deep-tier correctness specialist (Sonnet A): focused exclusively on correctness — edge cases, error handling, security, efficiency."
 ---
-<!-- content-hash: 159495a841406b6551a779c019239bebe83e5b9ca80cb4f20fae1664d98c1ef2 -->
+<!-- content-hash: c5ad7a8c199e9e6c0ed6306cdcd26232a3347f09de0901474ef638d1bf59b768 -->
 <!-- generated by build-review-agents.sh — do not edit manually -->
 
 # Code Reviewer — Universal Base Guidance
@@ -185,12 +185,13 @@ Produce a JSON object with this EXACT schema (for writing to disk in Step 3).
 
 VIOLATIONS CAUSE RE-DISPATCH.
 
-REQUIRED: EXACTLY two top-level keys:
+REQUIRED top-level keys: `"findings"`, `"summary"`, and `"review_completed"` (plus optional `escalate_review`):
 - `"findings"` — array of finding objects; each `"file"` field MUST reference a file present in the diff being reviewed
 - `"summary"` — 2–3 sentence assessment
+- `"review_completed"` — boolean; ALWAYS set to `true`. This affirms a full review pass completed; it is REQUIRED so an empty `findings` list is distinguishable from a truncated/garbled payload. A clean (no-issues) review with `"findings": []` is REJECTED unless `"review_completed": true` is present (bug 1b76).
 
 Do NOT include a scores key.
-Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) —
+Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) and review_completed —
 the validator will reject unrecognized keys and force a re-dispatch.
 
 **`category` MUST be EXACTLY one of: `correctness`, `design`, `hygiene`, `maintainability`, `verification` — do NOT invent new categories like "code_smell" or "missing_test_coverage". The validator (validate-review-output.sh) hard-rejects any other value and the correction loop only has a single retry budget; off-enum categories burn that budget.**
@@ -211,10 +212,13 @@ the validator will reject unrecognized keys and force a re-dispatch.
     }
   ],
   "summary": "2-3 sentence assessment",
+  "review_completed": true,
   "escalate_review": [{"finding_index": 0, "reason": "uncertain whether this is important or critical"}]
 }
 ```
 
+**review_completed** — required boolean; always `true`. Affirms a full review pass completed; required so an empty findings list is distinguishable from a truncated payload (bug 1b76). The validator rejects a `"findings": []` payload that omits `review_completed: true`.
+
 **cited_lines** — required; minimum 1 entry per finding.
 - Accepted: `<path>:<line>` (exact citation) or `~<path>:<line>` (approximate, when exact line is unknown in CI context)
 - Rejected: `~` alone, empty strings, entries without a colon-delimited positive integer line number (e.g., `src/foo.sh` without `:42`)

plugins/dso/agents/ci/code-reviewer-deep-hygiene.md

@@ -4,7 +4,7 @@ model: sonnet
 color: red
 description: "Deep-tier hygiene/design specialist (Sonnet C): focused on hygiene, design, and maintainability."
 ---
-<!-- content-hash: 07666cef0d313dbbbc839ebc1e3350fabab117d39113ef8d0e9ea22445fac879 -->
+<!-- content-hash: 3e406a750bbc367c8a8bcc79586361e067824db4680136009662ef665f831305 -->
 <!-- generated by build-review-agents.sh — do not edit manually -->
 
 # Code Reviewer — Universal Base Guidance
@@ -185,12 +185,13 @@ Produce a JSON object with this EXACT schema (for writing to disk in Step 3).
 
 VIOLATIONS CAUSE RE-DISPATCH.
 
-REQUIRED: EXACTLY two top-level keys:
+REQUIRED top-level keys: `"findings"`, `"summary"`, and `"review_completed"` (plus optional `escalate_review`):
 - `"findings"` — array of finding objects; each `"file"` field MUST reference a file present in the diff being reviewed
 - `"summary"` — 2–3 sentence assessment
+- `"review_completed"` — boolean; ALWAYS set to `true`. This affirms a full review pass completed; it is REQUIRED so an empty `findings` list is distinguishable from a truncated/garbled payload. A clean (no-issues) review with `"findings": []` is REJECTED unless `"review_completed": true` is present (bug 1b76).
 
 Do NOT include a scores key.
-Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) —
+Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) and review_completed —
 the validator will reject unrecognized keys and force a re-dispatch.
 
 **`category` MUST be EXACTLY one of: `correctness`, `design`, `hygiene`, `maintainability`, `verification` — do NOT invent new categories like "code_smell" or "missing_test_coverage". The validator (validate-review-output.sh) hard-rejects any other value and the correction loop only has a single retry budget; off-enum categories burn that budget.**
@@ -211,10 +212,13 @@ the validator will reject unrecognized keys and force a re-dispatch.
     }
   ],
   "summary": "2-3 sentence assessment",
+  "review_completed": true,
   "escalate_review": [{"finding_index": 0, "reason": "uncertain whether this is important or critical"}]
 }
 ```
 
+**review_completed** — required boolean; always `true`. Affirms a full review pass completed; required so an empty findings list is distinguishable from a truncated payload (bug 1b76). The validator rejects a `"findings": []` payload that omits `review_completed: true`.
+
 **cited_lines** — required; minimum 1 entry per finding.
 - Accepted: `<path>:<line>` (exact citation) or `~<path>:<line>` (approximate, when exact line is unknown in CI context)
 - Rejected: `~` alone, empty strings, entries without a colon-delimited positive integer line number (e.g., `src/foo.sh` without `:42`)

plugins/dso/agents/ci/code-reviewer-deep-verification.md

@@ -4,7 +4,7 @@ model: sonnet
 color: red
 description: "Deep-tier verification specialist (Sonnet B): focused exclusively on verification — test presence, quality, edge case coverage, mock correctness."
 ---
-<!-- content-hash: e5d58915624d676f454c97a42b4623bf76b3e893348537a649f166873ad2a7a3 -->
+<!-- content-hash: 8dc5f71f2b4471a9b78bd87bd22e5ed4f952391cfaa6d6c4036a80662c89a7ed -->
 <!-- generated by build-review-agents.sh — do not edit manually -->
 
 # Code Reviewer — Universal Base Guidance
@@ -185,12 +185,13 @@ Produce a JSON object with this EXACT schema (for writing to disk in Step 3).
 
 VIOLATIONS CAUSE RE-DISPATCH.
 
-REQUIRED: EXACTLY two top-level keys:
+REQUIRED top-level keys: `"findings"`, `"summary"`, and `"review_completed"` (plus optional `escalate_review`):
 - `"findings"` — array of finding objects; each `"file"` field MUST reference a file present in the diff being reviewed
 - `"summary"` — 2–3 sentence assessment
+- `"review_completed"` — boolean; ALWAYS set to `true`. This affirms a full review pass completed; it is REQUIRED so an empty `findings` list is distinguishable from a truncated/garbled payload. A clean (no-issues) review with `"findings": []` is REJECTED unless `"review_completed": true` is present (bug 1b76).
 
 Do NOT include a scores key.
-Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) —
+Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) and review_completed —
 the validator will reject unrecognized keys and force a re-dispatch.
 
 **`category` MUST be EXACTLY one of: `correctness`, `design`, `hygiene`, `maintainability`, `verification` — do NOT invent new categories like "code_smell" or "missing_test_coverage". The validator (validate-review-output.sh) hard-rejects any other value and the correction loop only has a single retry budget; off-enum categories burn that budget.**
@@ -211,10 +212,13 @@ the validator will reject unrecognized keys and force a re-dispatch.
     }
   ],
   "summary": "2-3 sentence assessment",
+  "review_completed": true,
   "escalate_review": [{"finding_index": 0, "reason": "uncertain whether this is important or critical"}]
 }
 ```
 
+**review_completed** — required boolean; always `true`. Affirms a full review pass completed; required so an empty findings list is distinguishable from a truncated payload (bug 1b76). The validator rejects a `"findings": []` payload that omits `review_completed: true`.
+
 **cited_lines** — required; minimum 1 entry per finding.
 - Accepted: `<path>:<line>` (exact citation) or `~<path>:<line>` (approximate, when exact line is unknown in CI context)
 - Rejected: `~` alone, empty strings, entries without a colon-delimited positive integer line number (e.g., `src/foo.sh` without `:42`)

plugins/dso/agents/ci/code-reviewer-light.md

@@ -4,7 +4,7 @@ model: haiku
 color: red
 description: "Light-tier code reviewer: single-pass, highest-signal checklist for fast feedback on low-to-medium-risk changes."
 ---
-<!-- content-hash: 49d70b141a61a3b796dad685cffd67751fe7a8675d0b443bcb7334b982ab71a4 -->
+<!-- content-hash: aad66500e8651f9c77e2f83893abec3fa738fcc05137ecbeceea29fec696e88c -->
 <!-- generated by build-review-agents.sh — do not edit manually -->
 
 # Code Reviewer — Universal Base Guidance
@@ -156,12 +156,13 @@ Produce a JSON object with this EXACT schema (for writing to disk in Step 3).
 
 VIOLATIONS CAUSE RE-DISPATCH.
 
-REQUIRED: EXACTLY two top-level keys:
+REQUIRED top-level keys: `"findings"`, `"summary"`, and `"review_completed"` (plus optional `escalate_review`):
 - `"findings"` — array of finding objects; each `"file"` field MUST reference a file present in the diff being reviewed
 - `"summary"` — 2–3 sentence assessment
+- `"review_completed"` — boolean; ALWAYS set to `true`. This affirms a full review pass completed; it is REQUIRED so an empty `findings` list is distinguishable from a truncated/garbled payload. A clean (no-issues) review with `"findings": []` is REJECTED unless `"review_completed": true` is present (bug 1b76).
 
 Do NOT include a scores key.
-Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) —
+Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) and review_completed —
 the validator will reject unrecognized keys and force a re-dispatch.
 
 **`category` MUST be EXACTLY one of: `correctness`, `design`, `hygiene`, `maintainability`, `verification` — do NOT invent new categories like "code_smell" or "missing_test_coverage". The validator (validate-review-output.sh) hard-rejects any other value and the correction loop only has a single retry budget; off-enum categories burn that budget.**
@@ -182,10 +183,13 @@ the validator will reject unrecognized keys and force a re-dispatch.
     }
   ],
   "summary": "2-3 sentence assessment",
+  "review_completed": true,
   "escalate_review": [{"finding_index": 0, "reason": "uncertain whether this is important or critical"}]
 }
 ```
 
+**review_completed** — required boolean; always `true`. Affirms a full review pass completed; required so an empty findings list is distinguishable from a truncated payload (bug 1b76). The validator rejects a `"findings": []` payload that omits `review_completed: true`.
+
 **cited_lines** — required; minimum 1 entry per finding.
 - Accepted: `<path>:<line>` (exact citation) or `~<path>:<line>` (approximate, when exact line is unknown in CI context)
 - Rejected: `~` alone, empty strings, entries without a colon-delimited positive integer line number (e.g., `src/foo.sh` without `:42`)

plugins/dso/agents/ci/code-reviewer-performance.md

@@ -4,7 +4,7 @@ model: opus
 color: red
 description: "Performance reviewer (Opus): calibrated performance analysis with bright-line severity rules for scaling failures and resource exhaustion."
 ---
-<!-- content-hash: 34fd44e818aadf2d4c6bb1d4ec9e7cc9b1b0ca040d5ed010d525a1b4319b8521 -->
+<!-- content-hash: 5817204edc8d8b8827de5b898c39ca9f4db4c81c0a9b57d143eca45a660757a3 -->
 <!-- generated by build-review-agents.sh — do not edit manually -->
 
 # Code Reviewer — Universal Base Guidance
@@ -185,12 +185,13 @@ Produce a JSON object with this EXACT schema (for writing to disk in Step 3).
 
 VIOLATIONS CAUSE RE-DISPATCH.
 
-REQUIRED: EXACTLY two top-level keys:
+REQUIRED top-level keys: `"findings"`, `"summary"`, and `"review_completed"` (plus optional `escalate_review`):
 - `"findings"` — array of finding objects; each `"file"` field MUST reference a file present in the diff being reviewed
 - `"summary"` — 2–3 sentence assessment
+- `"review_completed"` — boolean; ALWAYS set to `true`. This affirms a full review pass completed; it is REQUIRED so an empty `findings` list is distinguishable from a truncated/garbled payload. A clean (no-issues) review with `"findings": []` is REJECTED unless `"review_completed": true` is present (bug 1b76).
 
 Do NOT include a scores key.
-Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) —
+Do NOT add "schema_version", "review_result", "id", "review_date", "REVIEWER_HASH", or any other key except escalate_review (see Escalation section below) and review_completed —
 the validator will reject unrecognized keys and force a re-dispatch.
 
 **`category` MUST be EXACTLY one of: `correctness`, `design`, `hygiene`, `maintainability`, `verification` — do NOT invent new categories like "code_smell" or "missing_test_coverage". The validator (validate-review-output.sh) hard-rejects any other value and the correction loop only has a single retry budget; off-enum categories burn that budget.**
@@ -211,10 +212,13 @@ the validator will reject unrecognized keys and force a re-dispatch.
     }
   ],
   "summary": "2-3 sentence assessment",
+  "review_completed": true,
   "escalate_review": [{"finding_index": 0, "reason": "uncertain whether this is important or critical"}]
 }
 ```
 
+**review_completed** — required boolean; always `true`. Affirms a full review pass completed; required so an empty findings list is distinguishable from a truncated payload (bug 1b76). The validator rejects a `"findings": []` payload that omits `review_completed: true`.
+
 **cited_lines** — required; minimum 1 entry per finding.
 - Accepted: `<path>:<line>` (exact citation) or `~<path>:<line>` (approximate, when exact line is unknown in CI context)
 - Rejected: `~` alone, empty strings, entries without a colon-delimited positive integer line number (e.g., `src/foo.sh` without `:42`)