Update Determinations reason to plural (#3)

* Change determinations reason to array

Author: baonguyenNava

reporting-app/app/models/certification_case.rb

@@ -73,18 +73,17 @@ def determine_ex_parte_exemption(eligibility_fact)
         self.exemption_request_approval_status_updated_at = Time.current
         self.close!
 
-        # TODO: Extract to Fact class that inherits from Strata::RulesEngine::Fact
-        true_reasons = eligibility_fact.reasons.select { |reason| reason.value }.map(&:name)
-
         reasons = {
-          age_under_19_exempt: true_reasons.include?(:age_under_19),
-          age_over_65_exempt: true_reasons.include?(:age_over_65)
+          age_under_19: :age_under_19_exempt,
+          age_over_65: :age_over_65_exempt
         }
 
+        # TODO: Extract to Fact class that inherits from Strata::RulesEngine::Fact
+        true_reasons = eligibility_fact.reasons.select { |reason| reason.value }.map(&:name).map { |name| reasons[name] }
         certification = Certification.find(self.certification_id)
         certification.record_determination!(
           decision_method: :automated,
-          reason: reasons.key(true),
+          reasons: true_reasons,
           outcome: :exempt,
           determination_data: eligibility_fact.reasons.to_json,
           determined_at: certification.certification_requirements.certification_date

reporting-app/app/models/concerns/determinable.rb

@@ -17,7 +17,7 @@
 # @example Record an automated determination
 #   record.record_determination!(
 #     decision_method: :automated,
-#     reason: "pregnant_member",
+#     reasons: ["pregnant_member"],
 #     outcome: :automated_exemption,
 #     determination_data: rules_engine.evaluate(:pregnant_member).reasons,
 #     determined_at: Time.current
@@ -26,7 +26,7 @@
 # @example Record a staff-reviewed determination
 #   record.record_determination!(
 #     decision_method: :staff_review,
-#     reason: "requirements_verification",
+#     reasons: ["requirements_verification"],
 #     outcome: :requirements_met,
 #     determination_data: {verified_fields: [:income, :address]},
 #     determined_at: Time.current,

reporting-app/app/models/determination.rb

@@ -4,8 +4,8 @@
 #
 # By default, Strata::Determination provides:
 # - A polymorphic +subject+ association to any aggregate root
-# - Validations for all required fields (+decision_method+, +reason+, +outcome+, +determination_data+, +determined_at+)
-# - Query scopes for filtering by subject, decision method, reason, outcome, user, and time windows
+# - Validations for all required fields (+decision_method+, +reasons+, +outcome+, +determination_data+, +determined_at+)
+# - Query scopes for filtering by subject, decision method, reasons, outcome, user, and time windows
 # - Support for automated, staff-reviewed, and attested determinations
 #
 # Extend this class to add:
@@ -19,7 +19,7 @@
 #     enum decision_method: { automated: "automated", staff_review: "staff_review", attestation: "attestation" }
 #     enum outcome: { approved: "approved", denied: "denied", pending: "pending" }
 #
-#     validates :reason, inclusion: { in: %w(pregnant_member incarcerated other) }
+#     validates :reasons, presence: true, inclusion: { in: %w(pregnant_member incarcerated other) }
 #   end
 #
 # @example Query determinations for a specific subject
@@ -31,12 +31,15 @@
 # @see Strata::Determinable for the +record_determination!+ method to use in models
 #
 class Determination < Strata::Determination
+  VALID_REASONS = %w[
+    age_under_19_exempt
+    age_over_65_exempt
+    pregnancy_exempt
+    american_indian_alaska_native_exempt
+  ].freeze
+
   enum :decision_method, { automated: "automated", manual: "manual" }
-  enum :reason, {
-    age_under_19_exempt: "age_under_19_exempt",
-    age_over_65_exempt: "age_over_65_exempt",
-    pregnancy_exempt: "pregnancy_exempt",
-    american_indian_alaska_native_exempt: "american_indian_alaska_native_exempt"
-  }
   enum :outcome, { compliant: "compliant", exempt: "exempt" }
+
+  validates :reasons, presence: true, inclusion: { in: VALID_REASONS }
 end

reporting-app/config/locales/models/determination/en.yml

@@ -0,0 +1,8 @@
+en:
+  activerecord:
+    errors:
+      models:
+        determination:
+          attributes:
+            reasons:
+              inclusion: "must contain only valid reason values"

reporting-app/db/migrate/20251031214909_update_determination_reasons.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+class UpdateDeterminationReasons < ActiveRecord::Migration[7.2]
+  def up
+    # Add the new reasons column as an array of strings
+    add_column :strata_determinations, :reasons, :string, array: true, default: [], null: false
+
+    # Copy existing reason values into reasons array
+    execute <<~SQL
+      UPDATE strata_determinations
+      SET reasons = ARRAY[reason]
+      WHERE reason IS NOT NULL AND reason != ''
+    SQL
+
+    # Remove the old reason column
+    remove_column :strata_determinations, :reason
+  end
+
+  def down
+    # Add back the old reason column
+    add_column :strata_determinations, :reason, :string, null: false, default: ""
+
+    # Copy first reason from array back to reason column
+    execute <<~SQL
+      UPDATE strata_determinations
+      SET reason = reasons[1]
+      WHERE array_length(reasons, 1) >= 1
+    SQL
+
+    # Remove the reasons column
+    remove_column :strata_determinations, :reasons
+  end
+end

reporting-app/db/schema.rb

@@ -4,7 +4,7 @@
   factory :determination do
     subject { association :certification }
     decision_method { 'automated' }
-    reason { 'age_under_19_exempt' }
+    reasons { [ 'age_under_19_exempt' ] }
     outcome { 'exempt' }
     determination_data { { reasons: { rule: 'passed' } } }
     determined_at { Time.current }

reporting-app/spec/factories/determination_factory.rb

@@ -204,7 +204,7 @@
         determination = Determination.first
 
         expect(determination.decision_method).to eq("automated")
-        expect(determination.reason).to eq("age_under_19_exempt")
+        expect(determination.reasons).to include("age_under_19_exempt")
         expect(determination.outcome).to eq("exempt")
         expect(determination.determined_at).to be_present
         expect(determination.determination_data).to eq(eligibility_fact.reasons.to_json)

reporting-app/spec/models/certification_case_spec.rb

@@ -10,21 +10,57 @@
       end
     end
 
-    describe 'reason' do
-      it 'defines the reason enum with correct values' do
+    describe 'outcome' do
+      it 'defines the outcome enum with correct values' do
+        expect(described_class.outcomes.keys).to contain_exactly('compliant', 'exempt')
+      end
+    end
+  end
+
+  describe 'validations' do
+    describe 'reasons' do
+      it 'defines valid reason constants' do
         expected_reasons = %w[
           age_under_19_exempt
           age_over_65_exempt
           pregnancy_exempt
           american_indian_alaska_native_exempt
         ]
-        expect(described_class.reasons.keys).to match_array(expected_reasons)
+        expect(Determination::VALID_REASONS).to match_array(expected_reasons)
       end
-    end
 
-    describe 'outcome' do
-      it 'defines the outcome enum with correct values' do
-        expect(described_class.outcomes.keys).to contain_exactly('compliant', 'exempt')
+      it 'validates presence of reasons' do
+        determination = build(:determination, reasons: nil)
+        expect(determination).not_to be_valid
+        expect(determination.errors[:reasons]).to be_present
+      end
+
+      it 'validates presence of non-empty reasons array' do
+        determination = build(:determination, reasons: [])
+        expect(determination).not_to be_valid
+        expect(determination.errors[:reasons]).to be_present
+      end
+
+      it 'allows valid reasons' do
+        determination = build(:determination, reasons: [ 'age_under_19_exempt' ])
+        expect(determination).to be_valid
+      end
+
+      it 'allows multiple valid reasons' do
+        determination = build(:determination, reasons: [ 'age_under_19_exempt', 'pregnancy_exempt' ])
+        expect(determination).to be_valid
+      end
+
+      it 'rejects invalid reasons' do
+        determination = build(:determination, reasons: [ 'invalid_reason' ])
+        expect(determination).not_to be_valid
+        expect(determination.errors[:reasons]).to include(match(/must contain only valid reason values/))
+      end
+
+      it 'rejects mixed valid and invalid reasons' do
+        determination = build(:determination, reasons: [ 'age_under_19_exempt', 'invalid_reason' ])
+        expect(determination).not_to be_valid
+        expect(determination.errors[:reasons]).to include(match(/must contain only valid reason values/))
       end
     end
   end