rubocop-rspec fixes

Author: doshitan

app-rails/.rubocop.yml

@@ -1,5 +1,10 @@
-require:
+plugins:
   - rubocop-rspec
 inherit_gem:
   pundit: config/rubocop-rspec.yml
   rubocop-rails-omakase: rubocop.yml
+
+RSpec/ExampleLength:
+  Enabled: false
+RSpec/MultipleExpectations:
+  Enabled: false

app-rails/config/initializers/new_framework_defaults_7_2.rb

@@ -0,0 +1,70 @@
+# Be sure to restart your server when you modify this file.
+#
+# This file eases your Rails 7.2 framework defaults upgrade.
+#
+# Uncomment each configuration one by one to switch to the new default.
+# Once your application is ready to run with all new defaults, you can remove
+# this file and set the `config.load_defaults` to `7.2`.
+#
+# Read the Guide for Upgrading Ruby on Rails for more info on each option.
+# https://guides.rubyonrails.org/upgrading_ruby_on_rails.html
+
+###
+# Controls whether Active Job's `#perform_later` and similar methods automatically defer
+# the job queuing to after the current Active Record transaction is committed.
+#
+# Example:
+#   Topic.transaction do
+#     topic = Topic.create(...)
+#     NewTopicNotificationJob.perform_later(topic)
+#   end
+#
+# In this example, if the configuration is set to `:never`, the job will
+# be enqueued immediately, even though the `Topic` hasn't been committed yet.
+# Because of this, if the job is picked up almost immediately, or if the
+# transaction doesn't succeed for some reason, the job will fail to find this
+# topic in the database.
+#
+# If `enqueue_after_transaction_commit` is set to `:default`, the queue adapter
+# will define the behaviour.
+#
+# Note: Active Job backends can disable this feature. This is generally done by
+# backends that use the same database as Active Record as a queue, hence they
+# don't need this feature.
+#++
+# Rails.application.config.active_job.enqueue_after_transaction_commit = :default
+
+###
+# Adds image/webp to the list of content types Active Storage considers as an image
+# Prevents automatic conversion to a fallback PNG, and assumes clients support WebP, as they support gif, jpeg, and png.
+# This is possible due to broad browser support for WebP, but older browsers and email clients may still not support
+# WebP. Requires imagemagick/libvips built with WebP support.
+#++
+# Rails.application.config.active_storage.web_image_content_types = %w[image/png image/jpeg image/gif image/webp]
+
+###
+# Enable validation of migration timestamps. When set, an ActiveRecord::InvalidMigrationTimestampError
+# will be raised if the timestamp prefix for a migration is more than a day ahead of the timestamp
+# associated with the current time. This is done to prevent forward-dating of migration files, which can
+# impact migration generation and other migration commands.
+#
+# Applications with existing timestamped migrations that do not adhere to the
+# expected format can disable validation by setting this config to `false`.
+#++
+# Rails.application.config.active_record.validate_migration_timestamps = true
+
+###
+# Controls whether the PostgresqlAdapter should decode dates automatically with manual queries.
+#
+# Example:
+#   ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.select_value("select '2024-01-01'::date") #=> Date
+#
+# This query used to return a `String`.
+#++
+# Rails.application.config.active_record.postgresql_adapter_decode_dates = true
+
+###
+# Enables YJIT as of Ruby 3.3, to bring sizeable performance improvements. If you are
+# deploying to a memory constrained environment you may want to set this to `false`.
+#++
+# Rails.application.config.yjit = true

app-rails/spec/adapters/cognito_adapter_spec.rb

@@ -8,7 +8,9 @@
   let (:uid_generator) { -> { uid } }
 
   before do
+    # rubocop:disable RSpec/InstanceVariable
     @request.env["devise.mapping"] = Devise.mappings[:user]
+    # rubocop:enable RSpec/InstanceVariable
 
     allow(controller).to receive(:auth_service).and_return(
       AuthService.new(Auth::MockAdapter.new(uid_generator: uid_generator))

app-rails/spec/controllers/users/sessions_controller_spec.rb

@@ -2,7 +2,7 @@
 
 RSpec.describe Users::NewSessionForm do
   it "passes validation with valid email and password" do
-    form = Users::NewSessionForm.new(
+    form = described_class.new(
       email: "test@example.com",
       password: "password"
     )
@@ -11,33 +11,33 @@
   end
 
   it "requires email and password" do
-    form = Users::NewSessionForm.new({
+    form = described_class.new({
       email: "",
       password: ""
     })
 
     expect(form).not_to be_valid
-    expect(form.errors.of_kind?(:email, :blank)).to be_truthy
-    expect(form.errors.of_kind?(:password, :blank)).to be_truthy
+    expect(form.errors).to be_of_kind(:email, :blank)
+    expect(form.errors).to be_of_kind(:password, :blank)
   end
 
   it "requires a valid email" do
-    form = Users::NewSessionForm.new(
+    form = described_class.new(
       email: "not_an_email"
     )
 
     expect(form).not_to be_valid
-    expect(form.errors.of_kind?(:email, :invalid)).to be_truthy
+    expect(form.errors).to be_of_kind(:email, :invalid)
   end
 
   it "requires the honeypot field to be empty" do
-    form = Users::NewSessionForm.new(
+    form = described_class.new(
       email: "test@example.com",
       password: "password",
       spam_trap: "I am a bot"
     )
 
     expect(form).not_to be_valid
-    expect(form.errors.of_kind?(:spam_trap, :present)).to be_truthy
+    expect(form.errors).to be_of_kind(:spam_trap, :present)
   end
 end

app-rails/spec/forms/users/new_session_form_spec.rb

@@ -3,7 +3,7 @@
 valid_password = "password1234"
 
 RSpec.describe Users::RegistrationForm do
-  let (:form) { Users::RegistrationForm.new() }
+  let (:form) { described_class.new() }
 
   it "passes validation with valid email and password" do
     form.email = "test@example.com"
@@ -18,23 +18,23 @@
     form.password = ""
 
     expect(form).not_to be_valid
-    expect(form.errors.of_kind?(:email, :blank)).to be_truthy
-    expect(form.errors.of_kind?(:password, :blank)).to be_truthy
+    expect(form.errors).to be_of_kind(:email, :blank)
+    expect(form.errors).to be_of_kind(:password, :blank)
   end
 
   it "confirms the password matches" do
     form.password = valid_password
     form.password_confirmation = "not_the_same"
 
     expect(form).not_to be_valid
-    expect(form.errors.of_kind?(:password_confirmation, :confirmation)).to be_truthy
+    expect(form.errors).to be_of_kind(:password_confirmation, :confirmation)
   end
 
   it "requires a valid email" do
     form.email = "not_an_email"
 
     expect(form).not_to be_valid
-    expect(form.errors.of_kind?(:email, :invalid)).to be_truthy
+    expect(form.errors).to be_of_kind(:email, :invalid)
   end
 
   it "requires the honeypot field is empty" do
@@ -43,6 +43,6 @@
     form.spam_trap = "I am a bot"
 
     expect(form).not_to be_valid
-    expect(form.errors.of_kind?(:spam_trap, :present)).to be_truthy
+    expect(form.errors).to be_of_kind(:spam_trap, :present)
   end
 end

app-rails/spec/forms/users/registration_form_spec.rb

@@ -2,30 +2,30 @@
 
 RSpec.describe Users::VerifyAccountForm do
   it "passes validation with valid email and code" do
-    form = Users::VerifyAccountForm.new(email: "test@example.com", code: "123456")
+    form = described_class.new(email: "test@example.com", code: "123456")
 
     expect(form).to be_valid
   end
 
   it "requires email and code" do
-    form = Users::VerifyAccountForm.new(email: nil, code: nil)
+    form = described_class.new(email: nil, code: nil)
 
     expect(form).to be_invalid
-    expect(form.errors.of_kind?(:email, :blank)).to be_truthy
-    expect(form.errors.of_kind?(:code, :blank)).to be_truthy
+    expect(form.errors).to be_of_kind(:email, :blank)
+    expect(form.errors).to be_of_kind(:code, :blank)
   end
 
   it "requires email to be a valid email" do
-    form = Users::VerifyAccountForm.new(email: "invalid-email", code: "123456")
+    form = described_class.new(email: "invalid-email", code: "123456")
 
     expect(form).to be_invalid
-    expect(form.errors.of_kind?(:email, :invalid)).to be_truthy
+    expect(form.errors).to be_of_kind(:email, :invalid)
   end
 
   it "requires code to be 6 characters" do
-    form = Users::VerifyAccountForm.new(email: "test@example.com", code: "12345")
+    form = described_class.new(email: "test@example.com", code: "12345")
 
     expect(form).to be_invalid
-    expect(form.errors.of_kind?(:code, :wrong_length)).to be_truthy
+    expect(form.errors).to be_of_kind(:code, :wrong_length)
   end
 end

app-rails/spec/forms/users/verify_account_form_spec.rb

@@ -17,11 +17,11 @@
     }
 
     it "returns true if the access token expires within the designated minutes" do
-      expect(user.access_token_expires_within_minutes?(access_token, 5)).to eq(true)
+      expect(user.access_token_expires_within_minutes?(access_token, 5)).to be(true)
     end
 
     it "returns false if the access token is not expiring within the designated minutes" do
-      expect(user.access_token_expires_within_minutes?(access_token, 1)).to eq(false)
+      expect(user.access_token_expires_within_minutes?(access_token, 1)).to be(false)
     end
   end
 end