Fix tests

Author: lorenyu

app-rails/app/models/user.rb

@@ -13,9 +13,6 @@ class User < ApplicationRecord
   validates :provider, presence: true
 
   # == Methods ==============================================================
-  def superadmin?
-    email.include?("+admin")
-  end
 
   # Check if the access token is expired or will expire within the next `minutes` minutes.
   # Access token is only stored in the session, so it needs passed in, rather than accessed from the model.

app-rails/spec/controllers/users/registrations_controller_spec.rb

@@ -9,21 +9,11 @@
     )
   end
 
-  describe "GET new_applicant" do
-    it "renders with applicant content and role" do
-      get :new_applicant, params: { locale: "en" }
+  describe "GET new" do
+    it "renders" do
+      get :new, params: { locale: "en" }
 
-      expect(response.body).to have_selector("h1", text: /create an applicant account/i)
-      expect(response.body).to have_field("users_registration_form[role]", with: "applicant", type: :hidden)
-    end
-  end
-
-  describe "GET new_employer" do
-    it "renders with employer content and role" do
-      get :new_employer, params: { locale: "en" }
-
-      expect(response.body).to have_selector("h1", text: /create an employer account/i)
-      expect(response.body).to have_field("users_registration_form[role]", with: "employer", type: :hidden)
+      expect(response.body).to have_selector("h1", text: /create an account/i)
     end
   end
 

app-rails/spec/factories/user_role_factory.rb

@@ -4,17 +4,5 @@
     uid { Faker::Internet.uuid }
     provider { "factory_bot" }
     mfa_preference { "opt_out" }
-
-    trait :applicant do
-      user_role { create(:user_role, :applicant) }
-    end
-
-    trait :employer do
-      user_role { create(:user_role, :employer) }
-    end
-
-    trait :superadmin do
-      email { "test+admin@navapbc.com" }
-    end
   end
 end

app-rails/spec/factories/users_factory.rb

@@ -24,20 +24,4 @@
       expect(user.access_token_expires_within_minutes?(access_token, 1)).to eq(false)
     end
   end
-
-  describe "superadmin?" do
-    let(:user) { build(:user) }
-
-    pending "returns true for a superadmin"
-
-    it "returns false for a applicant" do
-      user.user_role = build(:user_role, :applicant)
-      expect(user.superadmin?).to eq(false)
-    end
-
-    it "returns false for an employer" do
-      user.user_role = build(:user_role, :employer)
-      expect(user.superadmin?).to eq(false)
-    end
-  end
 end