TSS-37: Add convenience methods for different task types in BusinessProcessBuilder (#87)

The following methods have been added:
- `staff_task`: For creating tasks assigned to staff members
- `system_process`: For creating automated process steps
- `applicant_task`: For creating tasks assigned to applicants
- `third_party_task`: For creating tasks assigned to external parties

These methods act as semantic wrappers around the generic `step` method,
making business process definitions more readable and type-safe.

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Loren Yu <yuloren@gmail.com>
Co-authored-by: Loren Yu <loren@navapbc.com>

Author: devin-ai-integration[bot]

app/models/flex/business_process_builder.rb

@@ -50,6 +50,22 @@ def step(name, step)
       steps[name] = step
     end
 
+    def staff_task(name)
+      step(name, Flex::StaffTask.new(name, StaffTaskCreationService))
+    end
+
+    def system_process(name, callable)
+      step(name, Flex::SystemProcess.new(name, callable))
+    end
+
+    def applicant_task(name)
+      step(name, Flex::ApplicantTask.new(name))
+    end
+
+    def third_party_task(name)
+      step(name, Flex::ThirdPartyTask.new(name))
+    end
+
     def transition(from, event_name, to)
       transitions[from] ||= {}
       transitions[from][event_name] = to

spec/acceptance/flex/passport_application_case_acceptance_spec.rb

@@ -12,7 +12,7 @@ module Flex
       kase = PassportCase.find_by_application_form_id(test_form.id)
       expect(kase).not_to be_nil
       expect(kase.status).to eq ("open")
-      expect(kase.business_process_current_step).to eq ("collect_application_info")
+      expect(kase.business_process_current_step).to eq ("submit_application")
 
       # submit application
       test_form.first_name = "John"

spec/dummy/app/business_processes/passport_business_process.rb

@@ -1,37 +1,31 @@
 PassportBusinessProcess = Flex::BusinessProcess.define(:passport, PassportCase) do |bp|
   # Define steps
-  bp.step('collect_application_info',
-    Flex::StaffTask.new("Collect App Info", StaffTaskCreationService))
+  bp.applicant_task('submit_application')
 
-  bp.step('verify_identity',
-    Flex::SystemProcess.new("Verify Identity", ->(kase) {
-      IdentityVerificationService.new(kase).verify_identity
-    }))
+  bp.system_process('verify_identity', ->(kase) {
+    IdentityVerificationService.new(kase).verify_identity
+  })
 
-  bp.step('manual_adjudicator_review',
-    Flex::StaffTask.new("Manual Adjudicator Review", AdjudicatorTaskCreationService))
+  bp.staff_task('manual_adjudicator_review')
 
-  bp.step('review_passport_photo',
-    Flex::SystemProcess.new("Review Passport Photo", ->(kase) {
-      PhotoVerificationService.new(kase).verify_photo
-    }))
+  bp.system_process('review_passport_photo', ->(kase) {
+    PhotoVerificationService.new(kase).verify_photo
+  })
 
-  bp.step('notify_user_passport_approved',
-    Flex::SystemProcess.new("Notify Passport Approval", ->(kase) {
-      UserNotificationService.new(kase).send_notification("approval")
-    }))
+  bp.system_process('notify_user_passport_approved', ->(kase) {
+    UserNotificationService.new(kase).send_notification("approval")
+  })
 
-  bp.step('notify_user_passport_rejected',
-    Flex::SystemProcess.new("Notify Passport Rejection", ->(kase) {
-      UserNotificationService.new(kase).send_notification("rejection")
-    }))
+  bp.system_process('notify_user_passport_rejected', ->(kase) {
+    UserNotificationService.new(kase).send_notification("rejection")
+  })
 
   # Define start step
-  bp.start_on_application_form_created('collect_application_info')
+  bp.start_on_application_form_created('submit_application')
 
   # Define transitions
-  bp.transition('collect_application_info', 'PassportApplicationFormSubmitted', 'verify_identity')
-  bp.transition('collect_application_info', 'application_cancelled', 'end')
+  bp.transition('submit_application', 'PassportApplicationFormSubmitted', 'verify_identity')
+  bp.transition('submit_application', 'application_cancelled', 'end')
   bp.transition('verify_identity', 'identity_verified', 'review_passport_photo')
   bp.transition('verify_identity', 'identity_warning', 'manual_adjudicator_review')
   bp.transition('manual_adjudicator_review', 'identity_verified', 'review_passport_photo')

spec/dummy/app/business_processes/test_business_process.rb

@@ -1,26 +1,15 @@
 TestBusinessProcess = Flex::BusinessProcess.define(:test, TestCase) do |bp|
   # Define steps
-  bp.step('staff_task',
-    Flex::StaffTask.new("staff_task", StaffTaskCreationService))
-
-  bp.step('system_process',
-    Flex::SystemProcess.new("system_process", ->(kase) {
-      Flex::EventManager.publish("event2", { case_id: kase.id })
-    }))
-
-  bp.step('staff_task_2',
-    Flex::StaffTask.new("staff_task_2", StaffTaskCreationService))
-
-  bp.step('applicant_task',
-    Flex::ApplicantTask.new("Submit Required Documents"))
-
-  bp.step('third_party_task',
-    Flex::ThirdPartyTask.new("Review Employee Leave Application"))
-
-  bp.step('system_process_2',
-    Flex::SystemProcess.new("system_process_2", ->(kase) {
-      Flex::EventManager.publish("event6", { case_id: kase.id })
-    }))
+  bp.staff_task('staff_task')
+  bp.system_process('system_process', ->(kase) {
+    Flex::EventManager.publish("event2", { case_id: kase.id })
+  })
+  bp.staff_task('staff_task_2')
+  bp.applicant_task('applicant_task')
+  bp.third_party_task('third_party_task')
+  bp.system_process('system_process_2', ->(kase) {
+    Flex::EventManager.publish("event6", { case_id: kase.id })
+  })
 
   # Define start step
   bp.start_on_application_form_created('staff_task')