Skip to content

Commit 32146d8

Browse files
committed
try matrix strategy
1 parent 024dab4 commit 32146d8

File tree

2 files changed

+12
-31
lines changed

2 files changed

+12
-31
lines changed

.github/workflows/ci-e2e-static-checks.yml

Lines changed: 11 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,16 @@ on:
1111
workflow_dispatch:
1212

1313
jobs:
14-
format:
15-
name: Format
14+
static-checks:
15+
name: ${{ matrix.check.name }}
1616
runs-on: ubuntu-latest
17+
strategy:
18+
matrix:
19+
check:
20+
- name: Format
21+
command: make e2e-format-check-native
22+
- name: Typecheck
23+
command: make e2e-type-check-native
1724

1825
steps:
1926
- name: Checkout code
@@ -35,32 +42,5 @@ jobs:
3542
if: steps.cache-node.outputs.cache-hit != 'true'
3643
run: make e2e-setup-ci
3744

38-
- name: Check formatting
39-
run: make e2e-format-check-native
40-
41-
typecheck:
42-
name: Typecheck
43-
runs-on: ubuntu-latest
44-
45-
steps:
46-
- name: Checkout code
47-
uses: actions/checkout@v4
48-
49-
- name: Set up Node.js
50-
uses: actions/setup-node@v4
51-
with:
52-
node-version: lts/*
53-
54-
- name: Cache Node.js dependencies
55-
id: cache-node
56-
uses: actions/cache@v4
57-
with:
58-
path: e2e/node_modules
59-
key: ${{ runner.os }}-node-${{ hashFiles('package-lock.json') }}
60-
61-
- name: Install dependencies
62-
if: steps.cache-node.outputs.cache-hit != 'true'
63-
run: make e2e-setup-ci
64-
65-
- name: Check typing
66-
run: make e2e-type-check-native
45+
- name: ${{ matrix.check.name }}
46+
run: ${{ matrix.check.command }}

e2e/{{app_name}}/tests/index.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ test.describe('Generic Webpage Tests', () => {
66
test('should load the webpage successfully', async ({ page }) => {
77
const response = await page.goto('/');
88
const title = await page.title();
9+
910
expect(response!.status()).toBe(200);
1011
});
1112

0 commit comments

Comments
 (0)