CLEANUP : change the range type of bop gbp

jooho812 · MinWooJin · commit 2de526b0e0e3 · 2017-09-26T12:28:09.000+09:00
diff --git a/engines/default/default_engine.c b/engines/default/default_engine.c
@@ -950,7 +950,7 @@ static ENGINE_ERROR_CODE
 default_btree_elem_get_by_posi(ENGINE_HANDLE* handle, const void* cookie,
                                const char *key, const size_t nkey,
                                ENGINE_BTREE_ORDER order,
-                               int from_posi, int to_posi,
+                               uint32_t from_posi, uint32_t to_posi,
                                eitem **eitem_array, uint32_t *eitem_count,
                                uint32_t *flags, uint16_t vbucket)
 {
diff --git a/engines/default/items.c b/engines/default/items.c
@@ -7384,7 +7384,7 @@ ENGINE_ERROR_CODE btree_posi_find_with_get(struct default_engine *engine,
 
 ENGINE_ERROR_CODE btree_elem_get_by_posi(struct default_engine *engine,
                                          const char *key, const size_t nkey,
-                                         ENGINE_BTREE_ORDER order, int from_posi, int to_posi,
+                                         ENGINE_BTREE_ORDER order, uint32_t from_posi, uint32_t to_posi,
                                          btree_elem_item **elem_array, uint32_t *elem_count, uint32_t *flags)
 {
     hash_item       *it;
@@ -7393,8 +7393,6 @@ ENGINE_ERROR_CODE btree_elem_get_by_posi(struct default_engine *engine,
     uint32_t rqcount;
     bool     forward;
 
-    assert(from_posi >= 0 && to_posi >= 0);
-
     pthread_mutex_lock(&engine->cache_lock);
     ret = do_btree_item_find(engine, key, nkey, true, &it);
     if (ret == ENGINE_SUCCESS) {
diff --git a/engines/default/items.h b/engines/default/items.h
@@ -584,7 +584,7 @@ ENGINE_ERROR_CODE btree_posi_find_with_get(struct default_engine *engine,
 
 ENGINE_ERROR_CODE btree_elem_get_by_posi(struct default_engine *engine,
                                   const char *key, const size_t nkey,
-                                  ENGINE_BTREE_ORDER order, int from_posi, int to_posi,
+                                  ENGINE_BTREE_ORDER order, uint32_t from_posi, uint32_t to_posi,
                                   btree_elem_item **elem_array, uint32_t *elem_count, uint32_t *flags);
 
 #ifdef SUPPORT_BOP_SMGET
diff --git a/engines/demo/demo_engine.c b/engines/demo/demo_engine.c
@@ -610,7 +610,7 @@ static ENGINE_ERROR_CODE
 Demo_btree_elem_get_by_posi(ENGINE_HANDLE* handle, const void* cookie,
                                const char *key, const size_t nkey,
                                ENGINE_BTREE_ORDER order,
-                               int from_posi, int to_posi,
+                               uint32_t from_posi, uint32_t to_posi,
                                eitem **eitem_array, uint32_t *eitem_count,
                                uint32_t *flags, uint16_t vbucket)
 {
diff --git a/include/memcached/engine.h b/include/memcached/engine.h
@@ -580,7 +580,7 @@ extern "C" {
         ENGINE_ERROR_CODE (*btree_elem_get_by_posi)(ENGINE_HANDLE *handle, const void* cookie,
                                              const char *key, const size_t nkey,
                                              ENGINE_BTREE_ORDER order,
-                                             int from_posi, int to_posi,
+                                             uint32_t from_posi, uint32_t to_posi,
                                              eitem **eitem_array, uint32_t *eitem_count,
                                              uint32_t *flags, uint16_t vbucket);
 

Original file line number	Diff line number	Diff line change
`@@ -950,7 +950,7 @@ static ENGINE_ERROR_CODE`
`950`	`950`	`default_btree_elem_get_by_posi(ENGINE_HANDLE* handle, const void* cookie,`
`951`	`951`	`const char *key, const size_t nkey,`
`952`	`952`	`ENGINE_BTREE_ORDER order,`
`953`		`- int from_posi, int to_posi,`
	`953`	`+ uint32_t from_posi, uint32_t to_posi,`
`954`	`954`	`eitem *eitem_array, uint32_t eitem_count,`
`955`	`955`	`uint32_t *flags, uint16_t vbucket)`
`956`	`956`	`{`
Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,7 @@ static ENGINE_ERROR_CODE`
`610`	`610`	`Demo_btree_elem_get_by_posi(ENGINE_HANDLE* handle, const void* cookie,`
`611`	`611`	`const char *key, const size_t nkey,`
`612`	`612`	`ENGINE_BTREE_ORDER order,`
`613`		`- int from_posi, int to_posi,`
	`613`	`+ uint32_t from_posi, uint32_t to_posi,`
`614`	`614`	`eitem *eitem_array, uint32_t eitem_count,`
`615`	`615`	`uint32_t *flags, uint16_t vbucket)`
`616`	`616`	`{`