generalize path before create new path instance

Author: ksmail13

cover-checker-cobertura/src/main/java/com/naver/nid/cover/cobertura/CoberturaCoverageReportHandler.java

@@ -19,6 +19,7 @@
 import com.naver.nid.cover.parser.coverage.model.CoverageStatus;
 import com.naver.nid.cover.parser.coverage.model.FileCoverageReport;
 import com.naver.nid.cover.parser.coverage.model.LineCoverageReport;
+import com.naver.nid.cover.util.PathUtils;
 import lombok.extern.slf4j.Slf4j;
 import org.xml.sax.Attributes;
 
@@ -110,7 +111,7 @@ private CoverageStatus getCoverageStatus(Attributes attributes) {
 	 * @param attributes xml attribute
 	 */
 	private void initClass(Attributes attributes) {
-		Path filePath = Paths.get(attributes.getValue(ATTR_FILENAME));
+		Path filePath = Paths.get(PathUtils.generalizeSeparator(attributes.getValue(ATTR_FILENAME)));
 		if(log.isDebugEnabled()) {
 			log.debug("parse class {}({})", attributes.getValue("name"), filePath);
 		}

cover-checker-core/src/main/java/com/naver/nid/cover/parser/diff/DiffMapper.java

@@ -17,6 +17,7 @@
 
 import com.naver.nid.cover.parser.diff.exception.ParseException;
 import com.naver.nid.cover.parser.diff.model.*;
+import com.naver.nid.cover.util.PathUtils;
 import lombok.extern.slf4j.Slf4j;
 
 import java.nio.file.Path;
@@ -104,7 +105,7 @@ private Path removeNewFilePrefix(String path) {
 		if (path.startsWith("b/")) {
 			path = path.replaceFirst("b/", "");
 		}
-		return Paths.get(path);
+		return Paths.get(PathUtils.generalizeSeparator(path));
 	}
 
 	private Optional<List<DiffSection>> getDiffSectionListFromRawDiff(RawDiff rawDiff) {

cover-checker-core/src/test/java/com/naver/nid/cover/checker/NewCoverageCheckerTest.java

@@ -159,4 +159,46 @@ public void coverCheckTestForMultiModule() {
         NewCoverageCheckReport check = checker.check(coverage, diffList, 60, 0);
         assertEquals(newCoverageCheckReport, check);
     }
+
+    @Test
+    public void coverCheckTestForWindowPath() {
+        NewCoverageChecker checker = new NewCoverageChecker();
+
+        List<Line> lines = Arrays.asList(
+                Line.builder().lineNumber(1).type(ModifyType.ADD).build()
+                , Line.builder().lineNumber(2).type(ModifyType.ADD).build());
+
+        List<DiffSection> diffSectionList = Collections.singletonList(DiffSection.builder().lineList(lines).build());
+        List<Diff> diffList = Collections.singletonList(Diff.builder().fileName(Paths.get("src\\main\\com\\naver\\nid\\test.kt")).diffSectionList(diffSectionList).build());
+
+
+        LineCoverageReport lineCoverageReport = new LineCoverageReport();
+        lineCoverageReport.setStatus(CoverageStatus.COVERED);
+        lineCoverageReport.setLineNum(1);
+
+        LineCoverageReport lineCoverageReport2 = new LineCoverageReport();
+        lineCoverageReport2.setStatus(CoverageStatus.UNCOVERED);
+        lineCoverageReport2.setLineNum(2);
+
+        FileCoverageReport fileCoverageReport = new FileCoverageReport();
+        fileCoverageReport.setType("kt");
+        fileCoverageReport.setFileName(Paths.get("src\\main\\com\\naver\\nid\\test.kt"));
+        fileCoverageReport.setLineCoverageReportList(Arrays.asList(lineCoverageReport, lineCoverageReport2));
+        List<FileCoverageReport> coverage = Collections.singletonList(fileCoverageReport);
+
+        NewCoverageCheckReport newCoverageCheckReport = NewCoverageCheckReport.builder()
+                .threshold(60)
+                .totalNewLine(2)
+                .coveredNewLine(1)
+                .coveredFilesInfo(
+                        Collections.singletonList(NewCoveredFile.builder()
+                                .name(Paths.get("src\\main\\com\\naver\\nid\\test.kt"))
+                                .addedLine(2)
+                                .addedCoverLine(1)
+                                .build()))
+                .build();
+
+        NewCoverageCheckReport check = checker.check(coverage, diffList, 60, 0);
+        assertEquals(newCoverageCheckReport, check);
+    }
 }

cover-checker-core/src/test/resources/logback-test.xml

@@ -1,6 +1,10 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <configuration>
-    <include resource="pattern.xml" />
+    <appender name="console" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder>
+            <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level \(%file:%line\) %msg%n</pattern>
+        </encoder>
+    </appender>
 
     <root level="DEBUG">
         <appender-ref ref="console"/>

cover-checker-jacoco/src/main/java/com/naver/nid/cover/jacoco/JacocoXmlCoverageReportHandler.java

@@ -19,6 +19,7 @@
 import com.naver.nid.cover.parser.coverage.model.CoverageStatus;
 import com.naver.nid.cover.parser.coverage.model.FileCoverageReport;
 import com.naver.nid.cover.parser.coverage.model.LineCoverageReport;
+import com.naver.nid.cover.util.PathUtils;
 import lombok.extern.slf4j.Slf4j;
 import org.xml.sax.Attributes;
 
@@ -44,7 +45,7 @@ public void startElement(String uri, String localName, String qName, Attributes
 		if (localName.equals("")) localName = qName;
 		switch (localName) {
 			case "package":
-				pkgPath = attributes.getValue("name");
+				pkgPath = PathUtils.generalizeSeparator(attributes.getValue("name"));
 				log.debug("found new package {}", pkgPath);
 				break;
 			case "sourcefile":