Skip to content

Commit 7b61217

Browse files
authored
Merge pull request #29 from naver/ksmail13/fix/windows-test
Fix test example for windows
2 parents ba42d22 + a70cae4 commit 7b61217

File tree

8 files changed

+25
-25
lines changed

8 files changed

+25
-25
lines changed

.github/workflows/maven.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
shell: bash
2222
env:
2323
ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
24-
run: java -jar ./cover-checker-console/target/cover-checker-console-1.4.0-jar-with-dependencies.jar -c ./cover-checker-cobertura/target/site/jacoco -c ./cover-checker-console/target/site/jacoco -c ./cover-checker-core/target/site/jacoco/ -c ./cover-checker-github/target/site/jacoco -c ./cover-checker-jacoco/target/site/jacoco -t 80 -r $GITHUB_REPOSITORY -g $ACCESS_TOKEN -p $(echo $GITHUB_REF | awk 'BEGIN { FS = "/" } ; { print $3 }')
24+
run: java -jar ./cover-checker-console/target/cover-checker-console-1.4.1-jar-with-dependencies.jar -c ./cover-checker-cobertura/target/site/jacoco -c ./cover-checker-console/target/site/jacoco -c ./cover-checker-core/target/site/jacoco/ -c ./cover-checker-github/target/site/jacoco -c ./cover-checker-jacoco/target/site/jacoco -t 80 -r $GITHUB_REPOSITORY -g $ACCESS_TOKEN -p $(echo $GITHUB_REF | awk 'BEGIN { FS = "/" } ; { print $3 }')
2525
test-macos:
2626
runs-on: macos-latest
2727
steps:
@@ -32,13 +32,13 @@ jobs:
3232
java-version: 1.8
3333
- name: Build with Maven
3434
run: mvn clean package
35-
# test-window:
36-
# runs-on: windows-latest
37-
# steps:
38-
# - uses: actions/checkout@v2
39-
# - name: Set up JDK 1.8
40-
# uses: actions/setup-java@v1
41-
# with:
42-
# java-version: 1.8
43-
# - name: Build with Maven
44-
# run: mvn clean package
35+
test-window:
36+
runs-on: windows-latest
37+
steps:
38+
- uses: actions/checkout@v2
39+
- name: Set up JDK 1.8
40+
uses: actions/setup-java@v1
41+
with:
42+
java-version: 1.8
43+
- name: Build with Maven
44+
run: mvn clean package

cover-checker-cobertura/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>coverchecker</artifactId>
77
<groupId>com.naver.nid</groupId>
8-
<version>1.4.0</version>
8+
<version>1.4.1</version>
99
</parent>
1010
<modelVersion>4.0.0</modelVersion>
1111

cover-checker-console/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>coverchecker</artifactId>
77
<groupId>com.naver.nid</groupId>
8-
<version>1.4.0</version>
8+
<version>1.4.1</version>
99
</parent>
1010
<modelVersion>4.0.0</modelVersion>
1111

cover-checker-core/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>coverchecker</artifactId>
77
<groupId>com.naver.nid</groupId>
8-
<version>1.4.0</version>
8+
<version>1.4.1</version>
99
</parent>
1010
<modelVersion>4.0.0</modelVersion>
1111

cover-checker-github/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>coverchecker</artifactId>
77
<groupId>com.naver.nid</groupId>
8-
<version>1.4.0</version>
8+
<version>1.4.1</version>
99
</parent>
1010
<modelVersion>4.0.0</modelVersion>
1111

cover-checker-github/src/test/java/com/naver/nid/cover/github/reporter/GithubPullRequestReporterTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
@MockitoSettings(strictness = Strictness.LENIENT)
2525
class GithubPullRequestReporterTest {
2626

27-
private static final String COMMENT_WITH_FILE = "#### [PR Coverage check]\n" +
27+
private static final String COMMENT_WITH_FILE = ("#### [PR Coverage check]\n" +
2828
"\n" +
2929
":heart_eyes: **pass** : 2 / 3 (66.67%)\n" +
3030
"\n" +
@@ -35,9 +35,9 @@ class GithubPullRequestReporterTest {
3535
"| |path|covered line|new line|coverage|\n" +
3636
"|----|----|----|----|----|\n" +
3737
"|:large_blue_circle:|test.java|50|100|50.00%|\n" +
38-
"|:large_blue_circle:|test2.java|50|100|50.00%|\n\n\n";
38+
"|:large_blue_circle:|test2.java|50|100|50.00%|\n\n\n").replace("\n", System.lineSeparator());
3939

40-
private static final String COMMENT_WITH_CONFUSE = "#### [PR Coverage check]\n" +
40+
private static final String COMMENT_WITH_CONFUSE = ("#### [PR Coverage check]\n" +
4141
"\n" +
4242
":confused: **check** : 2 / 3 (66.67%)\n" +
4343
"\n" +
@@ -48,19 +48,19 @@ class GithubPullRequestReporterTest {
4848
"| |path|covered line|new line|coverage|\n" +
4949
"|----|----|----|----|----|\n" +
5050
"|:large_blue_circle:|test.java|50|100|50.00%|\n" +
51-
"|:red_circle:|test2.java|30|100|30.00%|\n\n\n";
51+
"|:red_circle:|test2.java|30|100|30.00%|\n\n\n").replace("\n", System.lineSeparator());
5252

53-
private static final String COMMENT_WITHOUT_FILE = "#### [PR Coverage check]\n" +
53+
private static final String COMMENT_WITHOUT_FILE = ("#### [PR Coverage check]\n" +
5454
"\n\n" +
55-
":heart_eyes: **pass** : 0 / 0 (0%)\n\n\n";
55+
":heart_eyes: **pass** : 0 / 0 (0%)\n\n\n").replace("\n", System.lineSeparator());
5656

57-
private static final String COMMENT_ERROR = "#### [PR Coverage check]\n" +
57+
private static final String COMMENT_ERROR = ("#### [PR Coverage check]\n" +
5858
"\n" +
5959
"coverage check fail. please retry. :fearful:\n" +
6060
"\n" +
6161
"[Please let me know](https://github.com/naver/cover-checker/issues/new) when error again.\n" +
6262
"\n" +
63-
"test error";
63+
"test error").replace("\n", System.lineSeparator());
6464

6565
private GithubPullRequestManager mockPrManager;
6666
private GithubCommentManager mockCommentManager;

cover-checker-jacoco/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>coverchecker</artifactId>
77
<groupId>com.naver.nid</groupId>
8-
<version>1.4.0</version>
8+
<version>1.4.1</version>
99
</parent>
1010
<modelVersion>4.0.0</modelVersion>
1111

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>com.naver.nid</groupId>
88
<artifactId>coverchecker</artifactId>
9-
<version>1.4.0</version>
9+
<version>1.4.1</version>
1010

1111
<modules>
1212
<module>cover-checker-github</module>

0 commit comments

Comments
 (0)