Skip to content

Commit 9c28672

Browse files
authored
fix: initialize with panel with defaultIndex when display: none (#903)
* fix: use defaultPanel when it equals nearestAnchor * test: add test for defaultIndex * test: fix test for initial panel when size is 0 * fix: remove autoInit at defaultIndex test
1 parent 1eaa5b0 commit 9c28672

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/Flicking.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1739,7 +1739,7 @@ class Flicking extends Component<FlickingEvents> {
17391739
if (!defaultPanel) return;
17401740

17411741
const nearestAnchor = camera.findNearestAnchor(defaultPanel.position);
1742-
const initialPanel = (nearestAnchor && defaultPanel.index !== nearestAnchor.panel.index) ? nearestAnchor.panel : defaultPanel;
1742+
const initialPanel = (nearestAnchor && defaultPanel.position !== nearestAnchor.panel.position && defaultPanel.index !== nearestAnchor.panel.index) ? nearestAnchor.panel : defaultPanel;
17431743
control.setActive(initialPanel, null, false);
17441744

17451745
if (!nearestAnchor) {

test/unit/Flicking.spec.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ describe("Flicking", () => {
7272
);
7373

7474
expect(flicking.currentPanel).not.to.be.null;
75-
expect(flicking.currentPanel).to.equal(flicking.camera.findNearestAnchor(0).panel);
75+
expect(flicking.currentPanel).to.equal(flicking.panels[0]);
7676
});
7777

7878
[15, 30, 50, 100].forEach((width) => {
@@ -205,6 +205,12 @@ describe("Flicking", () => {
205205

206206
expect(flicking.index).to.equal(0);
207207
});
208+
209+
it("should initialized with panel which has index equal to defaultIndex when panels are not visible.", async () => {
210+
const flicking = await createFlicking(El.DEFAULT_HORIZONTAL.setWidth(0), { defaultIndex: 1 });
211+
212+
expect(flicking.index).to.equal(1);
213+
});
208214
});
209215

210216
describe("horizontal", () => {

0 commit comments

Comments
 (0)