fix: check other props for react state change

malangfox · malangfox · commit 9d06d5a18957 · 2024-12-13T13:11:21.000+09:00
diff --git a/packages/react-flicking/src/react-flicking/Flicking.tsx b/packages/react-flicking/src/react-flicking/Flicking.tsx
@@ -267,7 +267,7 @@ class Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>>
       const nextChild = nextChildren[idx];
 
       if (child.key && nextChild.key) {
-        return child.key === nextChild.key;
+        return child.key === nextChild.key && Object.keys(child.props).every(key => child.props[key] === nextChild.props[key]);
       } else {
         return child === nextChild;
       }

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ class Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>>`
`267`	`267`	`const nextChild = nextChildren[idx];`
`268`	`268`
`269`	`269`	`if (child.key && nextChild.key) {`
`270`		`- return child.key === nextChild.key;`
	`270`	`+ return child.key === nextChild.key && Object.keys(child.props).every(key => child.props[key] === nextChild.props[key]);`
`271`	`271`	`} else {`
`272`	`272`	`return child === nextChild;`
`273`	`273`	`}`