opt-in to cell magics #559
Conversation
|
@MarcoGorelli : I am will review this PR tomorrow. Could you keep this open till then? |
nbqa/save_source.py
Outdated
| if magic_type != IPythonMagicType.CELL: | ||
| return False | ||
| first_line = source[0].lstrip() | ||
| return all(first_line.split()[0] != f"%%{i}" for i in process) |
There was a problem hiding this comment.
all(first_line.split()[0] != f"%%{i}" for i in process) could be simplified as first_line.split()[0].lstrip("%%") not in process
There was a problem hiding this comment.
Thanks! Though note that .lstrip("%%") is the same as .lstrip("%"). I've changed this slightly as lstrip is really unintuitive, and using it resulted in bug #500
tests/tools/test_mypy_works.py
Outdated
| {path_3}:cell_8:3: error: Name 'flake8_version' is not defined | ||
| {path_3}:cell_8:4: error: Name 'flake8_version' is not defined | ||
| Found 5 errors in 4 files (checked 20 source files) | ||
| Found 5 errors in 4 files (checked 22 source files) |
There was a problem hiding this comment.
Instead of updating this count every time, shall we do something like rglob on *.ipynb on the tests/data directory?
There was a problem hiding this comment.
yeah, definitely :) will keep that for a separate PR though as this one is big enough
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 733 752 +19
Branches 106 110 +4
=========================================
+ Hits 733 752 +19
Continue to review full report at Codecov.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 739 758 +19
Branches 106 110 +4
=========================================
+ Hits 739 758 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
closes #557