Change TilePos::y from uint8_t to int

BrentDaMage · BrentDaMage · commit 76febc6b61b8 · 2025-06-18T23:12:23.000-05:00
* Fixes integer overflow issues
diff --git a/source/world/level/TilePos.cpp b/source/world/level/TilePos.cpp
@@ -21,7 +21,7 @@ TilePos::TilePos(int _x, int _y, int _z)
 
 TilePos::TilePos(float _x, float _y, float _z)
 {
-    _init((int)floorf(_x), (uint8_t)floorf(_y), (int)floorf(_z));
+    _init((int)floorf(_x), (int)floorf(_y), (int)floorf(_z));
 }
 
 TilePos::TilePos(const Vec3& pos)
diff --git a/source/world/level/TilePos.hpp b/source/world/level/TilePos.hpp
@@ -15,7 +15,7 @@ struct ChunkPos;
 struct TilePos
 {
 	int x;
-	uint8_t y; // 255 height limit
+	int y; // We had this on uint8_t due to the 255 height limit, but this can overflow too easily
 	int z;
     
 private:

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ TilePos::TilePos(int _x, int _y, int _z)`
`21`	`21`
`22`	`22`	`TilePos::TilePos(float _x, float _y, float _z)`
`23`	`23`	`{`
`24`		`- _init((int)floorf(_x), (uint8_t)floorf(_y), (int)floorf(_z));`
	`24`	`+ _init((int)floorf(_x), (int)floorf(_y), (int)floorf(_z));`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`TilePos::TilePos(const Vec3& pos)`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ struct ChunkPos;`
`15`	`15`	`struct TilePos`
`16`	`16`	`{`
`17`	`17`	`int x;`
`18`		`- uint8_t y; // 255 height limit`
	`18`	`+ int y; // We had this on uint8_t due to the 255 height limit, but this can overflow too easily`
`19`	`19`	`int z;`
`20`	`20`
`21`	`21`	`private:`